Commit Graph

47791 Commits (1e8bebb20be0deb185f2287a1e930915fddab5eb)
 

Author SHA1 Message Date
Jesse Pretorius (odyssey4me) 1e8bebb20b Bump min openstacksdk version for os_network/{port_security_enabled,mtu}
To make use of the port_security_enabled [a] and mtu [b] parameters,
[c] and [d] need to be present in the openstacksdk or the os_network
module with return an error like:

TypeError: create_network() got an unexpected keyword argument 'port_security_enabled'

or:

TypeError: create_network() got an unexpected keyword argument 'mtu'

To handle this, we fail the module if one of the arguments are used
and the minimum openstacksdk version for that argument is not met.

[a] eaf238b033
[b] c6a8e99d34
[c] 8eb788af07
[d] a1fc820a2f

Backport-of: https://review.opendev.org/708119
Fixes: https://github.com/ansible/ansible/issues/62062
Change-Id: I2b80dc721a08bbdb530af3705ae99cf1b579d9f0
5 years ago
Andrew Klychkov f90c7411e8 Bugfix of 65351: mysql_db create dump with CREATE DATABASE and USE instruction 5 years ago
Bruno Meneguello cddecf8c05
Backport/2.9/60508 (#67531)
* route53: improve octal encoded characters handling

* Update changelogs/fragments/60508-route53-improve-octal-characters-handling.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
5 years ago
Felix Fontein a24dcf232c docker_login: fix permissions for ~/.docker/config.json (#67353)
* Fix permissions for ~/.docker/config.json.

* Add changelog, remove debug output.

(cherry picked from commit 55cb8c5388)
5 years ago
Matt Martz 6fc2ae7476 [stable-2.9] Clean up CONDITIONAL_BARE_VARS warning. Fixes #67735 (#67751).
(cherry picked from commit 6e1a59174a)

Co-authored-by: Matt Martz <matt@sivel.net>
5 years ago
Jordan Borean 0f7d62f6a5
ansible-galaxy - optimise some paths and use fake galaxy int tests (#67685) - 2.9 (#67874)
* ansible-galaxy - optimise some paths and use fake galaxy int tests (#67685)

* ansible-galaxy - optimise some paths and use fake galaxy int tests

* Added init, built, and publish tests

* Test against both mocked Galaxy and AH server

* Finish off writing the install tests

* Fix up broken tests

* Rename test target and add migrated tests

* Use cloud provider for Galaxy implementation

* Added blank static config

* Use correct alias group

* Set release version and fix copy typo

* Remove reset step as it is no longer needed

* Use sane env var names for test container name

(cherry picked from commit 26129fcb80)

* Use --api-key and not --token

* Set fallaxy tests as a smoketest

(cherry picked from commit b241c021b7)
5 years ago
Felix Fontein b38603c45e Templating: make sure only one variable results are cached (#67429)
* Make sure only one variable results are cached.

* Add changelog.

* Add test.

(cherry picked from commit c520d70bf4)
5 years ago
GomathiselviS 48bfa3e906
Fix to - eos_vlans using state parameter replaced is giving odd behavior (#67346)
* backport PR 67318

* added changelog file

* Added missing fixture file
5 years ago
Ganesh Nalawade 7cac554222 Add collection support for network platform agnostic modules (#66342)
*  Refactor net_base action plugin to invoke platform
   action plugin with implementation module name updated
   in the new task copy.

(cherry picked from commit 0d85ab1fe3)
5 years ago
Max Bubenick eb01926b43
Backport PR #67339 - Fix proxysql module cursor_class (#67471)
* Fix merge conflicts

* remove db_conn  as mysql_utils was not backported from devel

* fix indentation for sanity check
5 years ago
Jordan Borean 9c1794ebfd remove unused import 5 years ago
kaorihinata 39cfb63be6
Allow no_log=False to silence the no_log warnings for module parameters (#64733) (#67439)
As AnsibleModule._log_invocation is currently implemented, any parameter
with a name that matches PASSWORD_MATCH triggers the no_log warning as a
precaution against parameters that may contain sensitive data, but have not
been marked as sensitive by the module author.

This patch would allow module authors to explicitly mark the aforementioned
parameters as not sensitive thereby bypassing an erroneous warning message,
while still catching parameters which have not been marked at all by the
author.

Adds tests for various no_log states including True, False, and None (as
extracted by AnsibleModule._log_invocation) when applied to an argument with
a name that matches PASSWORD_MATCH.

Fixes: #49465 #64656
(cherry picked from commit 3ca4580cb4)
5 years ago
Andrew Klychkov 1bab4c99f3
Backport of 67645 docs/docsite/rst/: fix typos (#67649) 5 years ago
Andrew Klychkov 4cc4d77c4b
[2.9] Backport /docs/docsite/rst: fix typos (#67650)
* user_guide/intro_adhoc.rst: fix typo (#67644)

(cherry picked from commit 05a3192eb7)

* dev_guide/developing_modules_best_practices.rst: fix typo (#67639)

(cherry picked from commit 244277addd)

* /docs/docsite/rst/dev_guide: fix typos (#67643)

(cherry picked from commit 907c98ebcd)
5 years ago
Sam Doran c6a29ed7d2
[stable-2.9] Update example requirements file docs (#67626) (#67714)
Use "name" when possible rather than "src" to make the examples
of roles and collections in a single requirements files more
coherenant. Fundamentally, roles and collections are completely different.
But we can make the requiremets file easier to read by unifying the
format as much as possible.
(cherry picked from commit 6c70959131)

Co-authored-by: Sam Doran <sdoran@redhat.com>
5 years ago
Andrew Klychkov 0da817b827
postgresql_info module: fix broken link (#67517) (#67521)
(cherry picked from commit 5a7c58b2be)
5 years ago
Martin Nečas e047c8c70e
ovirt_disk: correct description of storage_domain (#67454) (#67518)
* ovirt_disk: correct description of storage_domain
* add changelog

Signed-off-by: mnecas <necas.marty@gmail.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Sandra McCann 80e5ed0bba
Specify lowercase only for Galaxy namespaces (#67485) (#67503)
* specify lowercase only for galaxy namespaces
* doh... include meta file

(cherry picked from commit a60feeb3c1)
5 years ago
Sandra McCann 79ad190f71
[backport][2.9]Add note that devel branch should not be used in real environments (#… (#67494)
* Add note that devel branch should not be used in real environments (#67483)

(cherry picked from commit 39fef58bea)
5 years ago
Jordan Borean 9895e18e24
Clarify b64encode with Python 2 (#67488) (#67491)
(cherry picked from commit 423a900791)
5 years ago
Felix Fontein a95c76855d
Fix broken links in crypto, docker and hetzner modules. (#67360) (#67363)
(cherry picked from commit 11e75b0af2)
5 years ago
Matt Clay 227f498314
stable-2.9: Restore Tower integration tests. (#67395)
* Move tower_common tests with tower_organization.

(cherry picked from commit c92697acec)

* Test: Bump TOWER_VERSION to supported version (#67378)

* Revert "Remove Tower module tests from CI. (#67368)"

This reverts commit b041d96762.

* Test: Bump TOWER_VERSION to 3.6.2

(cherry picked from commit b9bd2c25ca)

Co-authored-by: Yanis Guenane <yguenane@gmail.com>
5 years ago
Matt Clay 8fc3dfca32 Update Ansible release version to v2.9.5.post0. 5 years ago
Matt Clay 9388be4269 New release v2.9.5 5 years ago
Matt Clay 6f95e9629b
[stable-2.9] Remove Tower module tests from CI. (#67368) (#67371)
* [stable-2.9] Remove Tower module tests from CI. (#67368)

* Remove Tower module tests from CI.

The required AMIs are no longer available.

* Mark Tower tests as unsupported..
(cherry picked from commit b041d96762)

Co-authored-by: Matt Clay <mclay@redhat.com>

* Mark tower_common unsupported.
5 years ago
Felix Fontein aeade1412f
Docs: improve anchors vs. header bar (#67244) (#67317)
(cherry picked from commit fd43619f1a)
5 years ago
Martin Nečas b49d1d9810
Backport ovirt disk docs (#67301)
* ovirt_disk: update interface docs (#67272)
* add changelog
5 years ago
Sam Doran 04994e8dfb [stable-2.9] ansible-test - add constraint for virtualenv (#67289)
* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit 8f296a6533)

Co-authored-by: Sam Doran <sdoran@redhat.com>
5 years ago
Matt Davis 1dafd80eab
fix changelog entry failing rstcheck 5 years ago
Nilashish Chakraborty 54ca524da3
nxos_interfaces: RMB state fixes (#63960) (#67173)
* nxos_interfaces: RMB state fixes

* shippable fixes

* Add add'l comments per review

* fix long line

* Fix mode/enabled system defaults handling

* fix N3L test skips

* lint

* test updates for titanium images

* doc fix

(cherry picked from commit d72025be75)

Add changelog for nxos_interfaces fix

Co-authored-by: Chris Van Heuveln <cvanheuv@cisco.com>
5 years ago
James Cassell c956f9cffe
fix systemd use in container builds (#66062) (#67140)
* systemd: unify "systemctl show" failure cases

* systemd: is-enabled to detect configured state

* systemd: is-enabled to detect masked status

(cherry picked from commit b868f1c933)
5 years ago
James Cassell aa64519072
wait_for_connection: also retry interpreter discovery (#67040) (#67136)
self._discovered_interpreter_key is None unless a previous iteration
has attempted discovery.  In that case, force re-discovery, as the
previous attempt certainly failed.

(cherry picked from commit fd954a9c5c)
5 years ago
Tadej Borovšak 7b03b581dc
Make nios_txt_record use text field for object lookup (#67120)
Up until now, nios_txt_record assumed that the name and view
parameters uniquely described a TXT record. What this meant is that it
was impossible to have more than one TXT record with a certain name.

Changes in this commit expands the set of parameters that uniquely
identify the TXT record with a text field.
5 years ago
Felix Fontein 569218f0cd
Fix removed_in_version to support honor suboptions (#66918) (#67104)
* Add unit tests.
* Fix reporting for removed_in_version.
* Add changelog.

(cherry picked from commit fe454d27a1)
5 years ago
Brian Scholer f330286734
[Backport/2.9/66604] Fix powershell path_join for UNC path handling (#67073)
* Update to use os.ntpath

(cherry picked from commit 1522820612)

* Add changelog for #66604

(cherry picked from commit 40761c73b6)
5 years ago
Felix Fontein 42cae0a801
openssl_publickey: forgot to pass backend (#67036) (#67039)
* Forgot to pass backend.

* Add changelog.

* Pass on backend from get_fingerprint.

* Handle cryptography backend in get_fingerprint.

(cherry picked from commit a0e5e2e4c5)
5 years ago
Andrew Klychkov 5ca28963e5
Backport of 66806: mysql_variables not supporting variables name with dot (#67007) 5 years ago
Simon Dodsley 287ea7d319
Fix user_agent string not getting set (#67001)
(cherry picked from commit cb9e24fbd2)
5 years ago
Andrew Klychkov c529c86c1e
Backport of 66995: mysql_user doesnt support privileges with underscore (#66998) 5 years ago
Jesse Pretorius 5d406cffca
Bump minimum openstacksdk version when using os_network/dns_domain (#66952)
With the addition of [a], the minimum openstacksdk version needs to
be bumped to include [b], or the os_network module will return the
error:

TypeError: create_network() got an unexpected keyword argument 'dns_domain'

To handle this, we fail the module if the dns_domain argument is used
and the minimum openstacksdk version for that argument is not met.

[a] 6c74e29618
[b] a3e846e2b9

Fixes: #64495
Fixes: #64841
5 years ago
Nathaniel Case 31e348409f
[stable-2.9] nxos_facts: Don't fail if faninfo isn't reported (#66866) (#66949)
(cherry picked from commit bf65e7a)

Co-authored-by: Nathaniel Case <ncase@redhat.com>
5 years ago
Jiri Hnidek 69ba90098a
When no pool quantity is set, then do not set quantity to 1 (#66807) (#66933)
* Fixes #66478
* When no quantity is set, then candlepin server usually uses
  default value 1. When more quantities are required, then
  candlepin server can automatically choose correct minimal
  value.

(cherry picked from commit 6f1bb37feb)
5 years ago
Sumit Jaiswal f54263c459
Backport/2.9/55220 (#66757)
* Working Cisco IOS macro editing (fixes #55211) (#55220)

* Working Cisco IOS macro editing (fixes #55211)

* Working Cisco IOS macro editing [fixed pylints] (fixes #55211)

* Added integration tests for edit_macro

* Added conditional integration tests for ios_config macro

* Cosmetic fix: when near block for added conditional integration tests for ios_config macro

* Move teardown to always for block

(cherry picked from commit 4a0c875447)

* changelog

Co-authored-by: Albert Siersema <albert@mediacaster.nl>
5 years ago
René Moser 77985f2beb
galaxy: fix AttributeError on empty requirements.yml (#66726) (#66752)
* galaxy: fix AttributeError on empty requirements.yml

* add changelog

(cherry picked from commit 9e8fb5b7f5)
5 years ago
Sumit Jaiswal f8c4a38ffe
Backport PR to fix the duplication of IPV6 address with replace state in ios_l3_interfaces module (#66680)
* fix 66530 (#66654)


(cherry picked from commit 0c4f167b82)

* changelog

* Update 66654-fix-ipv6-duplication-for-replace-state-ios-l3-interfaces.yaml

Co-authored-by: Matt Davis <nitzmahone@users.noreply.github.com>
5 years ago
Ruediger Pluem 481327ec37
group - correctly determine if a local group exists. (#59772) (#67176)
Fixes #58619
Add integration test

(cherry picked from commit 80c4b86abe)
5 years ago
Sandra McCann 0ed22d1fbc
add info on creating doc fragments in a collection (#67171) (#67279)
* add info on creating doc fragments in a collection
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>

(cherry picked from commit 4dd2513371)
5 years ago
Florian Apolloner 361d7c677f
Fix DNF idempotency. (#66209) (#66578)
(cherry picked from commit a7e4479d01)
5 years ago
Abhijeet Kasurde 99c96bbf42
[2.9] gitlab_project_variable: Remove sensitive information (#66559)
Redact GitLab Project variables which might include sensetive information
such as password, api_keys and other project related details.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 84b68aa05f)
5 years ago
Peng Xiao 6f0f2c9d68
[stable-2.9]add one note to help ansible user to understand the requirements to (#65969) (#66493)
execute iosxr_command module

Signed-off-by: Peng Xiao <xiaoquwl@gmail.com>
(cherry picked from commit 69f9c3c8eb)
5 years ago