Commit Graph

47492 Commits (1c64dba3c9800deabb45b75bfd17b951b66e0eee)
 

Author SHA1 Message Date
Matt Clay 1c64dba3c9 Fix plugin names for collection plugins. (#60317)
* Fix plugin names for collection plugins.

Add an integration test to verify plugin __name__ is correct for collection plugins.

* Fix collection loader PEP 302 compliance.

The `find_module` function now returns `None` if the module cannot be found. Previously it would return `self` for modules which did not exist.

Returning a loader from `find_module` which cannot find the module will result in import errors on Python 2.x when using implicit relative imports.

* add changelog

* sanity/units/merge fixes
5 years ago
yanzhangi cbe8271745 update ce_static_route to fix bugs (#62498) 5 years ago
Sam Doran b7897e3a8d cron - Only run get_bin_path() once (#62554) 5 years ago
Jordan Borean 064e443ea5
psexec - Fix kerb and interactive support (#62556) 5 years ago
Matt Davis d0c7b42e58
fix collection jinja2 cache issue (#62543)
* prevents premature lookup (and potential KeyError) of Jinja filter/test function cache that's not fully populated
5 years ago
Jordan Borean bad338aca6
win_exec_wrapper - Be more defensive when trying to get output errors (#62376)
* win_exec_wrapper - Be more defensive when trying to get output errors

* Fix up property search
5 years ago
Jordan Borean bf5b6695ec Add hint for config option priority (#62463)
* Add hint for config option priority

* Fix some spelling issues
5 years ago
Old Schepperhand 864928365e Improve dconf documentation to include conversion problems (#62316) 5 years ago
Jordan Borean d16ee65ecd Add link to become plugins in become docs (#62462) 5 years ago
Marco Tulio R Braga a4a216640f chore/doc-module: sts_assume_role.py (#62475)
Update `Example` section with with the correct module usage.
5 years ago
Jean-Frédéric 951a80c8b0 cron - Use the default crontab executable in cron and cronvar modules (#59765)
In some remote environments, the `crontab` executable is
overloaded with a custom executable, which typically does
some pre/post processing before forwarding to crontab.

Instead of using the hardcoded `/usr/bin/crontab`, this uses
the `get_bin_path` utility to locate the default crontab executable.
5 years ago
Rohit b24f7d2800
vyosnoconfig tracebackfix (#62518)
* vyosnoconfig tracebackfix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos noconfig tracebackfix test cases added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test/integration/targets/vyos_lldp_global/tests/cli/empty_config.yaml
5 years ago
chkp-orso 55f285a384 fix if equals error code if command not found (#62529) 5 years ago
chkp-orso 2232232b45 fix delete to pass the right parameters (#62525) 5 years ago
chkp-orso cf8e84fc62 fix session_uid (#62523) 5 years ago
Jordan Borean 2e1c6a7839 Add fix for specifying current dir in collections_paths (#62478) 5 years ago
Sloane Hertel 66e5427ffb
cloudformation_info - fix KeyError (#62290)
* cloudformation_info - fix KeyError

* changelog
5 years ago
Andrey Klychkov b87b359df5 postgresql: move CI tests of *_owner, *_info, *_ping, *_query to separate targets (#62500) 5 years ago
Paul Belanger 05ef39551a
Remove unused variable from nxos module_utils (#62474)
This variable isn't used, remove it to make linters happy.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
5 years ago
Lukas Kämmerling d5449eed11 tests: hcloud: Enable hcloud_floating_ip_info tests (#62494) 5 years ago
Mike Wiebe 97b15e9f0c [stable-2.9] Stabilize nxos initiated copy for nxos_file_copy plugin (#62355)
* Retry spawn connection on failure

* Add debug logs

* Additional debug logs

* Close session before respawn attempt

* More debug info and increase loops

* Remove debug info and reset error dict on reconnect

* Add epdb debuger

* Add epdb debuger

* Add epdb debuger

* Wait before sending password and close pexpect session

* Fix comment typo

* Scrub error logs

* Scrub error logs

* Add more specific initial connect pattern

* Fix shippable errors

* Dont make remote_scp_server_password a hard requirement

* Add saftey check
5 years ago
Lukas Kämmerling fd7e156ccd Add hcloud_floating_ip module (#62409) 5 years ago
Pascal Van Acker 24ff3f257b fix azure_rm_rediscache notify notify_keyspace_events type (should be str) (#58922) 5 years ago
Matt Clay 7d40f6d53e Remove obsolete MANIFEST.in entries. 5 years ago
Pilou e51fa5c972 luks_device: ansibot wasn't able to extract author (#62464)
Ansibullbot ignores lines without 'author' or dash [1].

The following command allows to check that no other module is impacted:

    rgrep -A1 -P "^author:[[:space:]]*$" lib/ansible/modules/ |grep -P "\.py-[[:space:]]*[^-][[:space:]A-Za-z\"'@()]+$" -B1

Related: https://github.com/ansible/ansibullbot/issues/1106.

[1] 02ae638641/ansibullbot/utils/moduletools.py (L828)
5 years ago
yanzhangi 2d85cb3ded Update ce_info_center_global to fix bugs (#61283)
* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs
5 years ago
yanzhangi 9bf0e69601 Update ce_bgp_neighbor to fix bugs (#60634) 5 years ago
yanzhangi 8233389446 Update ce_netstream_export to fix bugs (#61652)
* Update ce_netstream_export to fix bugs

* Update ce_netstream_export to fix bugs
5 years ago
yanzhangi 80fa2a0816 Update ce_netstream_aging to fix bugs (#61653)
* Update ce_netstream_aging to fix bugs

* Update ce_netstream_aging to fix bugs
5 years ago
yanzhangi 027cd16b1a Update ce_snmp_target_host to fix bugs (#61842) 5 years ago
yanzhangi a260209098 Update ce_bgp_neighbor_af to fix bugs (#60937)
* Update ce_bgp_neighbor_af to fix bugs

* Update ce_bgp_neighbor_af to fix bugs

* Update ce_bgp_neighbor_af to fix bugs
5 years ago
yanzhangi 3cde0b5693 Update ce_evpn_global to fix bugs (#61013) 5 years ago
yanzhangi 80ead00838 Update ce_mtu to fix bugs (#61442) 5 years ago
yanzhangi 12512f7319 Update ce_vxlan_arp to fix bugs (#61995)
* Update ce_vxlan_arp to fix bugs

* Update ce_vxlan_arp to fix bugs
5 years ago
yanzhangi e559fafbc4 Update ce_vxlan_vap to fix bugs (#61996) 5 years ago
yanzhangi 90958b01c1 Update ce_evpn_bgp to fix bugs (#61136) 5 years ago
yanzhangi 1a8c1c7365 Update ce_evpn_bgp_rr to fix bugs (#61168) 5 years ago
yanzhangi 8eec5d2ab2 Update ce_interface_ospf to fix bugs (#61431) 5 years ago
yanzhangi 698e3eae5e Update ce_ntp to fix bugs (#61654) 5 years ago
yanzhangi 9d9863fec1 Update ce_ospf to fix bugs (#61684) 5 years ago
yanzhangi e1ca38e53a Update ce_snmp_traps to fix bugs (#61843) 5 years ago
yanzhangi 5f35916b22 update ce_bgp to fix bugs (#60573)
* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* update ce_bgp to fix bugs

* Update ce_bgp to fix bugs
5 years ago
yanzhangi db0f290ca3 Update ce_vrf_af to fix bugs (#61683) 5 years ago
yanzhangi 466c3e63ce Update ce_stp to fix bugs (#61774) 5 years ago
Xu Yuandong b2d145d924 ce_mlag_interface:update to fix a bug (#60144)
* update to fix a bug

* ansible-test Ignoring 'blacklisted-name' on 'lib/ansible/modules/network/cloudengine/ce_mlag_interface.py' is unnecessary

* update

* update

* update for shippable

* update for shippable

* Update ce_mlag_interface.py

* Update ce_mlag_interface.py

* Update ce_mlag_interface.py

* Update ce_mlag_interface.py
5 years ago
Matt Clay acd459f909
Add missing changelog fragments. (#62471)
* Add missing default-test-container 1.9.2 fragment.
* Add missing default-test-container 1.9.3 fragment.
5 years ago
Matt Clay 3b86dc3e12
WIP - Fix ansible-doc bugs and add integration tests. (#62461)
* Add integration tests for ansible-doc.

* Enable tests that now pass

* Cleanup processing of plugin docs

* Mostly separate the steps of processing plugin docs

  1) Acquire source data
  2) Transform and calculate additonal data
  3) Format data for output
  4) Output data

  format_plugin_doc() is still mixing transformation and formatting but
  that should be fixed in a devel-only change

* Raise exceptions in _get_plugin_doc() on errors.

* Remove check to exclude on blacklisted extensions.  We already request
  only .py files

* If there is no DOCUMENTATION entry in the plugin, raise an exception
  from _get_plugin_doc().  Everywhere we use _get_plugin_doc(), this is
  treated as an error

* If there is no ANSIBLE_METADATA raise an exception as well as
  displaying of docs assumes that this has been set.

* If there is neither DOCUMENTATION nor ANSIBLE_METADATA, warn about the
  lack of METADATA and error on the lack of DOCUMENTATION.  Lack of
  DOCUMENTATION is more important so it is what the user should see.

* Add a few special cases for backwards compat.  These should probably
  be made errors in 2.10:
  * no docs but has metadata shows no documentation rather than an error
  * empty plugin file shows no doumentation rather than an error

* Simplify backwards compatibility logic.
5 years ago
Gonéri Le Bouder b68f5b406a test: bump default-test-container
VMware VSphere SDK needs an up to date version of `pip` for the
installation step. With the current image, we face the following error:

```
(...)
02:27 Collecting git+https://github.com/vmware/vsphere-automation-sdk-python.git (from -r /root/ansible/test/lib/ansible_test/_data/requirements/integration.cloud.vcenter.txt (line 2))
02:27   Cloning https://github.com/vmware/vsphere-automation-sdk-python.git to /tmp/pip-req-build-pm27t16b
02:33 Requirement already satisfied: pyvmomi in /usr/local/lib/python3.6/dist-packages (from -r /root/ansible/test/lib/ansible_test/_data/requirements/integration.cloud.vcenter.txt (line 1)) (6.7.1.2018.12)
02:33 Requirement already satisfied: lxml>=4.3.0 in /usr/local/lib/python3.6/dist-packages (from vSphere-Automation-SDK==1.4.0->-r /root/ansible/test/lib/ansible_test/_data/requirements/integration.cloud.vcenter.txt (line 2)) (4.4.0)
02:33 Processing ./\\localhost/tmp/pip-req-build-pm27t16b/lib/vapi-runtime/vapi_runtime-2.12.0-py2.py3-none-any.whl
02:33 Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: '/root/ansible/\\\\localhost/tmp/pip-req-build-pm27t16b/lib/vapi-runtime/vapi_runtime-2.12.0-py2.py3-none-any.whl'
```

Bump default-test-container to 1.9.3 to get an up to date release of
`pip` (was 19.0.2, is now 19.2.3).
5 years ago
Alicia Cozine d3ec5ca80f Update pip module docs (#62359)
* Clarifying pip module requirements in reference to #47361

* Further clarifying message with link to ansible_python_interpreter

* Clarifies pip behavior

* incorporates review feedback
5 years ago
Gonéri Le Bouder 459677877a hcloud_networ_info: be more resilient is network already exists
We may already have an existing network or subnet. This commit ensures
we don't raise an error in this case.
e.g: https://app.shippable.com/github/ansible/ansible/runs/143559/145/tests
5 years ago