Commit Graph

45759 Commits (17c88724abd898700beec5ef53a37bf1f1e1fd68)
 

Author SHA1 Message Date
Kedar Kulkarni 17c88724ab Updating known_hosts module Docs (#58785) 5 years ago
Chris Archibald 6e3d54ae81 Set vscan_fileop_profile for na_ontap_cifs (#57373)
* new features

* update unit tests
5 years ago
Sam Doran 36da7e462a
Better fix for invalid data in 'options' field (#58353) 5 years ago
pratikgadiya12 e8f4ebb22c nmcli: Argument vlanid (int) is changed internally to string (#58963)
* Argument vlanid (int) is changed internally to string
* Modified test case to check vlan id

Fixes: #58949
5 years ago
Valeriy Zabawski cc4dc075f7 Adds minor improvements to 'zabbix_actions' module (#58379)
Changes:

    1. Update mandatory arguments in accordance with Zabbix API.
       Only esc_period, eventsource and name fields are mandatory.

       Reference: https://www.zabbix.com/documentation/3.0/manual/api/reference/action/object

    2. Add default values to argument options in order to prevent "TypeError: 'NoneType' object is not iterable" error.

    3. Add new condition operators (introduced in Zabbix 4.0 and 4.2)

    References:
      - https://www.zabbix.com/documentation/4.2/manual/api/reference/action/object#action_filter_condition
      - https://www.zabbix.com/documentation/4.0/manual/api/reference/action/object#action_filter_condition

    4. Update module documentation
5 years ago
Toshio Kuratomi 33d2728879 Rename python files in hacking/ directory to have .py suffix
ansible-test only passes files which have the .py suffix for sanity
tests on python files.  This change will allow sanity tests to run on
the Python files in hacking/

* Rename test-module to test-module.py
* Symlink test-module for backwards compat since end users may be using
  test-module
* Fix test-module sanity errors that are now triggered
* Rename ansible_profile to ansible-profile.py
* Rename build-ansible
5 years ago
Toshio Kuratomi 146a7f8ff6 Split the metaclass == type and from future boilerplate code.
The metaclass boilerplate is safe to apply en masse.  The future import
boilerplate needs code to be inspected to be sure that there aren't any
py2isms that need to be fixed.  Split these two checks so that we can
fix them independently

Be explicit about which files are grandfathered so we can fix them up one by one
5 years ago
Gonéri Le Bouder 909f7f2ce5 vmware_dvswitch_nioc: fix the integration test (#58920)
Correct the name of the vcenter variables.
5 years ago
Chris Archibald ee24e6c5be Qtree was not idempotent (#58596)
* fixes

* fixes
5 years ago
Jill R fd9b52f305 Add version_added to ec2 inv iam_role_arn option (#58945) 5 years ago
flowerysong c513c1e2d3 aws_s3: Improve ETag handling (#46332)
* cosmetic: Remove useless call to ec2_argument_spec()

* aws_s3: Improve ETag handling

* Extract ETag calculation into a utility function for reuse by
  aws_s3_sync.
* Reduce code duplication in put/get by restructuring the logic
* Only calculate ETag when overwrite == different
* Fail gracefully when overwrite == different and MD5 isn't available
  (e.g. due to FIPS-140-2).

* aws_s3: clean up integration tests

Clean up tests, add tests for overwrite settings in both directions.
5 years ago
bcavns01 0e7e3c0ae8 Add msg parameter to the mandatory filter (#56724)
* Add msg parameter to the mandatory filter

The `mandatory` filter would be more useful, particularly when dealing with nested dictionaries, with the simple addition of a `msg` parameter for supplying it with a custom failure message.
5 years ago
d-little 3ae2d15e45 add d-little maintainer to team_aix (#58653) 5 years ago
nmeuret 0194d17e4c Update win_iis_webapppool.py (#58930)
##### SUMMARY
Typo: to restart a pool, state should be "restarted", not "restart"
5 years ago
Marek Hulán 0a02b5ecc1 Update foreman maintainers (#58829) 5 years ago
Pilou b58c64e3b1 consul_session: ensure empty result is handled (#58694) 5 years ago
Matt Martz d1afcbced1
Cache handler name for included handlers. Fixes #58769 (#58780) 5 years ago
Sloane Hertel 982a36c915 Update contrib script documentation (#58883)
* Update contrib script documentation - new inventory solutions should be plugins, not scripts
5 years ago
anshulbehl 00d7aed56b
Changing LBName used by same task inside azure_rm_loadbalancer (#58936)
fixes #58933
5 years ago
Bryan Gurney 15d76d97a9 vdo: fix modify stage KeyError on unsupported parameter (#55160)
In "status: present" playbook execution for a VDO volume that is
absent, all of the parameters that are given in the playbook are
issued to the "vdo create" command, therefore any parameters that
become "unrecognized" will result in the "vdo" command returning an
error with the message "unrecognized arguments", which can then be
relayed back to the user.  This is a gracefully handled failure case.

Examples of "unrecognized" parameters are new features that are not
yet in the current version of VDO, or features that were removed
since the current version of VDO.

In "status: present" playbook execution for a VDO volume that is
already present, the same behavior as the "creation" stage of the
module should occur, but doesn't occur, since the key strings for
the "vdo status" output of the parameter do not exist.  This results
in a KeyError on the parameter that no longer exists.

Therefore, use "if statfield in processedvdos[desiredvdo]:" to filter
the modifiable parameters with the ones that are supported in this
VDO version, then use "if statfield not in processedvdos[desiredvdo]:"
to evade the KeyError, and add the "unsupported" parameters.

Also, instead of using the "currentvdoparams" dictionary, which
filters only the parameters reported by the "vdo status" output, use
the "modtrans" dictionary, which contains all of the possible
parameters.  Therefore, if the playbook specifies an "unsupported"
parameter, let it be passed on to the "vdo" command, to display an
actionable error message.

This fixes https://github.com/ansible/ansible/issues/54556

Signed-off-by: Bryan Gurney <bgurney@redhat.com>
5 years ago
Matt Clay c79afb1cba Move ansible-test unit coverage code into plugin. 5 years ago
shiro 49a1ec40aa fix typo "decend" (#58895)
fix typo "decend" to "descend"
5 years ago
Matt Clay 520af5cb47 Sanity test fixes for future collections support. 5 years ago
Paul Belanger 9e1b19e364 Fix nxos_install_os test cases typo (#58825)
This should be ansible_connection, not connection_type. We can also
update local testing logic.

Remove nxos_install_os/tasks/network_local.yaml as it is nolonger used.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
5 years ago
Sam Doran c68bf5997f
Add version 2.13 to the removed_in list (#58924) 5 years ago
Pilou ef1cf2d2e8 consul_session: ensure scheme parameter is used (#58692)
* Ensure an error occurs when unknown scheme is used
* consul_session: don't ignore 'scheme' parameter
5 years ago
Martin Krizek 7346b699ee
Use templated loop_var/index_var when looping include_* (#58866)
Fixes #58820
5 years ago
Gonéri Le Bouder ad49057330 fix the vm name 5 years ago
Tomorrow9 b7252b0815 fix type in doc issue 5 years ago
Tomorrow9 753b7d853f fix doc issue 5 years ago
Diane Wang b28614ea5a Update lib/ansible/modules/cloud/vmware/vmware_guest_sendkey.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Diane Wang 2fbf657cd4 Update lib/ansible/modules/cloud/vmware/vmware_guest_sendkey.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Diane Wang 5873521ddd Update lib/ansible/modules/cloud/vmware/vmware_guest_sendkey.py
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Tomorrow9 fcc0b71c74 add new module vmware_guest_sendkey 5 years ago
Andrey Klychkov 41b7b1c6e9 jboss module: actualize doc formatting (#58913)
* jboss module: actualize doc formatting, remove exceptions from ignore.txt
5 years ago
rajaspachipulusu17 753f998262 Pluribus Networks ipv6 security reguard vlan module with UT (#58319) 5 years ago
Andrey Klychkov 63b606ee94 postgresql_user: add integration tests (#58864)
* postgresql_user: add separate integration tests

* postgresql_user: add separate integration tests, add always block

* postgresql_user: add separate integration tests, include -> import_tasks, jinja checks

* postgresql_user: add separate integration tests, fix formatting

* postgresql_user: add separate integration tests, fix formatting

Co-Authored-By: Felix Fontein <felix@fontein.de>
5 years ago
Gonéri Le Bouder 13de8686e5 vmware: vmware_guidelines.rst
VMware specific documentation that explains:

- how to run the functional tests
- and the conventions.
- clarify the difference between govcsim and vcsim

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Chris Archibald 8731fc7a86 returning invalid security (#58595) 5 years ago
Matt Clay 9e67953b2e
Fix collection loader and add unit tests. (#58701)
* Use `compile` before `eval` in collection loader.

This fixes two issues:

1. File names are available when tracing execution, such as with code coverage.
2. Future statements are not inherited from the collection loader.

* Add unit tests for collection loading.

These tests verify several things:

1. That unit tests can import code from collections when the collection loader is installed.
2. That tracing reports the correct file and line numbers (to support code coverage).
3. That collection code does not inherit __future__ statements from the collection loader.

* Update unit test handling of the collection loader.

Since the collection loader is installed simply by importing ansible.plugins.loader,
we may already have a collection loader installed when the test runs. This occurs if
any other tests are collected which use that import during collection. Until that code
is moved into an initialization function to avoid loading during import, the unit tests
will need to replace any existing collection loaders so that they reflect the desired
configuration.

* Insert into sys.modules before calling exec.

This is a requirement of PEP 302.

It will prevent recursion errors when importing the current module or using a relative import.

* Use the correct value for __package__ in modules.

This allows using relative imports in collections.

* Add warning about modifying code for trace test.

* Add test for relative import in collection.

* Add __init__.py to collection to satisfy pylint.

The relative-beyond-top-level rule in pylint may not be appropriate for collections.
However, until that rule is disabled for collections this will keep tests passing.
5 years ago
Matt Clay 1e1463401d
Prepare ansible-test for supporting collections. (#58886)
This is a small but incomplete set of the initial changes for supporting testing of collections with ansible-test.
5 years ago
Benjamin R. Haskell 73a7a0877d Fix Pacman regex for unmatched Arch package name (#48558)
* Fix Pacman regex for unmatched Arch package name

`ansible -m pacman -a upgrade=yes $(hostname)` failed due to not
accounting for the `+` character in the `pacman -Qu` output line:

    libsigc++ 2.10.0-1 -> 2.10.1-1

Per the Arch wiki¹, package names can contain alphanumeric characters,
and any of {`@`, `.`, `_`, `+`, `-`}.

The existing `re` covered `_` (part of `\w` in Python), and `-`
(explicitly included). This change adds `@`, `.`, and `+` (in
ASCII-betical order).

¹: https://wiki.archlinux.org/index.php/Arch_package_guidelines#Package_naming

* Add explanation for `pacman -Qu` regex matching

* Remove unneeded non-capturing groups in regex
5 years ago
Sam Doran b9dafdbade
Move integration tests to using RHEL 8.0 GA (#57772) 5 years ago
Sam Doran 5ccd674dba
Update default test container to use Python 3.8.0b2 (#58877) 5 years ago
Samy Coenen 0befccbeb9 Update intro_inventory.rst (#58732) 5 years ago
Shachaf92 25a6e97046 win_firewall_rule - update doc for remoteport dep. on protocol (#58796) 5 years ago
Jordan Borean b6791e6ae3
ansible-galaxy: add collection sub command (#57106)
* ansible-galaxy: add collection init sub command

* Fix changelog and other sanity issues

* Slim down skeleton structure, fix encoding issue on template

* Fix doc generation code to include sub commands

* Added build step

* Tidy up the build action

* Fixed up doc changes and slight testing tweaks

* Re-organise tests to use pytest

* Added publish step and fixed up issues after working with Galaxy

* Unit test improvments

* Fix unit test on 3.5

* Add remaining build tests

* Test fixes, make the integration tests clearer to debug on failures

* Removed unicode name tests until I've got further clarification

* Added publish unit tests

* Change expected length value

* Added collection install steps, tests forthcoming

* Added unit tests for collection install entrypoint

* Added some more tests for collection install

* follow proper encoding rules and added more tests

* Add remaining tests

* tidied up tests and code based on review

* exclude pre-release versions from galaxy API
5 years ago
The Magician d336a989e4 Bug fixes for GCP modules (#58848) 5 years ago
The Magician 9721c4045b Bug fixes for GCP modules (#58849) 5 years ago
The Magician eb839c94ea Bug fixes for GCP modules (#58850) 5 years ago