Commit Graph

45722 Commits (13de8686e5195995508c3e4f95c472569a3885fd)
 

Author SHA1 Message Date
Gonéri Le Bouder 13de8686e5 vmware: vmware_guidelines.rst
VMware specific documentation that explains:

- how to run the functional tests
- and the conventions.
- clarify the difference between govcsim and vcsim

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Chris Archibald 8731fc7a86 returning invalid security (#58595) 5 years ago
Matt Clay 9e67953b2e
Fix collection loader and add unit tests. (#58701)
* Use `compile` before `eval` in collection loader.

This fixes two issues:

1. File names are available when tracing execution, such as with code coverage.
2. Future statements are not inherited from the collection loader.

* Add unit tests for collection loading.

These tests verify several things:

1. That unit tests can import code from collections when the collection loader is installed.
2. That tracing reports the correct file and line numbers (to support code coverage).
3. That collection code does not inherit __future__ statements from the collection loader.

* Update unit test handling of the collection loader.

Since the collection loader is installed simply by importing ansible.plugins.loader,
we may already have a collection loader installed when the test runs. This occurs if
any other tests are collected which use that import during collection. Until that code
is moved into an initialization function to avoid loading during import, the unit tests
will need to replace any existing collection loaders so that they reflect the desired
configuration.

* Insert into sys.modules before calling exec.

This is a requirement of PEP 302.

It will prevent recursion errors when importing the current module or using a relative import.

* Use the correct value for __package__ in modules.

This allows using relative imports in collections.

* Add warning about modifying code for trace test.

* Add test for relative import in collection.

* Add __init__.py to collection to satisfy pylint.

The relative-beyond-top-level rule in pylint may not be appropriate for collections.
However, until that rule is disabled for collections this will keep tests passing.
5 years ago
Matt Clay 1e1463401d
Prepare ansible-test for supporting collections. (#58886)
This is a small but incomplete set of the initial changes for supporting testing of collections with ansible-test.
5 years ago
Benjamin R. Haskell 73a7a0877d Fix Pacman regex for unmatched Arch package name (#48558)
* Fix Pacman regex for unmatched Arch package name

`ansible -m pacman -a upgrade=yes $(hostname)` failed due to not
accounting for the `+` character in the `pacman -Qu` output line:

    libsigc++ 2.10.0-1 -> 2.10.1-1

Per the Arch wiki¹, package names can contain alphanumeric characters,
and any of {`@`, `.`, `_`, `+`, `-`}.

The existing `re` covered `_` (part of `\w` in Python), and `-`
(explicitly included). This change adds `@`, `.`, and `+` (in
ASCII-betical order).

¹: https://wiki.archlinux.org/index.php/Arch_package_guidelines#Package_naming

* Add explanation for `pacman -Qu` regex matching

* Remove unneeded non-capturing groups in regex
5 years ago
Sam Doran b9dafdbade
Move integration tests to using RHEL 8.0 GA (#57772) 5 years ago
Sam Doran 5ccd674dba
Update default test container to use Python 3.8.0b2 (#58877) 5 years ago
Samy Coenen 0befccbeb9 Update intro_inventory.rst (#58732) 5 years ago
Shachaf92 25a6e97046 win_firewall_rule - update doc for remoteport dep. on protocol (#58796) 5 years ago
Jordan Borean b6791e6ae3
ansible-galaxy: add collection sub command (#57106)
* ansible-galaxy: add collection init sub command

* Fix changelog and other sanity issues

* Slim down skeleton structure, fix encoding issue on template

* Fix doc generation code to include sub commands

* Added build step

* Tidy up the build action

* Fixed up doc changes and slight testing tweaks

* Re-organise tests to use pytest

* Added publish step and fixed up issues after working with Galaxy

* Unit test improvments

* Fix unit test on 3.5

* Add remaining build tests

* Test fixes, make the integration tests clearer to debug on failures

* Removed unicode name tests until I've got further clarification

* Added publish unit tests

* Change expected length value

* Added collection install steps, tests forthcoming

* Added unit tests for collection install entrypoint

* Added some more tests for collection install

* follow proper encoding rules and added more tests

* Add remaining tests

* tidied up tests and code based on review

* exclude pre-release versions from galaxy API
5 years ago
The Magician d336a989e4 Bug fixes for GCP modules (#58848) 5 years ago
The Magician 9721c4045b Bug fixes for GCP modules (#58849) 5 years ago
The Magician eb839c94ea Bug fixes for GCP modules (#58850) 5 years ago
The Magician d88f686976 Bug fixes for GCP modules (#58851) 5 years ago
The Magician 4eba84ce78 New Module: gcp_appengine_firewall_rule_facts (#58853) 5 years ago
Fred-sun d1226b7663 Update azure_rm_subnet related document (#58445)
* Update azure_rm_subnet related document
5 years ago
shiro a269c564c7 Delete the negation symbol "¬" by typo. (#58640)
* Delete the negation symbol "¬"

* Update lib/ansible/modules/packaging/os/yum.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>
5 years ago
Sandra McCann e5a1d85092 clarify FQCN needs for plugins (#58870)
* clarify FQCN requirement, fix example
5 years ago
Brian Coca c2469648e4 Docs on general precedence (#50201)
* Add docs/docsite/rst/reference_appendices/general_precedence.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
5 years ago
Wojciech Sciesinski f9a31e3e17 Provide the list of packages in a modern way (#58668) 5 years ago
egalegal123 dbb1f01a56 Update vsphere_file.py (#58874)
wrong module name in examples
5 years ago
Fred-sun de7776e25d Update azure_rm_virtualmachinescaleset related document (#58699) 5 years ago
Sebastian Boehm 612223773a Daemonize service start on OpenBSD, fixes #50460 (#58528) 5 years ago
Richlv 1d50d308fc Minor typo/language fixes in the documentation (#58856)
Minor typo/language fixes in the zabbix_map documentation
5 years ago
Miguel Angel Muñoz González d50531c6bd New Fortinet's module for fortios_user_device (using new httpapi plugin) (#58291)
* New Fortinet's module for fortios_user_device (using new httpapi plugin

* Fix documentation errors

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>
5 years ago
Gonéri Le Bouder 140a8e53f3 vmware_guest: do not use infra.vm_list
Update the functional tests of `vmware_guest` to use the
`virtual_machines` data structure.
5 years ago
Sam Doran 1c2c1c15d0 dnf - fix error formatting of module name in error message (#58647) 5 years ago
pratikgadiya12 1f427249d5 Fixed examples module name in udm_dns_record (#58814)
Fixes: 58813
5 years ago
Andrey Klychkov 88ec5e14cb Add unit tests for lenient_lowercase function (#58586) 5 years ago
Will Thames 446919de6f Add apply to k8s module (#49053)
* Add apply to k8s module

Use apply method for updating k8s resources.

* Improve apply documentation

* k8s: Make apply and merge_type mutually exclusive
5 years ago
Dusan Matejka 105f60cf48 unified required zabbix-api dependency version and removed no longer needed extend of ZabbixAPI class (#53334) 5 years ago
Shachaf92 7ddcaafee5 many pslint fixes (#55862)
* Handles:

PSAvoidTrailingWhitespace
PSAvoidGlobalVars
PSAvoidAssignmentToAutomaticVariable
PSAvoidUsingCmdletAliases
PSAvoidUsingWriteHost
PSUseDeclaredVarsMoreThanAssignments
PSUsePSCredentialType
PSAvoidUsingPositionalParameters
PSAvoidUsingEmptyCatchBlock
PSAvoidUsingWMICmdlet

Replaced Write-Host with Write-Output
Added smart reboot check for win_domain feature installation
Modify the Creation of the pagefileto fit to CIM
Changelog fragment addition
Ignore.txt without fixes

* Changes after community reviews

* Change Out-Null to '> $null'

* Fixes after jborean93 comments

* Test

* Revert "Test"

This reverts commit 35c5c0648fa9d2868a18094d84954e53ffa28880.

* Removed all  > $null since they broke the module since the output got dumped

* run test again

* Revert "run test again"

This reverts commit 80eaf07143f9d8cb0116cbbc68a6a69c0ace840c.

* Changes after community review

* ignore PSUseDeclaredVarsMoreThanAssignments that are on a diffrent PR

* CI failed on extra line in ignore.txt

* Review changes

* PSlint errors

* Trail space

* send to null breaks the tests for  Set-Workgroup

* Lint stuff

* win_domain_user issue of indent.

* Update win_domain_user.ps1

* Update win_domain_membership.ps1

* Fix redirect to null

* lint space issue

* removed return from set-workgroup

* removed send to null
5 years ago
Max Calzavara 5689cc08ce Add examples (#58819)
* Add examples to the ios_vlan docs: vlan using aggregate and move vlan interface example
5 years ago
Nicolas Boutet 6a5bc5f206 Fix wrong unit in documentation example of ec2_metric_alarm (#58622) 5 years ago
Will Thames 88364d4cfd Add purge_tags to s3_bucket to allow preservation of existing tags (#58754)
* Add purge_tags to s3_bucket to allow preservation of existing tags

Adding `purge_tags` with default `True` to maintain existing behaviour
allows users to set it to `False` to preserve existing tags

Fixes #29366

* s3_bucket: Add further tests and improve tag handling further

Additional tests for purge_tags: False suggested some incorrect
logic and thus further improvements

Increase wait timeout on bucket deletion as it wasn't always completing
in the default 100 seconds
5 years ago
François Deppierraz 737da1853e os_user_role: add support for named domain (#49891)
Fixes #49859.
5 years ago
Abhijeet Kasurde 79fdc2190a role: Fix role's hash_params (#55263)
* role: Fix role's hash_params

Fix based upon work done by alikins.

Fixes: #20596

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
AndyG 894d19b108 Update ec2_snapshot.py (#58753)
ansible ec2_snapshot ValueError: time data '2019-05-27T12:08:49.929Z' does not match format '%Y-%m-%dT%H:%M:%S.000Z'
5 years ago
Lindsay Hill 5b2d1cc24d Fix broken slxos_config due to changed backup options (#58804) 5 years ago
Lindsay Hill 2eb499cbb3 Minor typo in sros_config docstrings (#58803)
Changed `f` to `If`
5 years ago
Diane Wang 9c140d26d5 VMware: add new module vmware_guest_network (#52075) 5 years ago
Shachaf92 5b953581b4 win_domain_user - MAke the query user try catch block more accurate (#58782)
* win_domain_user - MAke the query user try catch block more accurate for missing identity

* change to minor_changes

* Update win_domain_user-make-query-try-catch-accurate.yml

* Update win_domain_user-make-query-try-catch-accurate.yml
5 years ago
Dominik Holler 6e4c2c61bd Remove redundant line in os_port (#57838)
* Remove redundant line in os_port

The renaming of the key 'vnic_type' to 'binding:vnic_type'
is reduced to a single line.
The old key is removed to avoid to possibility of
inconsistency.

* Add missing parameter in example of os_port

In the example "Create port of type 'direct'" the parameter
"network" is added, because this parameter is required on
creating new ports.
5 years ago
Josh VanDeraa 73db7e2901 Changed command for next-hop-self to next-hop-self instead of activate (#58789) 5 years ago
Klaas Demter faf50dbace Fix nagios module to recognize if file exists and is fifo pipe (#58569)
add felixfontein suggestion to changelogs/fragments/58569-nagios-fifo-fix.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
5 years ago
smile37773 8ff97edd1a Add the singlePlacementGroup in the virtual machine scale set module (#58320) 5 years ago
Toshio Kuratomi 0c992d5ae4 Fix for skipping of gitlab_runner test.
Correct variable name for skipping of the gitlab test when gitlab python
client is not installed.
5 years ago
Toshio Kuratomi fed90efc4d Fix unicode error in changelog generation 5 years ago
Joseph 4f642daae5 Correct machinectl become plugin function arguments (#58734)
* Correct get_option function name and change flags to become_flags

* Remove the '--' from the returned command

* add changelog fragment

* change changelog fragment description

* move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571)
5 years ago
Dag Wieers 61647731e2
Fix regression in cron module (#58751)
This reverts the changes to cron from #28662

This fixes #58493
5 years ago