Commit Graph

5201 Commits (11792a9daaa62774bf31cbbd59fff197979f59d6)
 

Author SHA1 Message Date
Michael DeHaan 11792a9daa Merge pull request #2987 from kentfrazier/sudo_user
Fix bug with include-level vars and sudo_user.
11 years ago
Michael DeHaan b499f0754e Merge pull request #2986 from wbowling/devel
Fixes apt_repository always reporting file uri repos as changed
11 years ago
Michael DeHaan 82909179a0 Merge pull request #2976 from stoned/pip-virtualenv_command-pathname
Allow virtualenv_command argument of the pip module to be a pathname
11 years ago
Michael DeHaan 698b2fe9c5 Merge pull request #2992 from SirScott/service_pattern
Fixes #2991: Service module pattern argument ignored.
11 years ago
Michael DeHaan 84623441e1 Merge pull request #2945 from jsmartin/new_fetch
Fetch destination path can now be overriden.
11 years ago
Michael DeHaan 4fc6be8579 Merge pull request #2993 from SirScott/pkgng
Make pkgng and with_items result in a single module call.
11 years ago
Michael DeHaan e68894ea45 Merge pull request #2975 from stoned/doc-pip-fix
Fix pip module documentation (YAML quoting)
11 years ago
Michael DeHaan 4b988dbd43 Merge pull request #2978 from bryanlarsen/basename
add basename and dirname to the core jinja2 filters
11 years ago
Michael DeHaan 27236cf598 Merge pull request #2998 from SirScott/runner-permissions
Ensure the tmp_path is sufficiently open.
11 years ago
Michael DeHaan e3af9258ae Merge pull request #2995 from SirScott/pip-sudo-user
pip module -- sudo_user permission problem fix
11 years ago
Michael DeHaan c397969ca3 Merge pull request #3001 from SirScott/user-always-changing
Fixes #2924: User creation always reports 'changed'
11 years ago
Michael DeHaan 159ba7d68a Merge pull request #2956 from akerl/unicodefix
ignore unicode errors in stdout
11 years ago
Michael DeHaan 9d92125a93 Merge pull request #2989 from lorin/keystone_user
OpenStack Identity (keystone) user module
11 years ago
Michael DeHaan 6ed01d2d9c Merge pull request #2985 from bennojoy/devel
OpenStack Modules
11 years ago
Michael DeHaan 2459255739 Merge pull request #3016 from bpennypacker/airbrake_deployment
new airbrake_deployment module
11 years ago
Michael DeHaan 98a4331107 Merge pull request #2999 from ngrilly/python
Python
11 years ago
Michael DeHaan 5fdca267ac Merge pull request #3018 from dsedivec/devel
Plug-ins loaded from top-level plug-in directory
11 years ago
Michael DeHaan fd9bbeb4f3 Merge pull request #3019 from sergevanginderachter/debug-allways-verbose
Make debug module always verbose in playbooks
11 years ago
Serge van Ginderachter 94028852d9 Make debug module always verbose in playbooks
Created a new flag 'verbose_always' handled by
on_ok callback, similar to the 'verbose_override'
flag used by the setup module.
11 years ago
Dale Sedivec 611d56dc4c Plug-ins loaded from top-level plug-in directory
PluginLoader._get_paths, as of 391fb98e, was only finding plug-ins that
were in a subdirectory of one of the basedirs (i.e. in a category
directory).  For example, action_plugins/foo.py would never be loaded,
but action_plugins/bar/foo.py would work.

This makes it so that "uncategorized" plug-ins in the top level of a
directory such as action_plugins will be loaded, though plug-ins in a
"category" subdirectory will still be preferred.  For example,
action_plugins/bar/foo.py would be preferred over action_plugins/foo.py.
11 years ago
Bruce Pennypacker fceaca4a53 new airbrake_deployment module 11 years ago
Michael DeHaan 1d3782cfc7 Merge pull request #3006 from stoned/doc-fix-npm
Fix typo in npm module documentation preventing it to be processed by an...
11 years ago
Michael DeHaan 5c5b2204ac Merge pull request #3007 from stoned/doc-fix-git
Fix typo in git module documentation preventing it to be processed by an...
11 years ago
Stoned Elipot c9f268ac48 Fix typo in git module documentation preventing it to be processed by ansible-doc 11 years ago
Stoned Elipot 81e0a7adcc Fix typo in npm module documentation preventing it to be processed by ansible-doc 11 years ago
Scott Sturdivant 922a1efbc0 Fixes #2924: User creation always reports 'changed' 11 years ago
Scott Sturdivant 5516ece859 Ensure the tmp_path is sufficiently open. 11 years ago
Nicolas Grilly 7aee588918 Idiomatic Python: use in operator instead of method find 11 years ago
Nicolas Grilly 7babd30cf7 Idiomatic Python: use isinstance instead of type 11 years ago
James Martin 3c131dbd2b Initial Commit. 11 years ago
Scott Sturdivant b2542bff72 Chdir to tempdir to prevent permissions problems. 11 years ago
Scott Sturdivant d91bc1692e Make pkgng and with_items result in a single module call. 11 years ago
Scott Sturdivant b274fb9774 Fixes #2991: Service module pattern argument ignored. 11 years ago
Lorin Hochstein dbd9d92861 OpenStack Identity (keystone) user module
Module for managing users, tenants, and roles within OpenStack.
11 years ago
Kent Frazier 4c6583bd00 Fix bug with include-level vars and sudo_user.
If a variable was provided for an include, in either of these ways:

    ---
    - hosts: all
      tasks:
      - include: included.yml param=www-data
      - include: included.yml
        vars:
          param: www-data

and then that param was used as the value of sudo_user in the included
tasks:

    ---
    - name: do something as a parameterized sudo_user
      command: whoami
      sudo: yes
      sudo_user: $param

you would receive a "failed to parse: usage: sudo" error back and the
command would not execute.

This seemed to be due to a missing call to template.template somewhere,
because the final value being passed through ssh was still `$param`.
After some digging, the issue seems to instead have been a problem with
providing the wrong context to the template for expansion. Inside the
`Task` logic, it was passing `play.vars` as the context, where
`module_vars` seemed more appropriate. After replacing it, my test case
above ran without issue. There was a comment above suggesting that the
template call might be unnecessary, but removing it made the original
error return, since it is not getting escaped later down the line. I
removed the comment since it was inaccurate.

I tried to actually incorporate my test case above into the test suite
as a regression test, but was unable to figure out how to structure it.
The existing test infrastructure seemed to only be testing for correct
number of counts in things (ok vs. changed, etc.), without regard for
whether the content generated by the command is correct. If there is an
example of a test similar to this one (where I would want to check the
JSON generated to make sure sudo_user had been converted), please let me
know and I will be happy to submit an additional patch.
11 years ago
William Bowling 222f004bfa Fixes apt_repository always reporting file uri repos as changed 11 years ago
bennojoy b16e2a1d48 OpenStack Modules 11 years ago
Bryan Larsen f629baef11 add basename and dirname to the core jinja2 filters 11 years ago
Stoned Elipot d4d0753e03 Allow virtualenv_command argument of the pip module to be a pathname 11 years ago
Stoned Elipot 83cce7d2e0 Fix pip module documentation (YAML quoting) 11 years ago
Michael DeHaan 8f3b2b281f Merge pull request #2967 from jonEbird/devel
Inventory script for Spacewalk servers based on the spacewalk-reports pa...
11 years ago
Jon Miller dc8feb799c Do not need to chmod cache file each time
This is particularly important if you've manually ensured you have write
access via group permissions and not by owner.
11 years ago
Michael DeHaan aecc954aa4 Merge pull request #2965 from bpennypacker/devel
newrelic_deployment bug fix to support both python 2.4 and 2.6
11 years ago
Jon Miller 5111e0c2f7 Inventory script for Spacewalk servers based on the spacewalk-reports package 11 years ago
Bruce Pennypacker d4429fcb91 Fixed handling of urlopen result to work properly under both python 2.4 and python 2.6 11 years ago
Michael DeHaan 753ebea186 Prefer categorized modules to uncategorized, such that if someone does an install on top of old content
the categorized modules will win over the 1.1 uncategorized modules, as the packages may not automatically
clean up the old content.
11 years ago
Michael DeHaan cd57d59913 If ansible is configured to use a log file but cannot write to it, exit, but don't traceback. 11 years ago
Michael DeHaan 496f06c3c9 Pass variables to lookup function for those that want to use them. 11 years ago
Michael DeHaan 16709ecd76 Replace tab with spaces. 11 years ago
Dimos Alevizos e96bc981ce Set paramiko's logging level
Excplicity set paramiko's logging level to WARNING.
By default it inherits ansible's DEBUG logging level (set in
callbacks.py) and fills the log file with useless debug messages.
Obviously it only applies if log_path is set in ansible.cfg
11 years ago