Commit Graph

17785 Commits (068e322610397dfb35e40fb5201c33f53164019c)
 

Author SHA1 Message Date
Toshio Kuratomi d9f03cf014 Update submodule refs to pull in doc fixes 9 years ago
Tobias Wolf c5e46efbd9 Avoid recursively checking JSON inventory for Unicode
by moving to en-bloc unicode conversion to act on scripts stdout

Both python-json and simplejson always return unicode strings when using
their loads() method on unicode strings. This is true at least since
2009. This makes checking each substring unnecessary, because we do not
need to recursively check the strings contained in the inventory dict
later one-by-one

This commit makes parsing of large dynamic inventory at least 2 seconds
faster.

cf: https://github.com/towolf/ansible-large-inventory-testcase
9 years ago
Brian Coca 92579eb48f avoid shredding empty files, also x/0
also cleaned up unused import and exception var
9 years ago
Brian Coca d56e2fb80e corrected host/group match in inventory_hostnames
now the lookup works when using ! and & operators
fixes #13997
9 years ago
Toshio Kuratomi 1f930f098f Update core submodule to bring in yum fix 9 years ago
Toshio Kuratomi 63404821da rework run_command's env setting to not change os.environ for the rest of the module.
New param to run_command to modify the environment for just this invocation.
Documentation and comment adjustments.
9 years ago
Brian Coca cf75521bc8 updated submodule refs 9 years ago
Brian Coca 50d34f90e7 clarified with_file 9 years ago
Toshio Kuratomi 089f17bfc8 Don't tracback trying to retore settings
Can occur if we exit the timeout before the settings were changed
9 years ago
Toshio Kuratomi 27bf701260 Set decoding of path to unicode to raise an exception if non-utf8
Letting it pass would just cause an error later on (no such file found)
so it's better to catch it here and know that we have users dealing with
non-utf8 pathnames than to have to track it down from later on.
9 years ago
Toshio Kuratomi 299e42bc28 Make all parts of messages and pathnames into unicode so that we don't get UnicodeError tracebacks.
Note that the fix for display normalizing to unicode is correct but the
fix for pathnames is probably not.  Changing pathnames to unicode type
means that we will handle utf8 pathnames fine but pathnames can be any
sequence of bytes that do not contain null.  We do not handle sequences
of bytes that are not valid utf8 here.  To do that we need to revamp the
handling of basedir and paths to transform to bytes instead of unicode.
Didn't want to do that in 2.0.x as it will potentially introduce other
bugs as we find all the places that we combine basedir with other path
elements.  Since no one has raised that as an issue thus far so it's not
something we need to handle yet.  But it's something to keep in mind for
the future.

To test utf8 handling, create a utf8 directory and run a playbook from
within there.

To test non-utf8 handling (currently doesn't work as stated above), create
a directory with non-utf8 chars an run a playbook from there.  In bash,
create that directory like this: mkdir $'\377'

Fixes #13937
9 years ago
Brian Coca 2f40903397 clarify role include paths 9 years ago
Brian Coca 2ec31c2c79 fixed exception handling to be 2.4 compatible
previous 'fix' broke on 2.4
9 years ago
Brian Coca 7afd8e9640 added missed ec2_vpc_net_facts 9 years ago
Brian Coca 93781e0b05 be consistent about conversion to_str 9 years ago
Brian Coca edff4a9219 updated submodule refs 9 years ago
Toshio Kuratomi 69b8a48ed1 Turn results that come from traceback messages into unicode, not str.
Fixes #13964
Fixes #13967
9 years ago
Toshio Kuratomi 8f45660398 Update submodule refs 9 years ago
Toshio Kuratomi c8ffe94bf4 Fix proposed by @Yannig to fix become success detection when the output is multiline
See the Bug report for a specific error case with local connection,
sudo, and the raw module

Fixes #13728
9 years ago
Brian Coca c06b2e4622 correctly deals with non serializable type
combine_vars shoudl really be data types, but some just get in
in test, add dict to mock and avoid combine_vars using object
9 years ago
James Cammarata 1394cdf6b9 Fix set_fact + run_once to assign variables to all hosts in the list
Fixes #13921
9 years ago
James Cammarata 38a272b004 Allow module args as k=v pairs when using the module: option with local_action
This task format is valid in 1.x, but was broken in 2.x:
  - local_action:
     module: shell echo "hello world"
9 years ago
James Cammarata 97a5804a2c Minor cleanup when reassigning play context to reused connections
* Relocate the assignment of the host address to the remote_addr field
  in the play context, which was only done when the connection was created
  (it's now done after the post_validate() is called on the play context)
* Make the assignment of the play context to the connection an else, since
  it's not required if the connection is not reused
9 years ago
Karthik T 8436a88b5d Fixes #13763 Update connections _play_context on every iteration
If this isnt updated, the _connection is reused, and thus has an outdated _play_context
This results in outdated `success_key` and `prompt` causing issues if sudo is run in a loop
Refer to the issue #13763 for more debugging and details
9 years ago
Toshio Kuratomi 0bf20fab84 Fix erroneous fetch fail when fail_on_missing is set to False
Fixes #13832
9 years ago
Denis 22272fe5b8 Fix typos. 9 years ago
Brian Coca 7d8afbd83d fix issue with add_hosts overwriting existing vars
fixes github.com/ansible/ansible-modules-core/issues/2799 and is alternative to #13841
9 years ago
nitzmahone f11e54bcff update core submodule ref 9 years ago
Toshio Kuratomi 46a3a6a03e Non-newstyle modules can't use pipelining
This is because we pass arguments to non-newstyle modules via an
external file.  If we pipeline, then the interpreter thinks it has to
run the arguments as the script instead of what is piped in via stdin.
9 years ago
Brian Coca e29ae99b50 overwrite/merge not remove prev inventory data 9 years ago
Yannig Perré 363b74e498 Allow Ansible to return error with unicode within it.
Fix for https://github.com/ansible/ansible/issues/13899
9 years ago
James Cammarata 17b60f4fbf Fix typo in 0b86aa6 9 years ago
James Cammarata b89f211ed4 Hack to work around callback API change for v2_playbook_on_start 9 years ago
James Cammarata cde5d8444d When setting fail state skip RESCUE/ALWAYS if cur_block doesn't have them
Fixes #13749
9 years ago
James Cammarata 6cf0386a52 Tweak how strategies evaluate failed hosts via the iterator and bug fixes
* Added additional methods to the iterator code to assess host failures
  while also taking into account the block rescue/always states
* Fixed bugs in the free strategy, where results were not always being
  processed after being collected
* Added some prettier printing to the state output from iterator

Fixes #13699
9 years ago
Brian Coca b09f756195 now combine vars errors dump vars
very hard to debug w/o knowing what vars were being merged at the time of the error
9 years ago
Brian Coca 27f9b9dc43 md5 now uses smaller salt
fixes #13891
9 years ago
Brian Coca 31a951c4f7 only send event if tqm exists
fixes #13843
9 years ago
Toshio Kuratomi fe55e87ab4 Prevent traceback.
https://github.com/ansible/ansible/issues/13743#issuecomment-171520585

In some circumstance, the file fails to open.  When that occurs, we
can't try to close it in the finally clause.  Using a context manager is
the cleanest way to change the code to account for that case.
9 years ago
Toshio Kuratomi 2ed31fc818 Add python-setuptools to the requirements for running ansible as
python-setuptools contains the egginfo needed to make pkg_resources
work.
9 years ago
Toshio Kuratomi be087575cc Fix circular import 9 years ago
Toshio Kuratomi 79931041e2 do_encrypt import needed to move as well
Fixes #13861
9 years ago
Toshio Kuratomi 832a739331 use integer division instead of floating point division.
Fixes #13855
9 years ago
Toshio Kuratomi b83ef89f09 Add windows/unix newline change to the changelog 9 years ago
nitzmahone 419bd389d8 move core submodule ref for win_msi fix 9 years ago
Brian Coca e497e2b5c0 made loading of galaxy data files lazy 9 years ago
James Cammarata 16ae952888 re-adding the dummy debian changlog entry for packaging 9 years ago
sebastianneubauer 954eba8605 added galaxy data
not tested, but something like this seems to be missing in the Manifest.in
9 years ago
Brian Coca e4b701c00a added module name to missing interpreter error
fixes #13816
9 years ago
Emil Lind 21c22a2416 Allow InventoryScript JSON with childgroups only
and without hosts and vars

Without this patch, the simplified syntax is triggered when a group
is defined like this:

    "platforms": {
        "children": [
            "cloudstack"
        ]
    }

Which results in a group 'platforms' with 1 host 'platforms'.

more details in https://github.com/ansible/ansible/issues/13655
9 years ago