Commit Graph

45148 Commits (050f92f96054bf59e283fdec9972323c2ed00348)
 

Author SHA1 Message Date
Abhijeet Kasurde 050f92f960 [2.8] Callback: removing args from task_fields from Sumologic and Splunk plugin (#64273)
CVE-2019-14864 Ansible: Splunk and Sumologic callback plugins leak sensitive data in logs

Fixes #63522

Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit c76e074e4c)
6 years ago
Sam Doran 6749ffe824 [stable-2.8] paramiko_ssh - Improve authentication error message (#64157) (#64165)
The error is not always an invalid username/password. It could be a connection timeout or refusal.
(cherry picked from commit d5fbe6573b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
6 years ago
Abhijeet Kasurde 8b5cd5b64c sysctl: fix 'err' referenced before assignment (#64139)
* sysctl: fix 'err' referenced before assignment
* Add changelog

Fixes #63967

(cherry picked from commit 9069a681aa)
6 years ago
Sam Doran 0c89a97107 [stable-2.8] copy - check for changes beyond first level of subdirectories (#58323) (#64112)
Add integration test for copy: deep recursive with remote_src=True
(cherry picked from commit b7e38dfa52)

Co-authored-by: Alexander Korsunsky <A.Korsunsky@gmail.com>
6 years ago
Robert Osowiecki ba29567210 lineinfile - don't run os.makedirs on empty dir path (#63921) (#64090)
* Fix #63919: don't run os.makedirs on empty dir path

* integration test for lineinfile create: yes without path

(cherry picked from commit 3c978a3225)
6 years ago
Felix Fontein fc62483b3e ACMEAccount.get_request check status code value lower boundary (#63140) (#64072)
* check status code value lower boundary

Any HTTP code below 200 cannot be considered a success, should be
handled like a failure instead.

This is particularly true for below zero status codes.

Fixes #63139

* provide changelog fragment

* ensure connection errors are handled in Acme module

* add fetch_url check to ACME.send_signed_request

* remove module.fail_json

* move _assert_fetch_url_success out of ACMEAccount

* fix ansible-lint errors

* use simplified syntax status checking

(cherry picked from commit 0d905a0496)
6 years ago
Sam Doran f861c284d0 [stable-2.8] lineinfile - use correct index value when inserting at the end (#63696) (#63795)
(cherry picked from commit 92cd13a2cf)

Co-authored-by: Sam Doran <sdoran@redhat.com>
6 years ago
Sam Doran cbe69adf37 [stable-2.8] lineinfile - properly insert line when line exists and backrefs are enabled (#63763) (#63791)
Use a separate variable for the boolean test rather than having the same variable sometimes be a boolean and sometimes be a regular expression match object

Add integration tests to cover this scenario
(cherry picked from commit 29d4d318a5)

Co-authored-by: Sam Doran <sdoran@redhat.com>
6 years ago
Xu Yuandong d3a9bbc9d1 action/ce.py:clear configuration candidate when return to user-view. (#63513) (#63704)
* clear configuration candidate when return to user-view.

* add a changelog fragment for the pr.

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

(cherry picked from commit 47c31c201b)
6 years ago
Felix Fontein 0846bb85d3 Backportable subset of: openssl_csr: deprecate version option (#63432) (#63675)
Cherry-picked from ba686154b9.
6 years ago
Felix Fontein 484fd8271e Improve module return values (#63541) (#63645)
* Remove lists from contains:, fix types, some more details.

* Adjust types.

* Add new type.

* Re-add meraki_mx_l7_firewall docs at right indentation level.

(cherry picked from commit a129499cf4)
6 years ago
kamathe 95417c2260 ansible-vault: convert vault_password_files to list to prevent traceback (#57186) (#63622)
* Convert vault_password_files to a list

* Add changelog and tests
6 years ago
Guillaume Martinez f471f7a6b3 Backport 2.8: Fix Gitlab module deprecation warning (#60425) (#63498)
* Fix Gitlab module deprecation warning (#60425)

* gitlab modules : Fix deprecation warnings and parameters

Also preparing for 2.10 deprecation

* gitlab modules : Correct deprecation message

(cherry picked from commit 7bb90999d3)

* gitlab_modules :  remove misssing required parameter (#63690)

* gitlab_group: remove required=True on server_url param

* gitlab_project: remove required=True on server_url param

* Revert "Example incorrect: server_url is required argument (#63670)"

This reverts commit b02467961a.
This modification shouldn't have been made.
This parameter is deprecated and #60425 forget to remove the required
parameter

(cherry picked from commit 0af32a1093)

* gitlab modules : Add changelog
6 years ago
Jordan Borean a6687bef32 Fix issue when setting an empty pass to no_log param (#62804) - 2.8 (#62813)
* Fix issue when setting an empty pass to no_log param (#62804)

* Fix issue when setting an empty pass to no_log param

* Fix typo

(cherry picked from commit 322e225830)

* Fix up actual get for older versions
6 years ago
Matt Clay 34c76bf2a1 [stable-2.8] Switch from RHEL 8.0 & 8.1b to 8.1 in CI.
(cherry picked from commit 75646037dc)

Co-authored-by: Matt Clay <matt@mystile.com>
6 years ago
Sandra McCann 4afd3ad03b add porting guide for bare vars in conditionals (#60943) (#64289)
(cherry picked from commit 0b7d478200)
6 years ago
Sandra McCann 6dec6a736e [Doc-Release-2.9] Backport/2.8/docs release (#64270)
* docs: update version-checker to latest 3 versions (#64109)

(cherry picked from commit 409545825f)

* [Doc-Release-2.9] update release and maintenance page for 2.9 (#64166)

* update release and maintenance page for 2.9
* only 2.4 and earlier used the old changelog system

(cherry picked from commit 3f808d9ed6)
6 years ago
Kyle Sferrazza 76f046be72 win_hotfix: fix docs typo (#63807)
(cherry picked from commit b43a2b0607)
6 years ago
Sandra McCann 2ac8308edf Updated with slipped dates for the 2.9.0 release (#63243) (#63799)
(cherry picked from commit 5997d33381)
6 years ago
Toshio Kuratomi ebefd0b715 Update Ansible release version to v2.8.6.post0. 6 years ago
Toshio Kuratomi d778c59c43 New release v2.8.6 6 years ago
Felix Fontein 5eac93e7fd [2.8] Fix return value documentation (2/2) (#63534)
* Fix return value documentation (2/2) (#63478)
* Avoid validation errors for missing 'contains:'.
* Convert JSON text to JSON dict.
* example -> sample.
* Fix YAML.

(cherry picked from commit 4bc298af83)

* Update validate-modules/ignore.txt.
6 years ago
Felix Fontein 293ae8030b [2.8] Fix return value documentation (1/2) (#63517)
* Fix return value documentation (1/2) (#63477)
* Avoid validation errors for missing 'contains:'.

(cherry picked from commit 6bea1597cc)

* Add validate-modules/ignore.txt entries.
6 years ago
Sandra McCann d95ddf8519 Fix doc - porting_guide_2.8 value example (#63493) (#63525)
(cherry picked from commit e0f67b58ce)
6 years ago
Andrey Klychkov 4d322654e7 mysql_user: add seealso (#63497) (#63501)
(cherry picked from commit ecf71dd720)
6 years ago
Felix Fontein d1e198e8ea docker_node_info: improve error handling (#63418)
* Improve error handling for get_service_inspect().

* Add changelog fragment.

(cherry picked from commit d753168e9d)
6 years ago
Sam Doran 45278ceef7 [stable-2.8] user - fix shadow file parsing on AIX (#62547)
Initialize variables in case the shadow file is not found.
Handle IndexErrors if something goes wrong with file parsing.
(cherry picked from commit e9d10f94b7)

Co-authored-by: Sam Doran <sdoran@redhat.com>
6 years ago
yanzhangi 15ef4d119c [Backport/2.8/63331]Update ce_facts to fix bugs (#63456)
* Update ce_facts to fix bugs

(cherry picked from commit 73e7da40ff)

* Update ce_facts modified information
6 years ago
Xu Yuandong db083ad943 Backport/2.8/62471 ce_link_status:update to fix a bug. (#62417) (#63422)
* update to fix a bug. (#62417)


(cherry picked from commit 7541dab1ef)

* add a changelog fragment.
6 years ago
Sam Doran 3dfb8e81bb [stable-2.8] Properly mask no_log values is sub parameters during failure (#63405)
* Get no_log parameters from subspec

* Add changelog and unit tests

* Handle list of dicts in suboptions

Add fancy error message (this will probably haunt me)

* Update unit tests to test for list of dicts in suboptions

* Add integration tests

* Validate parameters in dict and list

In case it comes in as a string

* Make changes based on feedback, fix tests

* Simplify validators since we only need to validate dicts

Add test for suboptions passed in as strings to ensure they get validated properly and turned into a dictionary.

ci_complete

* Add a few more integration tests
(cherry picked from commit e9d29b1fe4)

Co-authored-by: Sam Doran <sdoran@redhat.com>
6 years ago
dgeo 33af5752cd [backport 2.8] facts: detect FreeBSD jails guest (#62857) (#62911)
* facts: detect FreeBSD jails guest (#62857)

* facts: detect FreeBSD jails

* PEP8 fix

* changelog for pr62913
6 years ago
Sam Doran bae45dd930 [stable-2.8] package_facts - use AnsibleModule.warn() for warnings
(cherry picked from commit 2b1e24f)

Co-authored-by: Sam Doran <sdoran@redhat.com>
6 years ago
Brian Coca 8dd0c80ab7 clarify package facts errors and warnings (#56060)
* clarify package facts errors and warnings

  fixes #56056

(cherry picked from commit 615db8e6f4)
6 years ago
Brian Coca ae1bbfa008 Package facts apt fix (#55963)
* fixes for apt on package_facts

* reverse order, apt is newer

* moved warnings prop to base

(cherry picked from commit 24a46deef5)
6 years ago
Alexander 12459b19b1 Added implicit initialization of APT package manager '_cache' field (#55851)
(cherry picked from commit c707dd7b62)
6 years ago
Felix Fontein 006156dee1 docker_image: fix option parameter so that warnings are issued (#63345)
* Fix option parameter so that warnings are issued.

* Add changelog.

(cherry picked from commit 61b3784131)
6 years ago
Xu Yuandong ffe9368d35 Backport/2.8/63332 ce_netstream_global: bugs fix(list index out of range) (#63332) (#63388)
* ce_netstream_global: bugs fix(list index out of range) (#63332)

* update to fix bugs:index out of range

* list index out of range

* list index out of range

* update for bad-whitespace

* Update ce_netstream_aging.py

* Update ce_netstream_aging.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_aging.py

(cherry picked from commit b7f12f9ff3)

* add a changelog fragment.

* Update 63388_ce_netsream_list_index_out_of_range.yml

changelogs/fragments/63388_ce_netsream_list_index_out_of_range.yml:5:1: empty-lines too many blank lines (1 > 0)
6 years ago
Xu Yuandong baec182fa9 Backport/2.8/59450 ce_file_copy: update to Compatible with multiple version of NETCONF A… (#63386)
* ce_file_copy: update to Compatible with multiple version of NETCONF API. (#59450)

* update to Compatible with multiple version of NETCONF API.

* update for  shippable.

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

(cherry picked from commit 86937e06e3)

* add a changelog fragment.
6 years ago
James Cassell b7fe3407c3 clean "changed" only after it has been processed (#59958)
* clean "changed" after it has been processed

without this change, a loop of `debug` tasks with `changed_when`
causes the "changed" status to get lost before output

* runme.sh tests for debug loop status

(cherry picked from commit bfd32c9b00)
6 years ago
Aliaksandr Dounar EPAM 6046da759f [2.8] Add cookie handling from issue #61672 (#62968)
* issue #61672 backporting in Ansible 2.8

* YAML extension added for Changelog fragment
6 years ago
Kevin Breit e56ee65ca7 Docs - Add Meraki to platform option list (#61651)
(cherry picked from commit 54906a68fe)
6 years ago
Felix Fontein f8cd3ca5a8 docker_* modules: docs improvements (#63165)
* Improve docker_container docs.

* Fix usage of C(...) and I(...).

* Fix abuses of I(...).

* tls_verify has been made an alias of validate_certs some time ago.

* Fix YAML problems.

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Fix order.

* Split long description.

* Improve formatting.

* Rewrite state docs.

* Make proper sentences.

(cherry picked from commit 5349b3ae4c)
6 years ago
Andrey Klychkov 3d8df9de72 lineinfile - fix bug with insertbefore/insertafter and firstmatch (#63194)
(cherry picked from commit 3b18337cac)
6 years ago
Xu Yuandong 533cd12a5d Backport/2.8/62587 module_utils/network/cloudengine:fix get_nc_next. (#62751)
* fix plugins/netconf/ce.py for netconf/capability/exchange (#60569)


(cherry picked from commit 037401b6e0)

* for capability/exchange/1.0 (#60630)

* for capability/exchange/1.0

* for capability/exchange/1.0

* update for shippable

* Update ce.py

* Update ce.py

(cherry picked from commit 28227c95a4)

* module_utils-network-cloudengine: fix get_nc_next. (#62587)

* fix get_nc_next.

* add a changelog fragment.

* upadte for  changelgo fragment.

* merge two prs, one depens another.

* merge two prs, one depens another.

* update changelog.

(cherry picked from commit d6ef7c8530)
6 years ago
yanzhangi ff5e23cbc9 [Backport/2.8/62589]update ce_bgp_af to fix bugs (#62651)
* update ce_bgp_af to fix bugs (#62589)

* update to fix bugs

* update to fix bugs

(cherry picked from commit 2a206f0e4c)

* Update ce_bgp_af modified information
6 years ago
yanzhangi f1df6ca828 [Backport/2.8/61442]Update ce_mtu to fix bugs (#62683)
* Update ce_mtu to fix bugs

(cherry picked from commit cb8a3a4c06)

* Update ce_mtu modified information
6 years ago
kr3ator 9a11582612 Bugfix for aggregate function in junos_user module (#62340)
* Update junos_user.py (#60459)

(cherry picked from commit c226c1015e)

* junos_module fixed issue with aggregate mode
6 years ago
yanzhangi 0a8221132d [Backport/2.8/61431]Update ce_interface_ospf to fix bugs (#62685)
* Update ce_interface_ospf modified information

* Update ce_interface_ospf to fix bugs

(cherry picked from commit b7e9bb8448)
6 years ago
yanzhangi 028496d256 [Backport/2.8/61283]Update ce_info_center_global to fix bugs (#62687)
* Update ce_info_center_global modified information

* Update ce_info_center_global to fix bugs (#61283)

* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs

* Update ce_info_center_global to fix bugs

(cherry picked from commit 2d85cb3ded)
6 years ago
yanzhangi 61a6a47ad4 [Backport/2.8/61168]Update ce_evpn_bgp_rr to fix bugs (#62689)
* Update ce_evpn_bgp_rr modified information

* Update ce_evpn_bgp_rr to fix bugs

(cherry picked from commit 2cb3da3fa6)
6 years ago