Also catch mysql errors so we can give the error message back through json rather than tracebacking

reviewable/pr18780/r1
Toshio Kuratomi 10 years ago
parent c9c08f885a
commit fbb9dcc69a

@ -498,16 +498,14 @@ def main():
if user_exists(cursor, user, host): if user_exists(cursor, user, host):
try: try:
changed = user_mod(cursor, user, host, password, priv, append_privs) changed = user_mod(cursor, user, host, password, priv, append_privs)
except SQLParseError, e: except (SQLParseError, InvalidPrivsError, MySQLdb.Error), e:
module.fail_json(msg=str(e))
except InvalidPrivsError, e:
module.fail_json(msg=str(e)) module.fail_json(msg=str(e))
else: else:
if password is None: if password is None:
module.fail_json(msg="password parameter required when adding a user") module.fail_json(msg="password parameter required when adding a user")
try: try:
changed = user_add(cursor, user, host, password, priv) changed = user_add(cursor, user, host, password, priv)
except SQLParseError, e: except (SQLParseError, InvalidPrivsError, MySQLdb.Error), e:
module.fail_json(msg=str(e)) module.fail_json(msg=str(e))
elif state == "absent": elif state == "absent":
if user_exists(cursor, user, host): if user_exists(cursor, user, host):

Loading…
Cancel
Save