Allows iptables chain creation with wait parameter (#84491)

* Allows iptables chain creation with wait parameter

Fixes #84490

* Add the changelog fragment for 84490

changelogs/fragments/84490-allow-iptables-chain-creation-with-wait.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - iptables - Allows the wait paramater to be used with iptables chain creation (https://github.com/ansible/ansible/issues/84490)

lib/ansible/modules/iptables.py

@@ -614,7 +614,6 @@ def append_wait(rule, param, flag):
 
 def construct_rule(params):
     rule = []
-    append_wait(rule, params['wait'], '-w')
     append_param(rule, params['protocol'], '-p', False)
     append_param(rule, params['source'], '-s', False)
     append_param(rule, params['destination'], '-d', False)
@@ -701,6 +700,8 @@ def push_arguments(iptables_path, action, params, make_rule=True):
     cmd.extend([action, params['chain']])
     if action == '-I' and params['rule_num']:
         cmd.extend([params['rule_num']])
+    if params['wait']:
+        cmd.extend(['-w', params['wait']])
     if make_rule:
         cmd.extend(construct_rule(params))
     return cmd
@@ -861,6 +862,7 @@ def main():
         rule=' '.join(construct_rule(module.params)),
         state=module.params['state'],
         chain_management=module.params['chain_management'],
+        wait=module.params['wait'],
     )
 
     ip_version = module.params['ip_version']
@@ -910,7 +912,7 @@ def main():
 
     else:
         # Create the chain if there are no rule arguments
-        if (args['state'] == 'present') and not args['rule']:
+        if (args['state'] == 'present') and not args['rule'] and args['chain_management']:
             chain_is_present = check_chain_present(
                 iptables_path, module, module.params
             )

test/units/modules/test_iptables.py

@@ -1196,6 +1196,7 @@ def test_chain_creation(mocker):
             "chain": "FOOBAR",
             "state": "present",
             "chain_management": True,
+            "wait": 10,
         }
     )
 
@@ -1224,6 +1225,8 @@ def test_chain_creation(mocker):
         "filter",
         "-L",
         "FOOBAR",
+        "-w",
+        "10",
     ]
 
     second_cmd_args_list = run_command.call_args_list[1]
@@ -1233,6 +1236,8 @@ def test_chain_creation(mocker):
         "filter",
         "-N",
         "FOOBAR",
+        "-w",
+        "10",
     ]
 
     commands_results = [
@@ -1257,6 +1262,7 @@ def test_chain_creation_check_mode(mocker):
             "chain": "FOOBAR",
             "state": "present",
             "chain_management": True,
+            "wait": 10,
             "_ansible_check_mode": True,
         }
     )
@@ -1285,6 +1291,8 @@ def test_chain_creation_check_mode(mocker):
         "filter",
         "-L",
         "FOOBAR",
+        "-w",
+        "10",
     ]
 
     commands_results = [