validate-modules improve empty version_added handling (#53177)

* Improve empty version_added handling

* Remove unrelated ignore
pull/53184/head
Matt Martz 6 years ago committed by GitHub
parent 29c9b4001d
commit f0a63e783d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -1370,7 +1370,8 @@ class ModuleValidator(Validator):
return return
try: try:
mod_version_added = StrictVersion( mod_version_added = StrictVersion()
mod_version_added.parse(
str(existing_doc.get('version_added', '0.0')) str(existing_doc.get('version_added', '0.0'))
) )
except ValueError: except ValueError:
@ -1415,11 +1416,11 @@ class ModuleValidator(Validator):
continue continue
try: try:
version_added = StrictVersion( version_added = StrictVersion()
version_added.parse(
str(details.get('version_added', '0.0')) str(details.get('version_added', '0.0'))
) )
version_added.version except ValueError:
except (ValueError, AttributeError):
version_added = details.get('version_added', '0.0') version_added = details.get('version_added', '0.0')
self.reporter.error( self.reporter.error(
path=self.object_path, path=self.object_path,

Loading…
Cancel
Save