2.3bug25844flowdock (#25873)

* Correct failure message in flowdock (#25844)

As per documentation and code, external_user_name is
required parameter is case of type 'chat'.
Fix corrects error message displayed to user.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit a4ebde1516)

* Fix for flowdock error message when external_user_name is missing

CHANGELOG.md

@@ -22,6 +22,7 @@ Ansible Changes By Release
 * Fix for fetch action plugin not validating correctly
 * Avoid vault view writing display to logs
 * htpasswd: fix passlib module version comparison
+* Fix for flowdock error message when external_user_name is missing
 
 ## 2.3.1 "Ramble On" - 2017-06-01
 

lib/ansible/modules/notification/flowdock.py

@@ -156,7 +156,7 @@ def main():
         else:
             params['external_user_name'] = module.params["external_user_name"]
     elif type == 'chat':
-        module.fail_json(msg="%s is required for the 'inbox' type" % item)
+        module.fail_json(msg="external_user_name is required for the 'chat' type")
 
     # required params for the 'inbox' type
     for item in [ 'from_address', 'source', 'subject' ]: