Merge pull request #12867 from bcoca/callback_whitelist_tweak

make callbacks declare needing whitelisting

lib/ansible/executor/task_queue_manager.py

@@ -153,12 +153,13 @@ class TaskQueueManager:
                 # the name of the current plugin and type to see if we need to skip
                 # loading this callback plugin
                 callback_type = getattr(callback_plugin, 'CALLBACK_TYPE', None)
+                callback_needs_whitelist  = getattr(callback_plugin, 'CALLBACK_NEEDS_WHITELIST', False)
                 (callback_name, _) = os.path.splitext(os.path.basename(callback_plugin._original_path))
                 if callback_type == 'stdout':
                     if callback_name != self._stdout_callback or stdout_callback_loaded:
                         continue
                     stdout_callback_loaded = True
-                elif C.DEFAULT_CALLBACK_WHITELIST is None or callback_name not in C.DEFAULT_CALLBACK_WHITELIST:
+                elif callback_needs_whitelist and (C.DEFAULT_CALLBACK_WHITELIST is None or callback_name not in C.DEFAULT_CALLBACK_WHITELIST):
                     continue
 
                 self._callback_plugins.append(callback_plugin(self._display))

lib/ansible/plugins/callback/context_demo.py

@@ -28,7 +28,8 @@ class CallbackModule(CallbackBase):
     """
     CALLBACK_VERSION = 2.0
     CALLBACK_TYPE = 'aggregate'
-    CALLBACK_TYPE = 'context_demo'
+    CALLBACK_NAME = 'context_demo'
+    CALLBACK_NEEDS_WHITELIST = True
 
     def v2_on_any(self, *args, **kwargs):
         i = 0

lib/ansible/plugins/callback/hipchat.py

@@ -46,8 +46,9 @@ class CallbackModule(CallbackBase):
 
     """
     CALLBACK_VERSION = 2.0
-    CALLBACK_VERSION = 2.0
+    CALLBACK_TYPE = 'notification'
     CALLBACK_NAME = 'hipchat'
+    CALLBACK_NEEDS_WHITELIST = True
 
     def __init__(self, display):
 

lib/ansible/plugins/callback/log_plays.py

@@ -40,6 +40,7 @@ class CallbackModule(CallbackBase):
     CALLBACK_VERSION = 2.0
     CALLBACK_TYPE = 'notification'
     CALLBACK_NAME = 'log_plays'
+    CALLBACK_NEEDS_WHITELIST = True
 
     TIME_FORMAT="%b %d %Y %H:%M:%S"
     MSG_FORMAT="%(now)s - %(category)s - %(data)s\n\n"

lib/ansible/plugins/callback/mail.py

@@ -74,6 +74,7 @@ class CallbackModule(CallbackBase):
     CALLBACK_VERSION = 2.0
     CALLBACK_TYPE = 'notification'
     CALLBACK_NAME = 'mail'
+    CALLBACK_NEEDS_WHITELIST = True
 
     def v2_runner_on_failed(self, res, ignore_errors=False):
 

lib/ansible/plugins/callback/osx_say.py

@@ -38,6 +38,7 @@ class CallbackModule(CallbackBase):
     CALLBACK_VERSION = 2.0
     CALLBACK_TYPE = 'notification'
     CALLBACK_NAME = 'osx_say'
+    CALLBACK_NEEDS_WHITELIST = True
 
     def __init__(self, display):
 

lib/ansible/plugins/callback/profile_tasks.py

@@ -69,6 +69,7 @@ class CallbackModule(CallbackBase):
     CALLBACK_VERSION = 2.0
     CALLBACK_TYPE = 'aggregate'
     CALLBACK_NAME = 'profile_tasks'
+    CALLBACK_NEEDS_WHITELIST = True
 
     def __init__(self, display):
         self.stats = {}

lib/ansible/plugins/callback/syslog_json.py

@@ -26,6 +26,7 @@ class CallbackModule(CallbackBase):
     CALLBACK_VERSION = 2.0
     CALLBACK_TYPE = 'aggregate'
     CALLBACK_NAME = 'syslog_json'
+    CALLBACK_NEEDS_WHITELIST = True
 
     def __init__(self, display):
 

lib/ansible/plugins/callback/timer.py

@@ -14,6 +14,7 @@ class CallbackModule(CallbackBase):
     CALLBACK_VERSION = 2.0
     CALLBACK_TYPE = 'aggregate'
     CALLBACK_NAME = 'timer'
+    CALLBACK_NEEDS_WHITELIST = True
 
     def __init__(self, display):
 

lib/ansible/plugins/callback/tree.py

@@ -34,6 +34,7 @@ class CallbackModule(CallbackBase):
     CALLBACK_VERSION = 2.0
     CALLBACK_TYPE = 'aggregate'
     CALLBACK_NAME = 'tree'
+    CALLBACK_NEEDS_WHITELIST = True
 
     def __init__(self, display):
         super(CallbackModule, self).__init__(display)