fix networking *_command check_mode (#28407)

* Fix check_mode in nxos_command

* Fix check_mode for ios_command

* fix check_mode for iosxr_command

* Fix check_mode in vyos_command

* Fix check_mode in eos_command

* Fix check_mode in junos_config

lib/ansible/modules/network/eos/eos_command.py

@@ -163,12 +163,14 @@ def parse_commands(module, warnings):
     transform = ComplexList(spec, module)
     commands = transform(module.params['commands'])
 
-    for index, item in enumerate(commands):
+    if module.check_mode:
-        if module.check_mode and not item['command'].startswith('show'):
+        for item in list(commands):
-            warnings.append(
+            if not item['command'].startswith('show'):
-                'Only show commands are supported when using check_mode, not '
+                warnings.append(
-                'executing %s' % item['command']
+                    'Only show commands are supported when using check_mode, not '
-            )
+                    'executing %s' % item['command']
+                )
+                commands.remove(item)
 
     return commands
 

lib/ansible/modules/network/ios/ios_command.py

@@ -151,12 +151,13 @@ def parse_commands(module, warnings):
         answer=dict()
     ), module)
     commands = command(module.params['commands'])
-    for index, item in enumerate(commands):
+    for item in list(commands):
         if module.check_mode and not item['command'].startswith('show'):
             warnings.append(
                 'only show commands are supported when using check mode, not '
                 'executing `%s`' % item['command']
             )
+            commands.remove(item)
         elif item['command'].startswith('conf'):
             module.fail_json(
                 msg='ios_command does not support running config mode '

lib/ansible/modules/network/iosxr/iosxr_command.py

@@ -145,12 +145,13 @@ def parse_commands(module, warnings):
     ), module)
     commands = command(module.params['commands'])
 
-    for index, item in enumerate(commands):
+    for item in list(commands):
         if module.check_mode and not item['command'].startswith('show'):
             warnings.append(
                 'only show commands are supported when using check mode, not '
                 'executing `%s`' % item['command']
             )
+            commands.remove(item)
         elif item['command'].startswith('conf'):
             module.fail_json(
                 msg='iosxr_command does not support running config mode '

lib/ansible/modules/network/junos/junos_command.py

@@ -314,6 +314,7 @@ def parse_commands(module, warnings):
                 'Only show commands are supported when using check_mode, not '
                 'executing %s' % command
             )
+            continue
 
         parts = command.split('|')
         text = parts[0]

lib/ansible/modules/network/nxos/nxos_command.py

@@ -181,15 +181,18 @@ def parse_commands(module, warnings):
 
     commands = transform(module.params['commands'])
 
-    for index, item in enumerate(commands):
+    if module.check_mode:
-        if module.check_mode and not item['command'].startswith('show'):
+        for item in list(commands):
-            warnings.append(
+            if not item['command'].startswith('show'):
-                'Only show commands are supported when using check_mode, not '
+                warnings.append(
-                'executing %s' % item['command']
+                    'Only show commands are supported when using check_mode, not '
-            )
+                    'executing %s' % item['command']
+                )
+                commands.remove(item)
 
     return commands
 
+
 def to_cli(obj):
     cmd = obj['command']
     if obj.get('output') == 'json':

lib/ansible/modules/network/vyos/vyos_command.py

@@ -155,14 +155,16 @@ def parse_commands(module, warnings):
         answer=dict(),
     ), module)
     commands = command(module.params['commands'])
+    items = []
 
-    for index, cmd in enumerate(commands):
+    for item in commands:
-        if module.check_mode and not cmd['command'].startswith('show'):
+        if module.check_mode and not item['command'].startswith('show'):
             warnings.append('only show commands are supported when using '
-                            'check mode, not executing `%s`' % cmd['command'])
+                            'check mode, not executing `%s`' % item['command'])
-        commands[index] = module.jsonify(cmd)
+        else:
+            items.append(module.jsonify(item))
 
-    return commands
+    return items
 
 
 def main():