Remove deprecated ALLOW_WORLD_READABLE_TMPFILES config option (#77410)

Fixes #77393
pull/77417/head
Martin Krizek 3 years ago committed by GitHub
parent 60b4200bc6
commit e080bae766
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -0,0 +1,2 @@
removed_features:
- Remove deprecated ``ALLOW_WORLD_READABLE_TMPFILES`` configuration option (https://github.com/ansible/ansible/issues/77393)

@ -1,18 +1,6 @@
# Copyright (c) 2017 Ansible Project # Copyright (c) 2017 Ansible Project
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
--- ---
ALLOW_WORLD_READABLE_TMPFILES:
name: Allow world-readable temporary files
description:
- This setting has been moved to the individual shell plugins as a plugin option :ref:`shell_plugins`.
- The existing configuration settings are still accepted with the shell plugin adding additional options, like variables.
- This message will be removed in 2.14.
type: boolean
default: False
deprecated: # (kept for autodetection and removal, deprecation is irrelevant since w/o settings this can never show runtime msg)
why: moved to shell plugins
version: "2.14"
alternatives: 'world_readable_tmp'
ANSIBLE_CONNECTION_PATH: ANSIBLE_CONNECTION_PATH:
name: Path of ansible-connection script name: Path of ansible-connection script
default: null default: null

@ -722,7 +722,7 @@ class ActionBase(ABC):
# create an extra round trip. # create an extra round trip.
# #
# Also note that due to the above, this can prevent the # Also note that due to the above, this can prevent the
# ALLOW_WORLD_READABLE_TMPFILES logic below from ever getting called. We # world_readable_temp logic below from ever getting called. We
# leave this up to the user to rectify if they have both of these # leave this up to the user to rectify if they have both of these
# features enabled. # features enabled.
group = self.get_shell_option('common_remote_group') group = self.get_shell_option('common_remote_group')

@ -503,7 +503,7 @@ class TestActionBase(unittest.TestCase):
'stderr': '', 'stderr': '',
} }
# TODO: Add test to assert warning is shown if # TODO: Add test to assert warning is shown if
# ALLOW_WORLD_READABLE_TMPFILES is set in this case. # world_readable_temp is set in this case.
assertSuccess() assertSuccess()
action_base._remote_chgrp.assert_called_once_with( action_base._remote_chgrp.assert_called_once_with(
remote_paths, remote_paths,

Loading…
Cancel
Save