optimize reserved names warning

pull/28373/merge
Brian Coca 7 years ago committed by Brian Coca
parent b3a57a4014
commit de16ce42ef

@ -70,9 +70,11 @@ def get_reserved_names(include_private=True):
def warn_if_reserved(myvars): def warn_if_reserved(myvars):
''' this function warns if any variable passed conflicts with internally reserved names ''' ''' this function warns if any variable passed conflicts with internally reserved names '''
reserved = get_reserved_names()
for varname in myvars: varnames = set(myvars)
if varname == 'vars': varnames.discard('vars') # we add this one internally, so safe to ignore
continue # we add this one internally for varname in varnames.intersection(_RESERVED_NAMES):
if varname in reserved: display.warning('Found variable using reserved name: %s' % varname)
display.warning('Found variable using reserved name: %s' % varname)
_RESERVED_NAMES = frozenset(get_reserved_names())

Loading…
Cancel
Save