Merge pull request #732 from willthames/fix_git_fail_json

Fixes for git module when it fails.
reviewable/pr18780/r1
Michael DeHaan 12 years ago
commit dcff6ec4d6

8
git

@ -163,24 +163,24 @@ def main():
if not os.path.exists(gitconfig): if not os.path.exists(gitconfig):
(rc, out, err) = clone(repo, dest) (rc, out, err) = clone(repo, dest)
if rc != 0: if rc != 0:
module.fail_json(out=out, err=err, rc=rc) module.fail_json(msg=err)
else: else:
# else do a pull # else do a pull
before = get_version(dest) before = get_version(dest)
(rc, out, err) = reset(dest) (rc, out, err) = reset(dest)
if rc != 0: if rc != 0:
module.fail_json(out=out, err=err, rc=rc) module.fail_json(msg=err)
(rc, out, err) = pull(module, repo, dest, version) (rc, out, err) = pull(module, repo, dest, version)
# handle errors from clone or pull # handle errors from clone or pull
if out.find('error') != -1 or err.find('ERROR') != -1: if out.find('error') != -1 or err.find('ERROR') != -1:
module.fail_json(out=out, err=err) module.fail_json(msg=err)
# switch to version specified regardless of whether # switch to version specified regardless of whether
# we cloned or pulled # we cloned or pulled
(rc, out, err) = switch_version(module, dest, remote, version) (rc, out, err) = switch_version(module, dest, remote, version)
if err.find('error') != -1: if err.find('error') != -1:
module.fail_json(out=out, err=err) module.fail_json(msg=err)
# determine if we changed anything # determine if we changed anything
after = get_version(dest) after = get_version(dest)

Loading…
Cancel
Save