Actually use changed variable

reviewable/pr18780/r1
Monty Taylor 11 years ago
parent 1a11f07d29
commit d8c51a67f3

@ -114,8 +114,8 @@ def main():
if module.check_mode: if module.check_mode:
module.exit_json(changed=_system_state_change(module, secgroup)) module.exit_json(changed=_system_state_change(module, secgroup))
if state == 'present':
changed = False changed = False
if state == 'present':
if not secgroup: if not secgroup:
secgroup = cloud.create_security_group(name, description) secgroup = cloud.create_security_group(name, description)
changed = True changed = True
@ -125,14 +125,13 @@ def main():
secgroup['id'], description=description) secgroup['id'], description=description)
changed = True changed = True
module.exit_json( module.exit_json(
changed=True, id=secgroup.id, secgroup=secgroup) changed=changed, id=secgroup.id, secgroup=secgroup)
if state == 'absent': if state == 'absent':
if not secgroup: if secgroup:
module.exit_json(changed=False)
else:
cloud.delete_security_group(secgroup['id']) cloud.delete_security_group(secgroup['id'])
module.exit_json(changed=True) changed=True
module.exit_json(changed=changed)
except shade.OpenStackCloudException as e: except shade.OpenStackCloudException as e:
module.fail_json(msg=e.message) module.fail_json(msg=e.message)

Loading…
Cancel
Save