iam_role.py remove_policies should remove all of the requested policies (not just the first) (#56331)

The remove_policies function in iam_role.py enumerates a list of policies to remove. However, due to an indentation issue on the return True line, only the first such policy would be removed.

This change outdents the return True so that all of the the requested policies are removed.
pull/56681/head
Matthew Horoschun 6 years ago committed by Jill R
parent 493cf817a9
commit d8a5efa00c

@ -210,6 +210,7 @@ def convert_friendly_names_to_arns(connection, module, policy_names):
def remove_policies(connection, module, policies_to_remove, params): def remove_policies(connection, module, policies_to_remove, params):
changed = False
for policy in policies_to_remove: for policy in policies_to_remove:
try: try:
if not module.check_mode: if not module.check_mode:
@ -220,7 +221,8 @@ def remove_policies(connection, module, policies_to_remove, params):
except BotoCoreError as e: except BotoCoreError as e:
module.fail_json(msg="Unable to detach policy {0} from {1}: {2}".format(policy, params['RoleName'], to_native(e)), module.fail_json(msg="Unable to detach policy {0} from {1}: {2}".format(policy, params['RoleName'], to_native(e)),
exception=traceback.format_exc()) exception=traceback.format_exc())
return True changed = True
return changed
def create_or_update_role(connection, module): def create_or_update_role(connection, module):

Loading…
Cancel
Save