better error messasge (#42770)

* better error messasge

(cherry picked from commit 9217fbb7dd)
pull/43346/head
Brian Coca 6 years ago committed by Matt Clay
parent 26e3f61dbf
commit c622cc6509

@ -0,0 +1,2 @@
bugfixes:
- Fix an atomic_move error that is 'true', but misleading. Now we show all 3 files involved and clarify what happened.

@ -2605,7 +2605,8 @@ class AnsibleModule(object):
if unsafe_writes and e.errno == errno.EBUSY:
self._unsafe_writes(b_tmp_dest_name, b_dest)
else:
self.fail_json(msg='Unable to rename file: %s to %s: %s' % (src, dest, to_native(e)),
self.fail_json(msg='Unable to make %s into to %s, failed final rename from %s: %s' %
(src, dest, b_tmp_dest_name, to_native(e)),
exception=traceback.format_exc())
except (shutil.Error, OSError, IOError) as e:
self.fail_json(msg='Failed to replace file: %s to %s: %s' % (src, dest, to_native(e)),

Loading…
Cancel
Save