Review requests

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
pull/81947/head
Abhijeet Kasurde 2 weeks ago
parent 40ce495886
commit c2579023fc

@ -271,11 +271,9 @@ MAGIC_VARIABLE_MAPPING = dict(
) )
# INITALIZE CONFIG MANAGER # we always initialize these constants as others depend on them for basic config templating.
config = ConfigManager()
# we always initalize these constants as others depend on them for basic config templating.
for c in __INITIALIZE: for c in __INITIALIZE:
# NOTE: We should create a dep system to avoid hardcoded list, previouslly relied on order in base.yml # NOTE: We should create a dep system to avoid a hardcoded list,
# now relies on order in hardcoded constant in this file. # previously relied on the order in base.yml.
# now relies on order in hardcoded constant in this file.
__getattr__(c) __getattr__(c)

@ -6,7 +6,7 @@ export ANSIBLE_DEPRECATION_WARNINGS=True
### check general config ### check general config
# not using anything deprecated , so no notice # not using anything deprecated, so no notice
[ "$(ANSIBLE_CONFIG='entry_key_not_deprecated.cfg' ansible -m meta -a 'noop' localhost 2>&1 | grep -c 'DEPRECATION')" -eq "0" ] [ "$(ANSIBLE_CONFIG='entry_key_not_deprecated.cfg' ansible -m meta -a 'noop' localhost 2>&1 | grep -c 'DEPRECATION')" -eq "0" ]
# entry source is deprecated, but entry is not consumed, so no notice # entry source is deprecated, but entry is not consumed, so no notice

Loading…
Cancel
Save