fixed problems related to userpricincipalname (user@domain) and undefined variables

fixed variable capitalization
reviewable/pr18780/r1
Hans-Joachim Kliemeck 9 years ago
parent e4d9034fbc
commit c239ee31ac

@ -22,52 +22,49 @@
#Functions #Functions
Function UserSearch Function UserSearch
{ {
Param ([string]$AccountName) Param ([string]$accountName)
#Check if there's a realm specified #Check if there's a realm specified
if ($AccountName.Split("\").count -gt 1)
{ $searchDomain = $false
if ($AccountName.Split("\")[0] -eq $env:COMPUTERNAME) $searchDomainUPN = $false
if ($accountName.Split("\").count -gt 1)
{ {
$IsLocalAccount = $true if ($accountName.Split("\")[0] -ne $env:COMPUTERNAME)
}
Else
{ {
$IsDomainAccount = $true $searchDomain = $true
$IsUpn = $false $accountName = $accountName.split("\")[1]
} }
} }
Elseif ($AccountName.contains("@")) Elseif ($accountName.contains("@"))
{ {
$IsDomainAccount = $true $searchDomain = $true
$IsUpn = $true $searchDomainUPN = $true
} }
Else Else
{ {
#Default to local user account #Default to local user account
$accountname = $env:COMPUTERNAME + "\" + $AccountName $accountName = $env:COMPUTERNAME + "\" + $accountName
$IsLocalAccount = $true
} }
if ($IsLocalAccount -eq $true) if ($searchDomain -eq $false)
{ {
# do not use Win32_UserAccount, because e.g. SYSTEM (BUILTIN\SYSTEM or COMPUUTERNAME\SYSTEM) will not be listed. on Win32_Account groups will be listed too # do not use Win32_UserAccount, because e.g. SYSTEM (BUILTIN\SYSTEM or COMPUUTERNAME\SYSTEM) will not be listed. on Win32_Account groups will be listed too
$localaccount = get-wmiobject -class "Win32_Account" -namespace "root\CIMV2" -filter "(LocalAccount = True)" | where {$_.Caption -eq $AccountName} $localaccount = get-wmiobject -class "Win32_Account" -namespace "root\CIMV2" -filter "(LocalAccount = True)" | where {$_.Caption -eq $accountName}
if ($localaccount) if ($localaccount)
{ {
return $localaccount.SID return $localaccount.SID
} }
} }
ElseIf ($IsDomainAccount -eq $true) Else
{ {
#Search by samaccountname #Search by samaccountname
$Searcher = [adsisearcher]"" $Searcher = [adsisearcher]""
If ($IsUpn -eq $false) { If ($searchDomainUPN -eq $false) {
$Searcher.Filter = "sAMAccountName=$($accountname.split("\")[1])" $Searcher.Filter = "sAMAccountName=$($accountName)"
} }
Else { Else {
$Searcher.Filter = "userPrincipalName=$($accountname)" $Searcher.Filter = "userPrincipalName=$($accountName)"
} }
$result = $Searcher.FindOne() $result = $Searcher.FindOne()

Loading…
Cancel
Save