Reject unknown types from results queue. Fixes #70023 (#71336)

changelogs/fragments/70023-results-type-filtering.yml

@@ -0,0 +1,5 @@
+bugfixes:
+- Strategy - Ensure we only process expected types from the results queue
+  and produce warnings for any object we receive from the queue that doesn't
+  match our expectations.
+  (https://github.com/ansible/ansible/issues/70023)

lib/ansible/plugins/strategy/__init__.py

@@ -100,8 +100,8 @@ def results_thread_main(strategy):
             result = strategy._final_q.get()
             if isinstance(result, StrategySentinel):
                 break
-            else:
+            elif isinstance(result, TaskResult):
-                strategy._results_lock.acquire()
+                with strategy._results_lock:
                     # only handlers have the listen attr, so this must be a handler
                     # we split up the results into two queues here to make sure
                     # handler and regular result processing don't cross wires
@@ -109,7 +109,8 @@ def results_thread_main(strategy):
                         strategy._handler_results.append(result)
                     else:
                         strategy._results.append(result)
-                strategy._results_lock.release()
+            else:
+                display.warning('Received an invalid object (%s) in the result queue: %r' % (type(result), result))
         except (IOError, EOFError):
             break
         except Queue.Empty: