ec2_group: do not fail on description mismatch (#31704) (#31734)

* ec2_group: do not fail on description mismatch (#31704)

* ec2_group: do not fail on description mismatch (#31704) - fix test case
pull/31942/head
Marek Nogacki 7 years ago committed by Sloane Hertel
parent 1b63885fc5
commit b9223cdc89

@ -682,8 +682,8 @@ def main():
if group: if group:
# existing group # existing group
if group['Description'] != description: if group['Description'] != description:
module.fail_json( module.warn("Group description does not match existing group. Descriptions cannot be changed without deleting "
msg="Group description does not match existing group. ec2_group does not support this case.") "and re-creating the security group. Try using state=absent to delete, then rerunning this task.")
# if the group doesn't exist, create it now # if the group doesn't exist, create it now
else: else:

@ -192,7 +192,7 @@
- 'result.group_id.startswith("sg-")' - 'result.group_id.startswith("sg-")'
# ============================================================ # ============================================================
- name: test state=present different description raises error - name: test state=present different description (expected changed=false)
ec2_group: ec2_group:
name: '{{ec2_group_name}}' name: '{{ec2_group_name}}'
description: '{{ec2_group_description}}CHANGED' description: '{{ec2_group_description}}CHANGED'
@ -204,11 +204,11 @@
ignore_errors: true ignore_errors: true
register: result register: result
- name: assert matching group with non-matching description raises error - name: assert state=present (expected changed=false)
assert: assert:
that: that:
- 'result.failed' - 'not result.changed'
- '"Group description does not match existing group. ec2_group does not support this case." in result.msg' - 'result.group_id.startswith("sg-")'
# ============================================================ # ============================================================
- name: test state=present (expected changed=false) - name: test state=present (expected changed=false)

Loading…
Cancel
Save