ecs_taskdefinition_facts: rename to ecs_taskdefinition_info (#60023)

* Rename ecs_taskdefinition_facts to ecs_taskdefinition_info.

.github/BOTMETA.yml

@@ -85,7 +85,7 @@ files:
   $modules/cloud/amazon/ecs_service_facts.py: willthames
   $modules/cloud/amazon/ecs_task.py: willthames
   $modules/cloud/amazon/ecs_taskdefinition.py: willthames
-  $modules/cloud/amazon/ecs_taskdefinition_facts.py: willthames
+  $modules/cloud/amazon/ecs_taskdefinition_info.py: willthames
   $modules/cloud/amazon/elasticache.py: alachaum
   $modules/cloud/amazon/elb_target_group_info.py: willthames
   $modules/cloud/amazon/iam.py: $team_ansible

changelogs/fragments/60023-aws-facts-info.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+- The ``ecs_taskdefinition_facts`` module has been renamed to ``ecs_taskdefinition_info``.

docs/docsite/rst/porting_guides/porting_guide_2.9.rst

@@ -138,6 +138,7 @@ Noteworthy module changes
 * The ``ec2_vpc_subnet_facts`` module was renamed to :ref:`ec2_vpc_subnet_info <ec2_vpc_subnet_info_module>`.
 * The ``ec2_vpc_vgw_facts`` module was renamed to :ref:`ec2_vpc_vgw_info <ec2_vpc_vgw_info_module>`.
 * The ``ec2_vpc_vpn_facts`` module was renamed to :ref:`ec2_vpc_vpn_info <ec2_vpc_vpn_info_module>`.
+* The ``ecs_taskdefinition_facts`` module was renamed to :ref:`ecs_taskdefinition_info <ecs_taskdefinition_info_module>`.
 * The ``elasticache_facts`` module was renamed to :ref:`elasticache_info <elasticache_info_module>`.
 * The ``elb_application_lb_facts`` module was renamed to :ref:`elb_application_lb_info <elb_application_lb_info_module>`.
 * The ``elb_classic_lb_facts`` module was renamed to :ref:`elb_classic_lb_info <elb_classic_lb_info_module>`.

lib/ansible/config/module_defaults.yml

@@ -260,8 +260,6 @@ groupings:
   - aws
   ecs_taskdefinition:
   - aws
-  ecs_taskdefinition_facts:
-  - aws
   ecs_taskdefinition_info:
   - aws
   efs:

lib/ansible/modules/cloud/amazon/_ecs_taskdefinition_facts.py

@@ -0,0 +1 @@
+ecs_taskdefinition_info.py

lib/ansible/modules/cloud/amazon/ecs_taskdefinition_info.py

@@ -12,11 +12,12 @@ ANSIBLE_METADATA = {'metadata_version': '1.1',
 
 DOCUMENTATION = '''
 ---
-module: ecs_taskdefinition_facts
+module: ecs_taskdefinition_info
 short_description: describe a task definition in ecs
 notes:
     - for details of the parameters and returns see
       U(http://boto3.readthedocs.io/en/latest/reference/services/ecs.html#ECS.Client.describe_task_definition)
+    - This module was called C(ecs_taskdefinition_facts) before Ansible 2.9. The usage did not change.
 description:
     - Describes a task definition in ecs.
 version_added: "2.5"
@@ -38,7 +39,7 @@ extends_documentation_fragment:
 EXAMPLES = '''
 # Note: These examples do not set authentication details, see the AWS Guide for details.
 
-- ecs_taskdefinition_facts:
+- ecs_taskdefinition_info:
     task_definition: test-td
 '''
 
@@ -316,6 +317,8 @@ def main():
     ))
 
     module = AnsibleAWSModule(argument_spec=argument_spec, supports_check_mode=True)
+    if module._name == 'ecs_taskdefinition_facts':
+        module.deprecate("The 'ecs_taskdefinition_facts' module has been renamed to 'ecs_taskdefinition_info'", version='2.13')
 
     region, ec2_url, aws_connect_kwargs = get_aws_connection_info(module, boto3=True)
     ecs = boto3_conn(module, conn_type='client', resource='ecs',

test/integration/targets/ecs_cluster/aliases

@@ -2,5 +2,5 @@ cloud/aws
 ecs_service_facts
 ecs_task
 ecs_taskdefinition
-ecs_taskdefinition_facts
+ecs_taskdefinition_info
 unsupported

test/integration/targets/ecs_cluster/tasks/full_test.yml

@@ -219,7 +219,7 @@
       ignore_errors: yes
 
     - name: obtain ECS task definition facts
-      ecs_taskdefinition_facts:
+      ecs_taskdefinition_info:
         task_definition: "{{ ecs_task_name }}:{{ ecs_task_definition.taskdefinition.revision }}"
         <<: *aws_connection_info
 
@@ -392,15 +392,15 @@
       register: ecs_task_definition_vpc_with_host_port
 
     - name: obtain ECS task definition facts
-      ecs_taskdefinition_facts:
+      ecs_taskdefinition_info:
         task_definition: "{{ ecs_task_name }}-vpc:{{ ecs_task_definition_vpc_with_host_port.taskdefinition.revision }}"
         <<: *aws_connection_info
-      register: ecs_taskdefinition_facts
+      register: ecs_taskdefinition_info
 
     - name: assert that network mode is awsvpc
       assert:
         that:
-          - "ecs_taskdefinition_facts.network_mode == 'awsvpc'"
+          - "ecs_taskdefinition_info.network_mode == 'awsvpc'"
 
     - name: pause to allow service to scale down
       pause:
@@ -626,7 +626,7 @@
           - "'networkConfiguration' in ecs_service_facts.ansible_facts.services[0]"
 
     - name: attempt to get facts from missing task definition
-      ecs_taskdefinition_facts:
+      ecs_taskdefinition_info:
         task_definition: "{{ ecs_task_name }}-vpc:{{ ecs_task_definition.taskdefinition.revision + 1}}"
         <<: *aws_connection_info
 
@@ -699,7 +699,7 @@
       register: ecs_fargate_task_definition
 
     - name: obtain ECS task definition facts
-      ecs_taskdefinition_facts:
+      ecs_taskdefinition_info:
         task_definition: "{{ ecs_task_name }}-vpc:{{ ecs_fargate_task_definition.taskdefinition.revision }}"
         <<: *aws_connection_info
 

test/sanity/ignore.txt

@@ -900,7 +900,7 @@ lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py future-import-boilerplate
 lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py metaclass-boilerplate
 lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py validate-modules:E337
 lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py validate-modules:E338
-lib/ansible/modules/cloud/amazon/ecs_taskdefinition_facts.py validate-modules:E337
+lib/ansible/modules/cloud/amazon/ecs_taskdefinition_info.py validate-modules:E337
 lib/ansible/modules/cloud/amazon/efs.py pylint:blacklisted-name
 lib/ansible/modules/cloud/amazon/efs.py validate-modules:E337
 lib/ansible/modules/cloud/amazon/efs_facts.py pylint:blacklisted-name