Removing validate-module exceptions on GCP modules (#60113)

* facts modules with new types
* remove ignores on sanity tests
* removing new modules

lib/ansible/modules/cloud/google/gcp_compute_address_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   region:
     description:
     - URL of the region where the regional address resides.

lib/ansible/modules/cloud/google/gcp_compute_backend_bucket_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_backend_service_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_disk_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   zone:
     description:
     - A reference to the zone where the disk resides.

lib/ansible/modules/cloud/google/gcp_compute_firewall_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_forwarding_rule_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   region:
     description:
     - A reference to the region where the regional forwarding rule resides.

lib/ansible/modules/cloud/google/gcp_compute_global_address_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_global_forwarding_rule_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_health_check_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_http_health_check_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_https_health_check_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_image_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_instance_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   zone:
     description:
     - A reference to the zone where the machine resides.
@@ -363,10 +364,9 @@ resources:
           type: str
         network:
           description:
-          - Specifies the title of an existing network. When creating an instance,
-            if neither the network nor the subnetwork is specified, the default network
-            global/networks/default is used; if the network is not specified but the
-            subnetwork is specified, the network is inferred.
+          - Specifies the title of an existing network. Not setting the network title
+            will select the default network interface, which could have SSH already
+            configured .
           returned: success
           type: dict
         networkIP:

lib/ansible/modules/cloud/google/gcp_compute_instance_group_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   zone:
     description:
     - A reference to the zone where the instance group resides.

lib/ansible/modules/cloud/google/gcp_compute_instance_group_manager_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   zone:
     description:
     - The zone the managed instance group resides.

lib/ansible/modules/cloud/google/gcp_compute_instance_template_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_interconnect_attachment_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   region:
     description:
     - Region where the regional interconnect attachment resides.

lib/ansible/modules/cloud/google/gcp_compute_network_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_region_disk_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   region:
     description:
     - A reference to the region where the disk resides.

lib/ansible/modules/cloud/google/gcp_compute_route_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_router_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   region:
     description:
     - Region where the router resides.

lib/ansible/modules/cloud/google/gcp_compute_ssl_certificate_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_ssl_policy_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_subnetwork_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   region:
     description:
     - URL of the GCP region for this subnetwork.

lib/ansible/modules/cloud/google/gcp_compute_target_http_proxy_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_target_https_proxy_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_target_pool_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   region:
     description:
     - The region where the target pool resides.

lib/ansible/modules/cloud/google/gcp_compute_target_ssl_proxy_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_target_tcp_proxy_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_target_vpn_gateway_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   region:
     description:
     - The region this gateway should sit in.

lib/ansible/modules/cloud/google/gcp_compute_url_map_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
 extends_documentation_fragment: gcp
 '''
 

lib/ansible/modules/cloud/google/gcp_compute_vpn_tunnel_facts.py

@@ -45,6 +45,7 @@ options:
     - A list of filter value pairs. Available filters are listed here U(https://cloud.google.com/sdk/gcloud/reference/topic/filters).
     - Each additional filter in the list will act be added as an AND condition (filter1
       and filter2) .
+    type: list
   region:
     description:
     - The region where the tunnel is located.

lib/ansible/modules/cloud/google/gcp_dns_managed_zone_facts.py

@@ -43,6 +43,7 @@ options:
   dns_name:
     description:
     - Restricts the list to return only zones with this domain name.
+    type: list
 extends_documentation_fragment: gcp
 '''
 

test/sanity/ignore.txt

@@ -1521,39 +1521,6 @@ lib/ansible/modules/cloud/google/gce_snapshot.py validate-modules:E338
 lib/ansible/modules/cloud/google/gce_tag.py pylint:blacklisted-name
 lib/ansible/modules/cloud/google/gce_tag.py validate-modules:E337
 lib/ansible/modules/cloud/google/gcp_bigquery_table.py validate-modules:E324
-lib/ansible/modules/cloud/google/gcp_compute_address_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_backend_bucket_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_backend_service_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_disk_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_firewall_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_forwarding_rule_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_global_address_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_global_forwarding_rule_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_health_check_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_http_health_check_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_https_health_check_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_image_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_instance_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_instance_group_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_instance_group_manager_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_instance_template_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_interconnect_attachment_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_network_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_region_disk_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_route_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_router_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_ssl_certificate_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_ssl_policy_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_subnetwork_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_target_http_proxy_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_target_https_proxy_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_target_pool_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_target_ssl_proxy_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_target_tcp_proxy_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_target_vpn_gateway_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_url_map_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_compute_vpn_tunnel_facts.py validate-modules:E337
-lib/ansible/modules/cloud/google/gcp_dns_managed_zone_facts.py validate-modules:E337
 lib/ansible/modules/cloud/google/gcpubsub.py validate-modules:E322
 lib/ansible/modules/cloud/google/gcpubsub.py validate-modules:E323
 lib/ansible/modules/cloud/google/gcpubsub.py validate-modules:E337