Strip string terms before templating

The earlier code did call terms.strip(), but ignored the return value
instead of passing that in to templar.template(). Clearly an oversight.
pull/13750/head
Abhijit Menon-Sen 9 years ago committed by Brian Coca
parent 7a4914aa9b
commit ab536c8aa8

@ -31,9 +31,8 @@ __all__ = ['listify_lookup_plugin_terms']
def listify_lookup_plugin_terms(terms, templar, loader, fail_on_undefined=False, convert_bare=True): def listify_lookup_plugin_terms(terms, templar, loader, fail_on_undefined=False, convert_bare=True):
if isinstance(terms, string_types): if isinstance(terms, string_types):
stripped = terms.strip()
# TODO: warn/deprecation on bare vars in with_ so we can eventually remove fail on undefined override # TODO: warn/deprecation on bare vars in with_ so we can eventually remove fail on undefined override
terms = templar.template(terms, convert_bare=convert_bare, fail_on_undefined=fail_on_undefined) terms = templar.template(terms.strip(), convert_bare=convert_bare, fail_on_undefined=fail_on_undefined)
else: else:
terms = templar.template(terms, fail_on_undefined=fail_on_undefined) terms = templar.template(terms, fail_on_undefined=fail_on_undefined)

Loading…
Cancel
Save