Fixes #5196 return a unique list of hostnames for a single host pattern

pull/5251/merge
James Tanner 11 years ago
parent ccbc99fe4f
commit ab51bd23a2

@ -21,6 +21,7 @@ import fnmatch
import os import os
import re import re
import subprocess import subprocess
from sets import Set
import ansible.constants as C import ansible.constants as C
from ansible.inventory.ini import InventoryParser from ansible.inventory.ini import InventoryParser
@ -251,6 +252,8 @@ class Inventory(object):
""" Get all host names matching the pattern """ """ Get all host names matching the pattern """
hosts = [] hosts = []
hostnames = Set()
# ignore any negative checks here, this is handled elsewhere # ignore any negative checks here, this is handled elsewhere
pattern = pattern.replace("!","").replace("&", "") pattern = pattern.replace("!","").replace("&", "")
@ -259,8 +262,9 @@ class Inventory(object):
for group in groups: for group in groups:
for host in group.get_hosts(): for host in group.get_hosts():
if pattern == 'all' or self._match(group.name, pattern) or self._match(host.name, pattern): if pattern == 'all' or self._match(group.name, pattern) or self._match(host.name, pattern):
if host not in results: if host not in results and host.name not in hostnames:
results.append(host) results.append(host)
hostnames.add(host.name)
return results return results
def clear_pattern_cache(self): def clear_pattern_cache(self):

Loading…
Cancel
Save