Port command module over to new common code. Notice that this has to subclass AnsibleModule -- this should be the only

one that has to do that.

command

@@ -16,12 +16,6 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-#
-
-try:
-    import json
-except ImportError:
-    import simplejson as json
 
 import subprocess
 import sys
@@ -29,61 +23,27 @@ import datetime
 import traceback
 import shlex
 import os
-import syslog
 
-argfile = sys.argv[1]
+def main():
-args = open(argfile, 'r').read()
-syslog.openlog('ansible-%s' % os.path.basename(__file__))
-syslog.syslog(syslog.LOG_NOTICE, 'Invoked with %s' % args)
 
-shell = False
+    # the command module is the one ansible module that does not take key=value args
-
+    # hence don't copy this one if you are looking to build others!
-if args.find("#USE_SHELL") != -1:
+    module = CommandModule(argument_spec=dict())
-   args = args.replace("#USE_SHELL", "")
-   shell = True
-
-check_args = shlex.split(args)
-for x in check_args:
-   if x.startswith("creates="):
-       # do not run the command if the line contains creates=filename
-       # and the filename already exists.  This allows idempotence 
-       # of command executions.
-       (k,v) = x.split("=",1)
-       if os.path.exists(v):
-           print json.dumps({
-               "cmd"     : args,
-               "stdout"  : "skipped, since %s exists" % v,
-               "skipped" : True,
-               "changed" : False,
-               "stderr"  : "",
-               "rc"      : 0,
-           })
-           sys.exit(0)
-       args = args.replace(x,'')
 
+    shell = module.params['shell']
+    args  = module.params['args']
 
     if not shell:
         args = shlex.split(args)
-
     startd = datetime.datetime.now()
 
     try:
-    cmd = subprocess.Popen(args, shell=shell, 
+        cmd = subprocess.Popen(args, shell=shell, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-        stdout=subprocess.PIPE, stderr=subprocess.PIPE)
         out, err = cmd.communicate()
     except (OSError, IOError), e:
-    print json.dumps({
+        module.fail_json(cmd=args, msg=str(e))
-        "cmd"    : args,
-        "failed" : 1,
-        "msg"    : str(e),
-        })
-    sys.exit(1)
     except:
-    print json.dumps({
+        module.fail_json(msg=traceback.format_exc())
-        "failed" : 1,
-        "msg" : traceback.format_exc()
-    })   
-    sys.exit(1)
 
     endd = datetime.datetime.now()
     delta = endd - startd
@@ -93,15 +53,53 @@ if out is None:
     if err is None:
        err = ''
 
-result = {
+    module.exit_json(
-   "cmd"     : args,
+        cmd     = args,
-   "stdout"  : out.strip(),
+        stdout  = out.strip(),
-   "stderr"  : err.strip(),
+        stderr  = err.strip(),
-   "rc"      : cmd.returncode,
+        rc      = cmd.returncode,
-   "start"   : str(startd),
+        start   = str(startd),
-   "end"     : str(endd),
+        end     = str(endd),
-   "delta"   : str(delta),
+        delta   = str(delta),
-   "changed" : True
+        changed = True
-}
+    )
-
+
-print json.dumps(result)
+# include magic from lib/ansible/module_common.py
+#<<INCLUDE_ANSIBLE_MODULE_COMMON>>
+
+# only the command module should ever need to do this
+# everything else should be simple key=value
+
+class CommandModule(AnsibleModule):
+
+    def _load_params(self):
+        ''' read the input and return a dictionary and the arguments string '''
+        args = base64.b64decode(MODULE_ARGS)
+        items   = shlex.split(args)
+        params = {}
+        params['shell'] = False
+        if args.find("#USE_SHELL") != -1:
+             args = args.replace("#USE_SHELL", "")
+             params['shell'] = True
+
+        check_args = shlex.split(args)
+        for x in check_args:
+            if x.startswith("creates="):
+                # do not run the command if the line contains creates=filename
+                # and the filename already exists.  This allows idempotence
+                # of command executions.
+                (k,v) = x.split("=",1)
+                if os.path.exists(v):
+                    self.exit_json(
+                        cmd=args,
+                        stdout="skipped, since %s exists" % v,
+                        skipped=True,
+                        changed=False,
+                        stderr=False,
+                        rc=0
+                    )
+                args = args.replace(x,'')
+        params['args'] = args
+        return (params, args)
+
+main()