[bp-2.15] Fixes permission for cache json file to 644 (#83016)

Until ansible-core 2.12 the facts cache file created by this module, have permission set as 644 which allows the other users to read the cache, since ansible-core 2.13, we create the temporary file, but we do not set the permission after renaming the temporary file.  Adding the line to set the permission to allow other users/groups to read this file.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Rudnei Bertol Junior <rudnei@redhat.com>
pull/83044/head
Abhijeet Kasurde 8 months ago committed by GitHub
parent 8e07b46bde
commit a90fd26ddf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -0,0 +1,2 @@
bugfixes:
- Fixes permission for cache json file from 600 to 644 (https://github.com/ansible/ansible/issues/82683).

@ -165,6 +165,7 @@ class BaseFileCacheModule(BaseCacheModule):
display.warning("error in '%s' cache plugin while trying to write to '%s' : %s" % (self.plugin_name, tmpfile_path, to_bytes(e))) display.warning("error in '%s' cache plugin while trying to write to '%s' : %s" % (self.plugin_name, tmpfile_path, to_bytes(e)))
try: try:
os.rename(tmpfile_path, cachefile) os.rename(tmpfile_path, cachefile)
os.chmod(cachefile, mode=0o644)
except (OSError, IOError) as e: except (OSError, IOError) as e:
display.warning("error in '%s' cache plugin while trying to move '%s' to '%s' : %s" % (self.plugin_name, tmpfile_path, cachefile, to_bytes(e))) display.warning("error in '%s' cache plugin while trying to move '%s' to '%s' : %s" % (self.plugin_name, tmpfile_path, cachefile, to_bytes(e)))
finally: finally:

Loading…
Cancel
Save