archive
/
ansible
mirror of https://github.com/ansible/ansible.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Refactor structure of group module integration tests (#78652)

Browse Source 
This to match the structure with the tests for the user module. When having the tests available as stand-alone tests, it will be easier to add more integration tests in the future.
pull/78172/head
Roy Lenferink 3 years ago committed by GitHub
parent 196084773b
commit a3531ac422
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 374 additions and 343 deletions
Show Stats Download Patch File Download Diff File

23
test/integration/targets/group/files/get_free_gid.py
Unescape Escape View File

@ -0,0 +1,23 @@
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import grp
def main():
gids = [g.gr_gid for g in grp.getgrall()]
# Start the gid numbering with 1
# FreeBSD doesn't support the usage of gid 0, it doesn't fail (rc=0) but instead a number in the normal
# range is picked.
i = 1
while True:
if i not in gids:
print(i)
break
i += 1
if __name__ == '__main__':
main()

18
test/integration/targets/group/files/get_gid_for_group.py
Unescape Escape View File

@ -0,0 +1,18 @@
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import grp
import sys
def main():
group_name = None
if len(sys.argv) >= 2:
group_name = sys.argv[1]
print(grp.getgrnam(group_name).gr_gid)
if __name__ == '__main__':
main()

15
test/integration/targets/group/files/gidget.py
Unescape Escape View File

@ -1,15 +0,0 @@
#!/usr/bin/env python
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import grp
gids = [g.gr_gid for g in grp.getgrall()]
i = 0
while True:
if i not in gids:
print(i)
break
i += 1

23
test/integration/targets/group/tasks/main.yml
Unescape Escape View File

@ -16,25 +16,4 @@
# You should have received a copy of the GNU General Public License
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
- name: ensure test groups are deleted before the test
group:
name: '{{ item }}'
state: absent
loop:
- ansibullgroup
- ansibullgroup2
- ansibullgroup3
- block:
- name: run tests
include_tasks: tests.yml
always:
- name: remove test groups after test
group:
name: '{{ item }}'
state: absent
loop:
- ansibullgroup
- ansibullgroup2
- ansibullgroup3
- import_tasks: tests.yml

164
test/integration/targets/group/tasks/tests.yml
Unescape Escape View File

@ -1,135 +1,147 @@
---
##
## group add
##
- name: ensure test groups are deleted before the test
group:
name: '{{ item }}'
state: absent
loop:
- ansibullgroup
- ansibullgroup2
- ansibullgroup3
- name: create group (check mode)
- block:
##
## group add
##
- name: create group (check mode)
group:
name: ansibullgroup
state: present
register: create_group_check
check_mode: True
check_mode: true
- name: get result of create group (check mode)
- name: get result of create group (check mode)
script: 'grouplist.sh "{{ ansible_distribution }}"'
register: create_group_actual_check
- name: assert create group (check mode)
- name: assert create group (check mode)
assert:
that:
- create_group_check is changed
- '"ansibullgroup" not in create_group_actual_check.stdout_lines'
- name: create group
- name: create group
group:
name: ansibullgroup
state: present
register: create_group
- name: get result of create group
- name: get result of create group
script: 'grouplist.sh "{{ ansible_distribution }}"'
register: create_group_actual
- name: assert create group
- name: assert create group
assert:
that:
- create_group is changed
- create_group.gid is defined
- '"ansibullgroup" in create_group_actual.stdout_lines'
- name: create group (idempotent)
- name: create group (idempotent)
group:
name: ansibullgroup
state: present
register: create_group_again
- name: assert create group (idempotent)
- name: assert create group (idempotent)
assert:
that:
- not create_group_again is changed
##
## group check
##
##
## group check
##
- name: run existing group check tests
- name: run existing group check tests
group:
name: "{{ create_group_actual.stdout_lines|random }}"
state: present
with_sequence: start=1 end=5
register: group_test1
- name: validate results for testcase 1
- name: validate results for testcase 1
assert:
that:
- group_test1.results is defined
- group_test1.results|length == 5
- name: validate change results for testcase 1
- name: validate change results for testcase 1
assert:
that:
- not group_test1 is changed
##
## group add with gid
##
##
## group add with gid
##
- name: get the next available gid
script: gidget.py
- name: get the next available gid
script: get_free_gid.py
args:
executable: '{{ ansible_python_interpreter }}'
register: gid
- name: create a group with a gid (check mode)
- name: create a group with a gid (check mode)
group:
name: ansibullgroup2
gid: '{{ gid.stdout_lines[0] }}'
state: present
register: create_group_gid_check
check_mode: True
check_mode: true
- name: get result of create a group with a gid (check mode)
- name: get result of create a group with a gid (check mode)
script: 'grouplist.sh "{{ ansible_distribution }}"'
register: create_group_gid_actual_check
- name: assert create group with a gid (check mode)
- name: assert create group with a gid (check mode)
assert:
that:
- create_group_gid_check is changed
- '"ansibullgroup2" not in create_group_gid_actual_check.stdout_lines'
- name: create a group with a gid
- name: create a group with a gid
group:
name: ansibullgroup2
gid: '{{ gid.stdout_lines[0] }}'
state: present
register: create_group_gid
- name: get gid of created group
command: "{{ ansible_python_interpreter | quote }} -c \"import grp; print(grp.getgrnam('ansibullgroup2').gr_gid)\""
- name: get gid of created group
script: "get_gid_for_group.py ansibullgroup2"
args:
executable: '{{ ansible_python_interpreter }}'
register: create_group_gid_actual
- name: assert create group with a gid
- name: assert create group with a gid
assert:
that:
- create_group_gid is changed
- create_group_gid.gid | int == gid.stdout_lines[0] | int
- create_group_gid_actual.stdout | trim | int == gid.stdout_lines[0] | int
- name: create a group with a gid (idempotent)
- name: create a group with a gid (idempotent)
group:
name: ansibullgroup2
gid: '{{ gid.stdout_lines[0] }}'
state: present
register: create_group_gid_again
- name: assert create group with a gid (idempotent)
- name: assert create group with a gid (idempotent)
assert:
that:
- not create_group_gid_again is changed
- create_group_gid_again.gid | int == gid.stdout_lines[0] | int
- block:
- block:
- name: create a group with a non-unique gid
group:
name: ansibullgroup3
@ -153,55 +165,55 @@
- missing_gid is failed
when: ansible_facts.distribution not in ['MacOSX', 'Alpine']
##
## group remove
##
##
## group remove
##
- name: delete group (check mode)
- name: delete group (check mode)
group:
name: ansibullgroup
state: absent
register: delete_group_check
check_mode: True
check_mode: true
- name: get result of delete group (check mode)
script: grouplist.sh "{{ ansible_distribution }}"
- name: get result of delete group (check mode)
script: 'grouplist.sh "{{ ansible_distribution }}"'
register: delete_group_actual_check
- name: assert delete group (check mode)
- name: assert delete group (check mode)
assert:
that:
- delete_group_check is changed
- '"ansibullgroup" in delete_group_actual_check.stdout_lines'
- name: delete group
- name: delete group
group:
name: ansibullgroup
state: absent
register: delete_group
- name: get result of delete group
script: grouplist.sh "{{ ansible_distribution }}"
- name: get result of delete group
script: 'grouplist.sh "{{ ansible_distribution }}"'
register: delete_group_actual
- name: assert delete group
- name: assert delete group
assert:
that:
- delete_group is changed
- '"ansibullgroup" not in delete_group_actual.stdout_lines'
- name: delete group (idempotent)
- name: delete group (idempotent)
group:
name: ansibullgroup
state: absent
register: delete_group_again
- name: assert delete group (idempotent)
- name: assert delete group (idempotent)
assert:
that:
- not delete_group_again is changed
- name: Ensure lgroupadd is present
- name: Ensure lgroupadd is present
action: "{{ ansible_facts.pkg_mgr }}"
args:
name: libuser
@ -210,23 +222,23 @@
tags:
- user_test_local_mode
- name: Ensure lgroupadd is present - Alpine
- name: Ensure lgroupadd is present - Alpine
command: apk add -U libuser
when: ansible_distribution == 'Alpine'
tags:
- user_test_local_mode
# https://github.com/ansible/ansible/issues/56481
- block:
# https://github.com/ansible/ansible/issues/56481
- block:
- name: Test duplicate GID with local=yes
group:
name: "{{ item }}"
gid: 1337
local: yes
local: true
loop:
- group1_local_test
- group2_local_test
ignore_errors: yes
ignore_errors: true
register: local_duplicate_gid_result
- assert:
@ -241,18 +253,20 @@
# only applicable to Linux, limit further to CentOS where 'luseradd' is installed
when: ansible_distribution == 'CentOS'
# https://github.com/ansible/ansible/pull/59769
- block:
# https://github.com/ansible/ansible/pull/59769
- block:
- name: create a local group with a gid
group:
name: group1_local_test
gid: 1337
local: yes
local: true
state: present
register: create_local_group_gid
- name: get gid of created local group
command: "{{ ansible_python_interpreter | quote }} -c \"import grp; print(grp.getgrnam('group1_local_test').gr_gid)\""
script: "get_gid_for_group.py group1_local_test"
args:
executable: '{{ ansible_python_interpreter }}'
register: create_local_group_gid_actual
- name: assert create local group with a gid
@ -282,18 +296,20 @@
# only applicable to Linux, limit further to CentOS where 'luseradd' is installed
when: ansible_distribution == 'CentOS'
# https://github.com/ansible/ansible/pull/59772
- block:
# https://github.com/ansible/ansible/pull/59772
- block:
- name: create group with a gid
group:
name: group1_test
gid: 1337
local: no
local: false
state: present
register: create_group_gid
- name: get gid of created group
command: "{{ ansible_python_interpreter | quote }} -c \"import grp; print(grp.getgrnam('group1_test').gr_gid)\""
script: "get_gid_for_group.py group1_test"
args:
executable: '{{ ansible_python_interpreter }}'
register: create_group_gid_actual
- name: assert create group with a gid
@ -307,7 +323,7 @@
group:
name: group1_test
gid: 1337
local: yes
local: true
state: present
register: create_local_group_gid
@ -319,25 +335,35 @@
- name: Cleanup create group with a gid
group:
name: group1_test
local: no
local: false
state: absent
- name: Cleanup create local group with the same gid
group:
name: group1_test
local: yes
local: true
state: absent
# only applicable to Linux, limit further to CentOS where 'lgroupadd' is installed
when: ansible_distribution == 'CentOS'
# create system group
# create system group
- name: remove group
- name: remove group
group:
name: ansibullgroup
state: absent
- name: create system group
- name: create system group
group:
name: ansibullgroup
state: present
system: yes
system: true
always:
- name: remove test groups after test
group:
name: '{{ item }}'
state: absent
loop:
- ansibullgroup
- ansibullgroup2
- ansibullgroup3

Write Preview
Loading…
Cancel
Save