Use int in the parameter list instead of casting

reviewable/pr18780/r1
Monty Taylor 10 years ago
parent 2e8daa2330
commit 9f03302b68

@ -94,8 +94,8 @@ def _find_matching_rule(module, secgroup):
:returns: The matching rule dict, or None if no matches. :returns: The matching rule dict, or None if no matches.
""" """
protocol = module.params['protocol'] protocol = module.params['protocol']
port_range_min = int(module.params['port_range_min']) port_range_min = module.params['port_range_min']
port_range_max = int(module.params['port_range_max']) port_range_max = module.params['port_range_max']
remote_ip_prefix = module.params['remote_ip_prefix'] remote_ip_prefix = module.params['remote_ip_prefix']
ethertype = module.params['ethertype'] ethertype = module.params['ethertype']
direction = module.params['direction'] direction = module.params['direction']
@ -142,8 +142,8 @@ def main():
security_group = dict(required=True), security_group = dict(required=True),
protocol = dict(default='tcp', protocol = dict(default='tcp',
choices=['tcp', 'udp', 'icmp']), choices=['tcp', 'udp', 'icmp']),
port_range_min = dict(required=True), port_range_min = dict(required=True, type='int'),
port_range_max = dict(required=True), port_range_max = dict(required=True, type='int'),
remote_ip_prefix = dict(required=False, default=None), remote_ip_prefix = dict(required=False, default=None),
# TODO(mordred): Make remote_group handle name and id # TODO(mordred): Make remote_group handle name and id
remote_group = dict(required=False, default=None), remote_group = dict(required=False, default=None),
@ -211,4 +211,4 @@ def main():
from ansible.module_utils.basic import * from ansible.module_utils.basic import *
from ansible.module_utils.openstack import * from ansible.module_utils.openstack import *
main() main()

Loading…
Cancel
Save