Simplify logic by using required=True.

lib/ansible/modules/extras/packaging/openbsd_pkg.py

@@ -355,8 +355,8 @@ def upgrade_packages(module):
 def main():
     module = AnsibleModule(
         argument_spec = dict(
-            name = dict(),
-            state = dict(choices=['absent', 'installed', 'latest', 'present', 'removed']),
+            name = dict(required=True),
+            state = dict(required=True, choices=['absent', 'installed', 'latest', 'present', 'removed']),
         ),
         supports_check_mode = True
     )
@@ -371,10 +371,6 @@ def main():
     result['name'] = name
     result['state'] = state
 
-    if name:
-        if not state:
-            module.fail_json(msg="missing required arguments: state")
-
     if name == '*':
         if state != 'latest':
             module.fail_json(msg="the package name '*' is only valid when using state=latest")
@@ -396,8 +392,6 @@ def main():
             (rc, stdout, stderr, changed) = package_absent(name, installed_state, module)
         elif state == 'latest':
             (rc, stdout, stderr, changed) = package_latest(name, installed_state, pkg_spec, module)
-    else:
-        module.fail_json(msg="Something is broken, you should never end up here")
 
     if rc != 0:
         if stderr: