Add a Singleton metaclass, use it with Display (#48935)

* Add a Singleton class, use it with Display

* update six import

* Move remaining failes to display singleton

* Fix rebase issues

* Singleton improvements

* Add code-smell for 'from __main__ import display'. ci_complete

* s/self/cls/g

* Add docs for no-main-display

* Address linting issues

* Add changelog fragment. ci_complete

* Implement reentrant lock for class instantiation in Singleton

* Add Display singleton porting guide

changelogs/fragments/display-singleton.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+- Display - Add a ``Singleton`` metaclass and apply it to ``Display`` to remove the need of using ``__main__.Display`` as a pseudo singleton

docs/docsite/rst/dev_guide/developing_plugins.rst

@@ -236,11 +236,8 @@ Here's a simple lookup plugin implementation --- this lookup returns the content
   """
   from ansible.errors import AnsibleError, AnsibleParserError
   from ansible.plugins.lookup import LookupBase
-
-  try:
-      from __main__ import display
-  except ImportError:
   from ansible.utils.display import Display
+
   display = Display()
 
 

docs/docsite/rst/dev_guide/testing/sanity/no-main-display.rst

@@ -0,0 +1,12 @@
+Sanity Tests » no-main-display
+==============================
+
+As of Ansible 2.8, ``Display`` should no longer be imported from ``__main__``.
+
+``Display`` is now a singleton and should be utilized like the following::
+
+   from ansible.utils.display import Display
+   display = Display()
+
+There is no longer a need to attempt ``from __main__ import display`` inside
+a ``try/except`` block.

docs/docsite/rst/porting_guides/porting_guide_2.0.rst

@@ -332,8 +332,8 @@ As a simple example we are going to make a hybrid ``fileglob`` lookup plugin.
         from ansible.utils import (listify_lookup_plugin_terms, path_dwim, warning)
     except ImportError:
         # ansible-2.0
-        from __main__ import display
-        warning = display.warning
+        from ansible.utils.display import Display
+        warning = Display().warning
 
     class LookupModule(LookupBase):
 

docs/docsite/rst/porting_guides/porting_guide_2.8.rst

@@ -124,7 +124,28 @@ Plugins
 Porting custom scripts
 ======================
 
-No notable changes.
+Display class
+-------------
+
+As of Ansible 2.8, the ``Display`` class is now a "singleton". Instead of using ``__main__.display`` each file should
+import and instantiate ``ansible.utils.display.Display`` on it's own.
+
+**OLD** In Ansible 2.7 (and earlier) the following was used to access the ``display`` object:
+
+.. code-block:: python
+
+   try:
+       from __main__ import display
+   except ImportError:
+       from ansible.utils.display import Display
+       display = Display()
+
+**NEW** In Ansible 2.8 the following should be used:
+
+.. code-block:: python
+
+   from ansible.utils.display import Display
+   display = Display()
 
 Networking
 ==========

lib/ansible/cli/__init__.py

@@ -40,15 +40,12 @@ from ansible.module_utils.six import with_metaclass, string_types
 from ansible.module_utils._text import to_bytes, to_text
 from ansible.parsing.dataloader import DataLoader
 from ansible.release import __version__
+from ansible.utils.display import Display
 from ansible.utils.path import unfrackpath
 from ansible.utils.vars import load_extra_vars, load_options_vars
 from ansible.vars.manager import VariableManager
 from ansible.parsing.vault import PromptVaultSecret, get_file_vault_secret
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/cli/adhoc.py

@@ -18,8 +18,6 @@
 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
-########################################################
-
 from ansible import constants as C
 from ansible.cli import CLI
 from ansible.errors import AnsibleError, AnsibleOptionsError
@@ -29,15 +27,10 @@ from ansible.parsing.splitter import parse_kv
 from ansible.playbook import Playbook
 from ansible.playbook.play import Play
 from ansible.plugins.loader import get_all_plugin_loaders
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
+display = Display()
 
-########################################################
 
 class AdHocCLI(CLI):
     ''' is an extra-simple tool/framework/API for doing 'remote things'.

lib/ansible/cli/config.py

@@ -16,13 +16,9 @@ from ansible.errors import AnsibleError, AnsibleOptionsError
 from ansible.module_utils._text import to_native, to_text
 from ansible.parsing.yaml.dumper import AnsibleDumper
 from ansible.utils.color import stringc
+from ansible.utils.display import Display
 from ansible.utils.path import unfrackpath
 
-
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/cli/console.py

@@ -46,11 +46,8 @@ from ansible.playbook.play import Play
 from ansible.plugins.loader import module_loader, fragment_loader
 from ansible.utils import plugin_docs
 from ansible.utils.color import stringc
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/cli/doc.py

@@ -35,12 +35,9 @@ from ansible.parsing.metadata import extract_metadata
 from ansible.parsing.plugin_docs import read_docstub
 from ansible.parsing.yaml.dumper import AnsibleDumper
 from ansible.plugins.loader import action_loader, fragment_loader
+from ansible.utils.display import Display
 from ansible.utils.plugin_docs import BLACKLIST, get_docstring
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/cli/galaxy.py

@@ -41,11 +41,8 @@ from ansible.galaxy.role import GalaxyRole
 from ansible.galaxy.token import GalaxyToken
 from ansible.module_utils._text import to_native, to_text
 from ansible.playbook.role.requirement import RoleRequirement
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/cli/inventory.py

@@ -27,11 +27,8 @@ from ansible.inventory.host import Host
 from ansible.plugins.loader import vars_loader
 from ansible.parsing.dataloader import DataLoader
 from ansible.utils.vars import combine_vars
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 INTERNAL_VARS = frozenset(['ansible_diff_mode',

lib/ansible/cli/playbook.py

@@ -15,8 +15,6 @@
 # You should have received a copy of the GNU General Public License
 # along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
 
-########################################################
-
 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
@@ -28,11 +26,8 @@ from ansible.errors import AnsibleError, AnsibleOptionsError
 from ansible.executor.playbook_executor import PlaybookExecutor
 from ansible.playbook.block import Block
 from ansible.playbook.play_context import PlayContext
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/cli/pull.py

@@ -18,7 +18,6 @@
 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
-########################################################
 import datetime
 import os
 import platform
@@ -34,15 +33,10 @@ from ansible.errors import AnsibleOptionsError
 from ansible.module_utils._text import to_native, to_text
 from ansible.plugins.loader import module_loader
 from ansible.utils.cmd_functions import run_cmd
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
+display = Display()
 
-########################################################
 
 class PullCLI(CLI):
     ''' is used to up a remote copy of ansible on each managed node,

lib/ansible/cli/vault.py

@@ -28,11 +28,8 @@ from ansible.errors import AnsibleOptionsError
 from ansible.module_utils._text import to_text, to_bytes
 from ansible.parsing.dataloader import DataLoader
 from ansible.parsing.vault import VaultEditor, VaultLib, match_encrypt_secret
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/constants.py

@@ -20,8 +20,8 @@ from ansible.config.manager import ConfigManager, ensure_type, get_ini_config_va
 def _warning(msg):
     ''' display is not guaranteed here, nor it being the full class, but try anyways, fallback to sys.stderr.write '''
     try:
-        from __main__ import display
-        display.warning(msg)
+        from ansible.utils.display import Display
+        Display().warning(msg)
     except Exception:
         import sys
         sys.stderr.write(' [WARNING] %s\n' % (msg))
@@ -30,8 +30,8 @@ def _warning(msg):
 def _deprecated(msg, version='2.8'):
     ''' display is not guaranteed here, nor it being the full class, but try anyways, fallback to sys.stderr.write '''
     try:
-        from __main__ import display
-        display.deprecated(msg, version=version)
+        from ansible.utils.display import Display
+        Display().deprecated(msg, version=version)
     except Exception:
         import sys
         sys.stderr.write(' [DEPRECATED] %s, to be removed in %s\n' % (msg, version))

lib/ansible/executor/module_common.py

@@ -42,12 +42,9 @@ from ansible.plugins.loader import module_utils_loader
 # variable to the object and then it never gets updated.
 from ansible.executor import action_write_locks
 
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
+display = Display()
 
 REPLACER = b"#<<INCLUDE_ANSIBLE_MODULE_COMMON>>"
 REPLACER_VERSION = b"\"<<ANSIBLE_VERSION>>\""

lib/ansible/executor/play_iterator.py

@@ -26,12 +26,9 @@ from ansible.module_utils.six import iteritems
 from ansible.module_utils.parsing.convert_bool import boolean
 from ansible.playbook.block import Block
 from ansible.playbook.task import Task
+from ansible.utils.display import Display
 
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/executor/playbook_executor.py

@@ -30,11 +30,8 @@ from ansible.utils.helpers import pct_to_int
 from ansible.module_utils.parsing.convert_bool import boolean
 from ansible.utils.path import makedirs_safe
 from ansible.utils.ssh_functions import check_for_controlpersist
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/executor/process/worker.py

@@ -40,15 +40,12 @@ from ansible.errors import AnsibleConnectionFailure
 from ansible.executor.task_executor import TaskExecutor
 from ansible.executor.task_result import TaskResult
 from ansible.module_utils._text import to_text
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
 __all__ = ['WorkerProcess']
 
+display = Display()
+
 
 class WorkerProcess(multiprocessing.Process):
     '''

lib/ansible/executor/task_executor.py

@@ -25,12 +25,9 @@ from ansible.template import Templar
 from ansible.utils.listify import listify_lookup_plugin_terms
 from ansible.utils.unsafe_proxy import UnsafeProxy, wrap_var
 from ansible.vars.clean import namespace_facts, clean_facts
+from ansible.utils.display import Display
 from ansible.utils.vars import combine_vars
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/executor/task_queue_manager.py

@@ -38,16 +38,13 @@ from ansible.template import Templar
 from ansible.utils.helpers import pct_to_int
 from ansible.vars.hostvars import HostVars
 from ansible.vars.reserved import warn_if_reserved
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
 
 __all__ = ['TaskQueueManager']
 
+display = Display()
+
 
 class TaskQueueManager:
 

lib/ansible/galaxy/api.py

@@ -32,11 +32,8 @@ from ansible.module_utils.six.moves.urllib.error import HTTPError
 from ansible.module_utils.six.moves.urllib.parse import quote as urlquote, urlencode
 from ansible.module_utils._text import to_bytes, to_native, to_text
 from ansible.module_utils.urls import open_url
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/galaxy/login.py

@@ -31,11 +31,8 @@ from ansible.module_utils.six.moves.urllib.parse import quote as urlquote, urlpa
 from ansible.module_utils.six.moves.urllib.error import HTTPError
 from ansible.module_utils.urls import open_url
 from ansible.utils.color import stringc
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/galaxy/role.py

@@ -36,11 +36,8 @@ from ansible.module_utils._text import to_native, to_text
 from ansible.module_utils.urls import open_url
 from ansible.playbook.role.requirement import RoleRequirement
 from ansible.galaxy.api import GalaxyAPI
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/galaxy/token.py

@@ -26,10 +26,8 @@ from stat import S_IRUSR, S_IWUSR
 
 import yaml
 
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/inventory/data.py

@@ -26,13 +26,10 @@ from ansible.errors import AnsibleError
 from ansible.inventory.group import Group
 from ansible.inventory.host import Host
 from ansible.module_utils.six import iteritems, string_types
+from ansible.utils.display import Display
 from ansible.utils.vars import combine_vars
 from ansible.utils.path import basedir
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/inventory/manager.py

@@ -32,11 +32,8 @@ from ansible.module_utils._text import to_bytes, to_text
 from ansible.parsing.utils.addresses import parse_address
 from ansible.plugins.loader import inventory_loader
 from ansible.utils.path import unfrackpath
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 IGNORED_ALWAYS = [br"^\.", b"^host_vars$", b"^group_vars$", b"^vars_plugins$"]

lib/ansible/parsing/dataloader.py

@@ -21,11 +21,8 @@ from ansible.parsing.quoting import unquote
 from ansible.parsing.utils.yaml import from_yaml
 from ansible.parsing.vault import VaultLib, b_HEADER, is_encrypted, is_encrypted_file, parse_vaulttext_envelope
 from ansible.utils.path import unfrackpath
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/parsing/plugin_docs.py

@@ -11,11 +11,8 @@ import yaml
 from ansible.module_utils._text import to_text
 from ansible.parsing.metadata import extract_metadata
 from ansible.parsing.yaml.loader import AnsibleLoader
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/parsing/vault/__init__.py

@@ -75,12 +75,9 @@ from ansible.module_utils.six import PY3, binary_type
 # Note: on py2, this zip is izip not the list based zip() builtin
 from ansible.module_utils.six.moves import zip
 from ansible.module_utils._text import to_bytes, to_text, to_native
+from ansible.utils.display import Display
 from ansible.utils.path import makedirs_safe
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/parsing/yaml/constructor.py

@@ -27,11 +27,8 @@ from ansible.parsing.yaml.objects import AnsibleMapping, AnsibleSequence, Ansibl
 from ansible.parsing.yaml.objects import AnsibleVaultEncryptedUnicode
 from ansible.utils.unsafe_proxy import wrap_var
 from ansible.parsing.vault import VaultLib
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/playbook/__init__.py

@@ -27,11 +27,8 @@ from ansible.module_utils._text import to_text, to_native
 from ansible.playbook.play import Play
 from ansible.playbook.playbook_include import PlaybookInclude
 from ansible.plugins.loader import get_all_plugin_loaders
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/playbook/base.py

@@ -21,11 +21,8 @@ from ansible.module_utils._text import to_text, to_native
 from ansible.playbook.attribute import Attribute, FieldAttribute
 from ansible.parsing.dataloader import DataLoader
 from ansible.utils.vars import combine_vars, isidentifier, get_unique_id
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/playbook/become.py

@@ -22,11 +22,8 @@ __metaclass__ = type
 from ansible import constants as C
 from ansible.errors import AnsibleParserError
 from ansible.playbook.attribute import FieldAttribute
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/playbook/conditional.py

@@ -29,13 +29,9 @@ from ansible.errors import AnsibleError, AnsibleUndefinedVariable
 from ansible.module_utils.six import text_type
 from ansible.module_utils._text import to_native
 from ansible.playbook.attribute import FieldAttribute
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
+display = Display()
 
 DEFINED_REGEX = re.compile(r'(hostvars\[.+\]|[\w_]+)\s+(not\s+is|is|is\s+not)\s+(defined|undefined)')
 LOOKUP_REGEX = re.compile(r'lookup\s*\(')

lib/ansible/playbook/helpers.py

@@ -25,11 +25,8 @@ from ansible.errors import AnsibleParserError, AnsibleUndefinedVariable, Ansible
 from ansible.module_utils._text import to_native
 from ansible.module_utils.six import string_types
 from ansible.parsing.mod_args import ModuleArgsParser
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/playbook/included_file.py

@@ -24,11 +24,8 @@ import os
 from ansible.playbook.task_include import TaskInclude
 from ansible.playbook.role_include import IncludeRole
 from ansible.template import Templar
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/playbook/play.py

@@ -30,11 +30,8 @@ from ansible.playbook.helpers import load_list_of_blocks, load_list_of_roles
 from ansible.playbook.role import Role
 from ansible.playbook.taggable import Taggable
 from ansible.vars.manager import preprocess_vars
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/playbook/play_context.py

@@ -37,13 +37,10 @@ from ansible.module_utils.parsing.convert_bool import boolean
 from ansible.playbook.attribute import FieldAttribute
 from ansible.playbook.base import Base
 from ansible.plugins import get_plugin_class
+from ansible.utils.display import Display
 from ansible.utils.ssh_functions import check_for_controlpersist
 
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/playbook/role/definition.py

@@ -32,16 +32,12 @@ from ansible.playbook.conditional import Conditional
 from ansible.playbook.taggable import Taggable
 from ansible.template import Templar
 from ansible.utils.path import unfrackpath
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
-
 
 __all__ = ['RoleDefinition']
 
+display = Display()
+
 
 class RoleDefinition(Base, Become, Conditional, Taggable):
 

lib/ansible/playbook/role/requirement.py

@@ -31,11 +31,10 @@ from ansible.module_utils._text import to_native
 from ansible.module_utils.common.process import get_bin_path
 from ansible.module_utils.six import string_types
 from ansible.playbook.role.definition import RoleDefinition
-
+from ansible.utils.display import Display
 
 __all__ = ['RoleRequirement']
 
-
 VALID_SPEC_KEYS = [
     'name',
     'role',
@@ -44,10 +43,6 @@ VALID_SPEC_KEYS = [
     'version',
 ]
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/playbook/role_include.py

@@ -1,4 +1,3 @@
-
 #
 # This file is part of Ansible
 #
@@ -27,15 +26,12 @@ from ansible.playbook.block import Block
 from ansible.playbook.task_include import TaskInclude
 from ansible.playbook.role import Role
 from ansible.playbook.role.include import RoleInclude
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
 __all__ = ['IncludeRole']
 
+display = Display()
+
 
 class IncludeRole(TaskInclude):
 

lib/ansible/playbook/task.py

@@ -36,16 +36,12 @@ from ansible.playbook.conditional import Conditional
 from ansible.playbook.loop_control import LoopControl
 from ansible.playbook.role import Role
 from ansible.playbook.taggable import Taggable
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
 __all__ = ['Task']
 
+display = Display()
+
 
 class Task(Base, Conditional, Taggable, Become):
 

lib/ansible/playbook/task_include.py

@@ -24,15 +24,12 @@ from ansible.errors import AnsibleParserError
 from ansible.playbook.attribute import FieldAttribute
 from ansible.playbook.block import Block
 from ansible.playbook.task import Task
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
 __all__ = ['TaskInclude']
 
+display = Display()
+
 
 class TaskInclude(Task):
 

lib/ansible/plugins/__init__.py

@@ -25,11 +25,8 @@ from abc import ABCMeta
 
 from ansible import constants as C
 from ansible.module_utils.six import with_metaclass, string_types
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 # Global so that all instances of a PluginLoader will share the caches

lib/ansible/plugins/action/__init__.py

@@ -26,14 +26,11 @@ from ansible.module_utils.six.moves import shlex_quote
 from ansible.module_utils._text import to_bytes, to_native, to_text
 from ansible.parsing.utils.jsonify import jsonify
 from ansible.release import __version__
+from ansible.utils.display import Display
 from ansible.utils.unsafe_proxy import wrap_var
 from ansible.vars.clean import remove_internal_keys
 
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/plugins/action/add_host.py

@@ -24,11 +24,8 @@ from ansible.errors import AnsibleError
 from ansible.module_utils.six import string_types
 from ansible.plugins.action import ActionBase
 from ansible.parsing.utils.addresses import parse_address
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/aireos.py

@@ -28,12 +28,8 @@ from ansible.module_utils.connection import Connection
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.aireos.aireos import aireos_provider_spec
 from ansible.module_utils.network.common.utils import load_provider
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/aruba.py

@@ -28,11 +28,8 @@ from ansible.module_utils.connection import Connection
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.aruba.aruba import aruba_provider_spec
 from ansible.module_utils.network.common.utils import load_provider
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/asa.py

@@ -27,12 +27,8 @@ from ansible import constants as C
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.asa.asa import asa_provider_spec
 from ansible.module_utils.network.common.utils import load_provider
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/bigip.py

@@ -28,16 +28,13 @@ from ansible.module_utils._text import to_text
 from ansible.module_utils.connection import Connection
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.plugins.action.normal import ActionModule as _ActionModule
+from ansible.utils.display import Display
 
 try:
     from library.module_utils.network.f5.common import f5_provider_spec
 except:
     from ansible.module_utils.network.f5.common import f5_provider_spec
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/plugins/action/bigiq.py

@@ -28,16 +28,13 @@ from ansible.module_utils._text import to_text
 from ansible.module_utils.connection import Connection
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.plugins.action.normal import ActionModule as _ActionModule
+from ansible.utils.display import Display
 
 try:
     from library.module_utils.network.f5.common import f5_provider_spec
 except:
     from ansible.module_utils.network.f5.common import f5_provider_spec
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/plugins/action/ce.py

@@ -28,12 +28,8 @@ from ansible.module_utils.connection import Connection
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.cloudengine.ce import ce_provider_spec
 from ansible.module_utils.network.common.utils import load_provider
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 CLI_SUPPORTED_MODULES = ['ce_config', 'ce_command']

lib/ansible/plugins/action/cnos.py

@@ -26,12 +26,8 @@ from ansible.module_utils.network.cnos.cnos import cnos_provider_spec
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.module_utils.connection import Connection
 from ansible.module_utils._text import to_text
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/dellos10.py

@@ -30,11 +30,8 @@ from ansible.module_utils.connection import Connection
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.module_utils.network.dellos10.dellos10 import dellos10_provider_spec
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/dellos6.py

@@ -30,11 +30,8 @@ from ansible.module_utils.connection import Connection
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.dellos6.dellos6 import dellos6_provider_spec
 from ansible.module_utils.network.common.utils import load_provider
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/dellos9.py

@@ -30,11 +30,8 @@ from ansible.module_utils.connection import Connection
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.module_utils.network.dellos9.dellos9 import dellos9_provider_spec
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/enos.py

@@ -26,12 +26,8 @@ from ansible.module_utils.network.enos.enos import enos_provider_spec
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.module_utils.connection import Connection
 from ansible.module_utils._text import to_text
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/eos.py

@@ -28,11 +28,8 @@ from ansible.module_utils.connection import Connection
 from ansible.module_utils.network.eos.eos import eos_provider_spec
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.common.utils import load_provider
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/fetch.py

@@ -25,13 +25,10 @@ from ansible.module_utils._text import to_bytes
 from ansible.module_utils.six import string_types
 from ansible.module_utils.parsing.convert_bool import boolean
 from ansible.plugins.action import ActionBase
+from ansible.utils.display import Display
 from ansible.utils.hashing import checksum, checksum_s, md5, secure_hash
 from ansible.utils.path import makedirs_safe
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/plugins/action/ios.py

@@ -28,11 +28,8 @@ from ansible.module_utils.connection import Connection, ConnectionError
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.module_utils.network.ios.ios import ios_provider_spec
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/iosxr.py

@@ -28,11 +28,8 @@ from ansible.module_utils.connection import Connection
 from ansible.module_utils.network.iosxr.iosxr import iosxr_provider_spec
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.common.utils import load_provider
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/ironware.py

@@ -28,11 +28,8 @@ from ansible.module_utils.connection import Connection, ConnectionError
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.module_utils.network.ironware.ironware import ironware_provider_spec
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/junos.py

@@ -29,12 +29,8 @@ from ansible.module_utils.network.common.utils import load_provider
 from ansible.module_utils.network.junos.junos import junos_provider_spec
 from ansible.plugins.loader import connection_loader, module_loader
 from ansible.plugins.action.normal import ActionModule as _ActionModule
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 CLI_SUPPORTED_MODULES = ['junos_netconf', 'junos_command']

lib/ansible/plugins/action/net_base.py

@@ -28,13 +28,10 @@ from ansible.plugins.action import ActionBase
 from ansible.plugins.action.nxos import ActionModule as _NxosActionModule
 from ansible.plugins.action.eos import ActionModule as _EosActionModule
 from ansible.module_utils.network.common.utils import load_provider
+from ansible.utils.display import Display
 
 from imp import find_module, load_module
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 _CLI_ONLY_MODULES = frozenset(['junos_netconf', 'iosxr_netconf', 'iosxr_config', 'iosxr_command'])

lib/ansible/plugins/action/net_get.py

@@ -29,11 +29,8 @@ from ansible.module_utils.connection import Connection
 from ansible.errors import AnsibleError
 from ansible.plugins.action import ActionBase
 from ansible.module_utils.six.moves.urllib.parse import urlsplit
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/net_put.py

@@ -30,11 +30,8 @@ from ansible.module_utils.connection import Connection
 from ansible.errors import AnsibleError
 from ansible.plugins.action import ActionBase
 from ansible.module_utils.six.moves.urllib.parse import urlsplit
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/netconf.py

@@ -23,11 +23,8 @@ import copy
 import sys
 
 from ansible.plugins.action.normal import ActionModule as _ActionModule
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/nxos.py

@@ -29,11 +29,8 @@ from ansible.module_utils.connection import Connection
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.module_utils.network.nxos.nxos import nxos_provider_spec
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/package.py

@@ -19,11 +19,8 @@ __metaclass__ = type
 
 from ansible.errors import AnsibleAction, AnsibleActionFail
 from ansible.plugins.action import ActionBase
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/pause.py

@@ -30,11 +30,8 @@ from ansible.module_utils._text import to_text, to_native
 from ansible.module_utils.parsing.convert_bool import boolean
 from ansible.module_utils.six import PY3
 from ansible.plugins.action import ActionBase
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 try:

lib/ansible/plugins/action/reboot.py

@@ -13,12 +13,8 @@ from datetime import datetime, timedelta
 from ansible.errors import AnsibleError, AnsibleConnectionFailure
 from ansible.module_utils._text import to_native, to_text
 from ansible.plugins.action import ActionBase
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/sros.py

@@ -26,11 +26,8 @@ from ansible import constants as C
 from ansible.plugins.action.normal import ActionModule as _ActionModule
 from ansible.module_utils.network.sros.sros import sros_provider_spec
 from ansible.module_utils.network.common.utils import load_provider
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/telnet.py

@@ -11,11 +11,8 @@ from time import sleep
 from ansible.module_utils._text import to_native, to_bytes
 from ansible.module_utils.six import text_type
 from ansible.plugins.action import ActionBase
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/vyos.py

@@ -28,11 +28,8 @@ from ansible.module_utils._text import to_text
 from ansible.module_utils.connection import Connection
 from ansible.module_utils.network.common.utils import load_provider
 from ansible.module_utils.network.vyos.vyos import vyos_provider_spec
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/wait_for_connection.py

@@ -24,11 +24,8 @@ from datetime import datetime, timedelta
 
 from ansible.module_utils._text import to_text
 from ansible.plugins.action import ActionBase
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/win_reboot.py

@@ -10,11 +10,8 @@ from ansible.errors import AnsibleError
 from ansible.module_utils._text import to_native
 from ansible.plugins.action import ActionBase
 from ansible.plugins.action.reboot import ActionModule as RebootActionModule
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/win_updates.py

@@ -8,11 +8,8 @@ from ansible.module_utils._text import to_text
 from ansible.module_utils.parsing.convert_bool import boolean
 from ansible.parsing.yaml.objects import AnsibleUnicode
 from ansible.plugins.action import ActionBase
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/action/yum.py

@@ -18,11 +18,8 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 from ansible.plugins.action import ActionBase
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/cache/__init__.py

@@ -28,11 +28,8 @@ from ansible.module_utils.six import with_metaclass
 from ansible.module_utils._text import to_bytes
 from ansible.module_utils.common._collections_compat import MutableMapping
 from ansible.plugins.loader import cache_loader
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/callback/__init__.py

@@ -32,12 +32,9 @@ from ansible.module_utils.common._collections_compat import MutableMapping
 from ansible.parsing.ajson import AnsibleJSONEncoder
 from ansible.plugins import AnsiblePlugin, get_plugin_class
 from ansible.utils.color import stringc
+from ansible.utils.display import Display
 from ansible.vars.clean import strip_internal_keys
 
-try:
-    from __main__ import display as global_display
-except ImportError:
-    from ansible.utils.display import Display
 global_display = Display()
 
 try:

lib/ansible/plugins/callback/dense.py

@@ -31,15 +31,13 @@ from ansible.module_utils.six import binary_type, text_type
 from ansible.module_utils.common._collections_compat import MutableMapping, MutableSequence
 from ansible.plugins.callback.default import CallbackModule as CallbackModule_default
 from ansible.utils.color import colorize, hostcolor
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
-    display = Display()
 
 import sys
 
+display = Display()
+
+
 # Design goals:
 #
 #  + On screen there should only be relevant stuff

lib/ansible/plugins/cliconf/__init__.py

@@ -25,7 +25,7 @@ from functools import wraps
 from ansible.plugins import AnsiblePlugin
 from ansible.errors import AnsibleError, AnsibleConnectionFailure
 from ansible.module_utils._text import to_bytes, to_text
-
+from ansible.utils.display import Display
 
 try:
     from scp import SCPClient
@@ -33,10 +33,6 @@ try:
 except ImportError:
     HAS_SCP = False
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/plugins/cliconf/routeros.py

@@ -27,11 +27,8 @@ from itertools import chain
 from ansible.module_utils._text import to_bytes, to_text
 from ansible.module_utils.network.common.utils import to_list
 from ansible.plugins.cliconf import CliconfBase, enable_mode
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/__init__.py

@@ -18,12 +18,9 @@ from ansible.module_utils.six import string_types
 from ansible.module_utils._text import to_bytes, to_text
 from ansible.plugins import AnsiblePlugin
 from ansible.plugins.loader import shell_loader, connection_loader
+from ansible.utils.display import Display
 from ansible.utils.path import unfrackpath
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/plugins/connection/buildah.py

@@ -49,12 +49,8 @@ import subprocess
 import ansible.constants as C
 from ansible.module_utils._text import to_bytes, to_native
 from ansible.plugins.connection import ConnectionBase, ensure_connect
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/chroot.py

@@ -46,12 +46,8 @@ from ansible.module_utils.basic import is_executable
 from ansible.module_utils.six.moves import shlex_quote
 from ansible.module_utils._text import to_bytes
 from ansible.plugins.connection import ConnectionBase, BUFSIZE
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/docker.py

@@ -52,12 +52,8 @@ from ansible.errors import AnsibleError, AnsibleFileNotFound
 from ansible.module_utils.six.moves import shlex_quote
 from ansible.module_utils._text import to_bytes, to_native, to_text
 from ansible.plugins.connection import ConnectionBase, BUFSIZE
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/funcd.py

@@ -38,11 +38,8 @@ import tempfile
 import shutil
 
 from ansible.errors import AnsibleError
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/httpapi.py

@@ -156,11 +156,8 @@ from ansible.module_utils.urls import open_url
 from ansible.playbook.play_context import PlayContext
 from ansible.plugins.loader import cliconf_loader, httpapi_loader
 from ansible.plugins.connection import NetworkConnectionBase
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/iocage.py

@@ -35,11 +35,8 @@ import subprocess
 from ansible.plugins.connection.jail import Connection as Jail
 
 from ansible.errors import AnsibleError
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/jail.py

@@ -42,11 +42,8 @@ from ansible.errors import AnsibleError
 from ansible.module_utils.six.moves import shlex_quote
 from ansible.module_utils._text import to_bytes, to_native, to_text
 from ansible.plugins.connection import ConnectionBase, BUFSIZE
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/kubectl.py

@@ -167,12 +167,8 @@ from ansible.errors import AnsibleError, AnsibleFileNotFound
 from ansible.module_utils.six.moves import shlex_quote
 from ansible.module_utils._text import to_bytes
 from ansible.plugins.connection import ConnectionBase, BUFSIZE
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/libvirt_lxc.py

@@ -36,12 +36,8 @@ from ansible.errors import AnsibleError
 from ansible.module_utils.six.moves import shlex_quote
 from ansible.module_utils._text import to_bytes
 from ansible.plugins.connection import ConnectionBase, BUFSIZE
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/local.py

@@ -28,12 +28,8 @@ from ansible.errors import AnsibleError, AnsibleFileNotFound
 from ansible.module_utils.six import text_type, binary_type
 from ansible.module_utils._text import to_bytes, to_native, to_text
 from ansible.plugins.connection import ConnectionBase
-
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/napalm.py

@@ -131,6 +131,7 @@ options:
 
 from ansible.errors import AnsibleConnectionFailure, AnsibleError
 from ansible.plugins.connection import NetworkConnectionBase
+from ansible.utils.display import Display
 
 try:
     from napalm import get_network_driver
@@ -142,10 +143,6 @@ except ImportError:
         'Please run pip install napalm'
     )
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 

lib/ansible/plugins/connection/netconf.py

@@ -181,6 +181,7 @@ from ansible.module_utils._text import to_bytes, to_native, to_text
 from ansible.module_utils.parsing.convert_bool import BOOLEANS_TRUE, BOOLEANS_FALSE
 from ansible.plugins.loader import netconf_loader
 from ansible.plugins.connection import NetworkConnectionBase
+from ansible.utils.display import Display
 
 try:
     from ncclient import manager
@@ -190,10 +191,6 @@ try:
 except ImportError:
     raise AnsibleError("ncclient is not installed")
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()
 
 logging.getLogger('ncclient').setLevel(logging.INFO)

lib/ansible/plugins/connection/network_cli.py

@@ -192,11 +192,8 @@ from ansible.module_utils._text import to_bytes, to_text
 from ansible.playbook.play_context import PlayContext
 from ansible.plugins.connection import NetworkConnectionBase
 from ansible.plugins.loader import cliconf_loader, terminal_loader, connection_loader
-
-try:
-    from __main__ import display
-except ImportError:
 from ansible.utils.display import Display
+
 display = Display()
 
 

lib/ansible/plugins/connection/paramiko_ssh.py

@@ -144,13 +144,10 @@ from ansible.errors import AnsibleError, AnsibleConnectionFailure, AnsibleFileNo
 from ansible.module_utils.six import iteritems
 from ansible.module_utils.six.moves import input
 from ansible.plugins.connection import ConnectionBase
+from ansible.utils.display import Display
 from ansible.utils.path import makedirs_safe
 from ansible.module_utils._text import to_bytes, to_native, to_text
 
-try:
-    from __main__ import display
-except ImportError:
-    from ansible.utils.display import Display
 display = Display()