mongodb_user: properly guard user adding with try...except (#2582)

The user adding part is not properly guarded by a try...except
block, so pymongo exceptions can escape from it.
Also there's a double-guarding where roles are given.

Fixes: #2575

database/misc/mongodb_user.py

@@ -198,11 +198,7 @@ def user_add(module, client, db_name, user, password, roles):
     if roles is None:
         db.add_user(user, password, False)
     else:
-        try:
+        db.add_user(user, password, None, roles=roles)
-            db.add_user(user, password, None, roles=roles)
-        except OperationFailure, e:
-            err_msg = str(e)
-            module.fail_json(msg=err_msg)
 
 def user_remove(module, client, db_name, user):
     exists = user_find(client, user, db_name)
@@ -346,16 +342,16 @@ def main():
         if password is None and update_password == 'always':
             module.fail_json(msg='password parameter required when adding a user unless update_password is set to on_create')
 
-        uinfo = user_find(client, user, db_name)
+        try:
-        if update_password != 'always' and uinfo:
+            uinfo = user_find(client, user, db_name)
-            password = None
+            if update_password != 'always' and uinfo:
-            if not check_if_roles_changed(uinfo, roles, db_name):
+                password = None
-                module.exit_json(changed=False, user=user)
+                if not check_if_roles_changed(uinfo, roles, db_name):
+                    module.exit_json(changed=False, user=user)
 
-        if module.check_mode:
+            if module.check_mode:
-            module.exit_json(changed=True, user=user)
+                module.exit_json(changed=True, user=user)
 
-        try:
             user_add(module, client, db_name, user, password, roles)
         except OperationFailure, e:
             module.fail_json(msg='Unable to add or update user: %s' % str(e))