Make env param a dict type instead of list

Also modifies param type checking code to remove whitespace from
around params before splitting them into k=v pairs.

Fixes #8199

lib/ansible/module_utils/basic.py

@@ -808,7 +808,7 @@ class AnsibleModule(object):
                                     self.fail_json(msg="unable to evaluate dictionary for %s" % k)
                                 self.params[k] = result
                         elif '=' in value:
-                            self.params[k] = dict([x.split("=", 1) for x in value.split(",")])
+                            self.params[k] = dict([x.strip().split("=", 1) for x in value.split(",")])
                         else:
                             self.fail_json(msg="dictionary requested, could not parse JSON or key=value")
                     else:

library/cloud/docker

@@ -411,9 +411,7 @@ class DockerManager:
         if self.module.params.get('links'):
             self.links = self.get_links(self.module.params.get('links'))
 
-        self.env = None
-        if self.module.params.get('env'):
-            self.env = dict(map(lambda x: x.split("=", 1), self.module.params.get('env')))
+        self.env = self.module.params.get('env', None)
 
         # connect to docker server
         docker_url = urlparse(module.params.get('docker_url'))
@@ -706,7 +704,7 @@ def main():
             password        = dict(),
             email           = dict(),
             hostname        = dict(default=None),
-            env             = dict(type='list'),
+            env             = dict(type='dict'),
             dns             = dict(),
             detach          = dict(default=True, type='bool'),
             state           = dict(default='running', choices=['absent', 'present', 'running', 'stopped', 'killed', 'restarted']),