mirror of https://github.com/ansible/ansible.git
[service] Fix bug with upstart detection
Upstart scripts are being incorrectly identified as SysV init scripts due to a logic error in the `service` module. Because upstart uses multiple commands (`/sbin/start`, `/sbin/stop`, etc.) for managing service state, the codepath for upstart sets `self.svc_cmd` to an empty string on line 451. Empty strings are considered a non-truthy value in Python, so conditionals which are checking the state of `self.svc_cmd` should explicitly compare it to `None` to avoid overlooking the fact that the service may be controlled by an upstart script.reviewable/pr18780/r1
parent
79844506db
commit
8d53ef2f60
Loading…
Reference in New Issue