Adds better error handling to f5 api connections (#35020)

Previously, the failure of the API connection would result
in a stack trace. This patch makes the failure capable of exiting
with fail_json

lib/ansible/module_utils/network/f5/bigip.py

@@ -16,19 +16,27 @@ except ImportError:
 
 try:
     from library.module_utils.network.f5.common import F5BaseClient
+    from library.module_utils.network.f5.common import F5ModuleError
 except ImportError:
     from ansible.module_utils.network.f5.common import F5BaseClient
+    from ansible.module_utils.network.f5.common import F5ModuleError
 
 
 class F5Client(F5BaseClient):
     @property
     def api(self):
-        result = ManagementRoot(
+        try:
-            self.params['server'],
+            result = ManagementRoot(
-            self.params['user'],
+                self.params['server'],
-            self.params['password'],
+                self.params['user'],
-            port=self.params['server_port'],
+                self.params['password'],
-            verify=self.params['validate_certs'],
+                port=self.params['server_port'],
-            token='tmos'
+                verify=self.params['validate_certs'],
-        )
+                token='tmos'
+            )
+        except Exception:
+            raise F5ModuleError(
+                'Unable to connect to {0} on port {1}. '
+                'Is "validate_certs" preventing this?'.format(self.params['server'], self.params['server_port'])
+            )
         return result

lib/ansible/module_utils/network/f5/bigiq.py

@@ -14,18 +14,29 @@ try:
 except ImportError:
     HAS_F5SDK = False
 
-from ansible.module_utils.network.f5.common import F5BaseClient
+try:
+    from library.module_utils.network.f5.common import F5BaseClient
+    from library.module_utils.network.f5.common import F5ModuleError
+except ImportError:
+    from ansible.module_utils.network.f5.common import F5BaseClient
+    from ansible.module_utils.network.f5.common import F5ModuleError
 
 
 class F5Client(F5BaseClient):
     @property
     def api(self):
-        result = ManagementRoot(
+        try:
-            self.params['server'],
+            result = ManagementRoot(
-            self.params['user'],
+                self.params['server'],
-            self.params['password'],
+                self.params['user'],
-            port=self.params['server_port'],
+                self.params['password'],
-            verify=self.params['validate_certs'],
+                port=self.params['server_port'],
-            token='local'
+                verify=self.params['validate_certs'],
-        )
+                token='local'
+            )
+        except Exception:
+            raise F5ModuleError(
+                'Unable to connect to {0} on port {1}. '
+                'Is "validate_certs" preventing this?'.format(self.params['server'], self.params['server_port'])
+            )
         return result

lib/ansible/module_utils/network/f5/iworkflow.py

@@ -14,18 +14,29 @@ try:
 except ImportError:
     HAS_F5SDK = False
 
-from ansible.module_utils.network.f5.common import F5BaseClient
+try:
+    from library.module_utils.network.f5.common import F5BaseClient
+    from library.module_utils.network.f5.common import F5ModuleError
+except ImportError:
+    from ansible.module_utils.network.f5.common import F5BaseClient
+    from ansible.module_utils.network.f5.common import F5ModuleError
 
 
 class F5Client(F5BaseClient):
     @property
     def api(self):
-        result = ManagementRoot(
+        try:
-            self.params['server'],
+            result = ManagementRoot(
-            self.params['user'],
+                self.params['server'],
-            self.params['password'],
+                self.params['user'],
-            port=self.params['server_port'],
+                self.params['password'],
-            verify=self.params['validate_certs'],
+                port=self.params['server_port'],
-            token='local'
+                verify=self.params['validate_certs'],
-        )
+                token='local'
+            )
+        except Exception:
+            raise F5ModuleError(
+                'Unable to connect to {0} on port {1}. '
+                'Is "validate_certs" preventing this?'.format(self.params['server'], self.params['server_port'])
+            )
         return result