mirror of https://github.com/ansible/ansible.git
Enable wildcard import pylint (#35786)
* Wildcard imports should be taken care of. Enable the pylint check for them * Remove wildcard import code-smell test as we're now checking via pylint * Add unused-wildcard-import as ignored in our compat code. These three files use wildcard imports so that they can export symbols in a compatible location. The real code lives elsewhere. So disable the pylint tests for the relevant sections of code.pull/30318/head
parent
d31ded47fb
commit
86242e6871
@ -1,31 +0,0 @@
|
||||
#!/bin/sh
|
||||
|
||||
# Only needed until we enable pylint test for wildcard imports
|
||||
|
||||
|
||||
# The first three paths here are valid uses of wildcard imports
|
||||
# unsafe_proxy is backwards compat (pylint disabled added)
|
||||
# module_common.py is picked up from static strings, not from actual imports (pylint won't detect)
|
||||
# test_action.py is picked up from static strings, not from actual imports (pylint won't detect)
|
||||
# mock.py is importing code for an installed library for compat (pylint disabled added)
|
||||
# unittest.py is importing code for an installed library for compat (pylint disabled added)
|
||||
#
|
||||
# Everything else needs to be fixed
|
||||
wildcard_imports=$(find . -path ./test/runner/.tox -prune \
|
||||
-o -path ./lib/ansible/vars/unsafe_proxy.py -prune \
|
||||
-o -path ./lib/ansible/executor/module_common.py -prune \
|
||||
-o -path ./test/units/plugins/action/test_action.py \
|
||||
-o -path ./lib/ansible/compat/tests/mock.py -prune \
|
||||
-o -path ./lib/ansible/compat/tests/unittest.py \
|
||||
-o -name '*.py' -type f -exec grep -H 'import \*' '{}' '+')
|
||||
|
||||
|
||||
if test -n "$wildcard_imports" ; then
|
||||
printf "\n== Wildcard imports detected ==\n"
|
||||
printf "%s" "$wildcard_imports"
|
||||
failures=$(printf "%s" "$wildcard_imports"| wc -l)
|
||||
failures=$((failures + 2))
|
||||
exit "$failures"
|
||||
fi
|
||||
|
||||
exit 0
|
Loading…
Reference in New Issue