gather_facts sees collection networking connection (#76954) (#76963)

needed to properly propagate some arguments by convention: subset, filter

Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
(cherry picked from commit 5bddecb048)

changelogs/fragments/gather_facts_collections.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - gather_facts action now handles the move of base connection plugin types into collections to add/prevent subset argument correctly

lib/ansible/plugins/action/gather_facts.py

@@ -22,8 +22,13 @@ class ActionModule(ActionBase):
 
         # deal with 'setup specific arguments'
         if fact_module not in C._ACTION_SETUP:
+            # TODO: remove in favor of controller side argspec detecing valid arguments
             # network facts modules must support gather_subset
-            if self._connection._load_name not in ('network_cli', 'httpapi', 'netconf'):
+            try:
+                name = self._connection.redirected_names[-1].replace('ansible.netcommon.', '', 1)
+            except (IndexError, AttributeError):
+                name = self._connection._load_name.split('.')[-1]
+            if name not in ('network_cli', 'httpapi', 'netconf'):
                 subset = mod_args.pop('gather_subset', None)
                 if subset not in ('all', ['all']):
                     self._display.warning('Ignoring subset(%s) for %s' % (subset, fact_module))