Remove em dash from the pytest configuration file

On some systems (tested with official Debian Buster-based Python 3.6
docker image), setting the LC_ALL environment variable to en_US.UTF-8
will trigger Python into switching its preferred encoding to ASCII.
If any python process tries to read a non-ASCII file in this scenario,
it will terminate with an error.

And this is exactly what happens to pytest when it tries to load its
configuration that ansible-test supplies because the configuration
contains an em dash.

In order to bypass this issue, we replaced the em dash with a regular
dash and things started working again.

An alternative solution would be to replace the en_US.UTF-8 locale with
something safer, but unfortunately, the en_US.UTF-8 is probably as safe
as it gets.
pull/71769/head
Tadej Borovšak 4 years ago committed by Matt Clay
parent a10af345a9
commit 74a103d655

@ -0,0 +1,4 @@
minor_changes:
- ansible-test - Remove em dash from the Pytest configuration file in order to
be readable on systems where preferred encoding is ASCII.
(https://github.com/ansible/ansible/issues/71739)

@ -3,7 +3,7 @@ xfail_strict = true
mock_use_standalone_module = true mock_use_standalone_module = true
# It was decided to stick with "legacy" (aka "xunit1") for now. # It was decided to stick with "legacy" (aka "xunit1") for now.
# Currently used pytest versions all support xunit2 format too. # Currently used pytest versions all support xunit2 format too.
# Except the one used under Python 2.6 it doesn't process this option # Except the one used under Python 2.6 - it doesn't process this option
# at all. Ref: # at all. Ref:
# https://github.com/ansible/ansible/pull/66445#discussion_r372530176 # https://github.com/ansible/ansible/pull/66445#discussion_r372530176
junit_family = xunit1 junit_family = xunit1

Loading…
Cancel
Save