Addressed FIXME's in hurd.py (Extracted functionality and exit early) (#69226)

* Addressed FIXME's in hurd.py

* Added changelog fragment

* Fix function order

* Added self reference

* Changed to 'is None'

changelogs/fragments/69226-hurd-extract-functionality.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+- hurd - Address FIXMEs. Extract functionality and exit early.

lib/ansible/module_utils/facts/network/hurd.py

@@ -29,25 +29,7 @@ class HurdPfinetNetwork(Network):
     platform = 'GNU'
     _socket_dir = '/servers/socket/'
 
-    def populate(self, collected_facts=None):
+    def assign_network_facts(self, network_facts, fsysopts_path, socket_path):
-        network_facts = {}
-
-        fsysopts_path = self.module.get_bin_path('fsysopts')
-        if fsysopts_path is None:
-            return network_facts
-
-        socket_path = None
-
-        for l in ('inet', 'inet6'):
-            link = os.path.join(self._socket_dir, l)
-            if os.path.exists(link):
-                socket_path = link
-                break
-
-        # FIXME: extract to method
-        # FIXME: exit early on falsey socket_path and un-indent whole block
-
-        if socket_path:
         rc, out, err = self.module.run_command([fsysopts_path, '-L', socket_path])
         # FIXME: build up a interfaces datastructure, then assign into network_facts
         network_facts['interfaces'] = []
@@ -77,9 +59,28 @@ class HurdPfinetNetwork(Network):
                         'address': address,
                         'prefix': prefix,
                     })
+        return network_facts
 
+    def populate(self, collected_facts=None):
+        network_facts = {}
+
+        fsysopts_path = self.module.get_bin_path('fsysopts')
+        if fsysopts_path is None:
+            return network_facts
+
+        socket_path = None
+
+        for l in ('inet', 'inet6'):
+            link = os.path.join(self._socket_dir, l)
+            if os.path.exists(link):
+                socket_path = link
+                break
+
+        if socket_path is None:
             return network_facts
 
+        return self.assign_network_facts(network_facts, fsysopts_path, socket_path)
+
 
 class HurdNetworkCollector(NetworkCollector):
     _platform = 'GNU'