fix linux web app java linux_fx_version (#44715)

pull/44750/head
Yunge Zhu 6 years ago committed by GitHub
parent f1c31cd592
commit 661172ab40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -77,6 +77,7 @@ options:
- node supported value sample, 6.6, 6.9. - node supported value sample, 6.6, 6.9.
- dotnetcore supported value sample, 1.0, 1,1, 1.2. - dotnetcore supported value sample, 1.0, 1,1, 1.2.
- ruby supported value sample, 2.3. - ruby supported value sample, 2.3.
- java supported value sample, 1.8, 1.9 for windows web app. 8 for linux web app.
settings: settings:
description: description:
- List of settings of the framework. - List of settings of the framework.
@ -254,10 +255,10 @@ EXAMPLES = '''
testkey: testvalue testkey: testvalue
frameworks: frameworks:
- name: "java" - name: "java"
version: "1.8" version: "8"
settings: settings:
java_container: "Tomcat" java_container: "Tomcat"
java_container_version: "8.0" java_container_version: "8.5"
''' '''
RETURN = ''' RETURN = '''
@ -299,8 +300,8 @@ deployment_source_spec = dict(
framework_settings_spec = dict( framework_settings_spec = dict(
java_container=dict(type='str'), java_container=dict(type='str', required=True),
java_container_version=dict(type='str') java_container_version=dict(type='str', required=True)
) )
@ -536,6 +537,17 @@ class AzureRMWebApps(AzureRMModuleBase):
self.fail('Unsupported framework {0} for Linux web app.'.format(self.frameworks[0]['name'])) self.fail('Unsupported framework {0} for Linux web app.'.format(self.frameworks[0]['name']))
self.site_config['linux_fx_version'] = (self.frameworks[0]['name'] + '|' + self.frameworks[0]['version']).upper() self.site_config['linux_fx_version'] = (self.frameworks[0]['name'] + '|' + self.frameworks[0]['version']).upper()
if self.frameworks[0]['name'] == 'java':
if self.frameworks[0]['version'] != '8':
self.fail("Linux web app only supports java 8.")
if self.frameworks[0]['settings'] and self.frameworks[0]['settings']['java_container'].lower() != 'tomcat':
self.fail("Linux web app only supports tomcat container.")
if self.frameworks[0]['settings'] and self.frameworks[0]['settings']['java_container'].lower() == 'tomcat':
self.site_config['linux_fx_version'] = 'TOMCAT|' + self.frameworks[0]['settings']['java_container_version'] + '-jre8'
else:
self.site_config['linux_fx_version'] = 'JAVA|8-jre8'
else: else:
for fx in self.frameworks: for fx in self.frameworks:
if fx.get('name') not in self.supported_windows_frameworks: if fx.get('name') not in self.supported_windows_frameworks:
@ -543,6 +555,7 @@ class AzureRMWebApps(AzureRMModuleBase):
else: else:
self.site_config[fx.get('name') + '_version'] = fx.get('version') self.site_config[fx.get('name') + '_version'] = fx.get('version')
if not is_linux:
for fx in self.frameworks: for fx in self.frameworks:
if 'settings' in fx and fx['settings'] is not None: if 'settings' in fx and fx['settings'] is not None:
for key, value in fx['settings'].items(): for key, value in fx['settings'].items():

@ -233,3 +233,22 @@
version: "6.6" version: "6.6"
register: fail_linux_one_framework_only register: fail_linux_one_framework_only
failed_when: fail_linux_one_framework_only.msg != "Can specify one framework only for Linux web app." failed_when: fail_linux_one_framework_only.msg != "Can specify one framework only for Linux web app."
- name: Create a linux web app with java tomcat container
azure_rm_webapp:
resource_group: "{{ resource_group }}"
name: "{{ win_app_name }}13"
plan:
resource_group: "{{ linux_app_plan_resource_group }}"
name: "{{ linux_plan_name }}"
frameworks:
- name: java
version: "8"
settings:
java_container: "tomcat"
java_container_version: "8.5"
register: output
- name: Assert the web app was created
assert:
that: output.changed
Loading…
Cancel
Save