Typo fixes, tighter error handling, corrected check mode support

pull/2919/head
Adam Garside 12 years ago
parent d29d142a2d
commit 628254a8ed

@ -78,7 +78,7 @@ def main():
"tada", "tmyk", "trombone", "vuvuzela",
"yeah", "yodel"]),
),
supports_check_mode=True
supports_check_mode=False
)
subscription = module.params["subscription"]
@ -117,8 +117,14 @@ def main():
req.add_header('User-agent', AGENT)
response = opener.open(req)
except urllib2.HTTPError, e:
if not (200 <= e.code < 300):
module.fail_json(msg="unable to send msg: '%s', campfire api"
" returned error code: '%s'" %
(msg, e.code))
except Exception, e:
module.fail_json(msg="unable to sent msg: %s" % e)
module.fail_json(msg="unable to send msg: %s" % msg)
module.exit_json(changed=True, room=room, msg=msg, notify=notify)

Loading…
Cancel
Save