archive
/
ansible
mirror of https://github.com/ansible/ansible.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #993 from privateip/vca_fw

Browse Source 
refactored vca_fw to use vca common module
reviewable/pr18780/r1
Chrrrles Paul 9 years ago
parent b425a6042a 71ecaeb9f0
commit 608067417e
1 changed files with 159 additions and 209 deletions
Show Stats Download Patch File Download Diff File

344
cloud/vmware/vca_fw.py
Unescape Escape View File

@ -25,6 +25,7 @@ short_description: add remove firewall rules in a gateway in a vca
description: description:
- Adds or removes firewall rules from a gateway in a vca environment - Adds or removes firewall rules from a gateway in a vca environment
version_added: "2.0" version_added: "2.0"
author: Peter Sprygada (@privateip)
options: options:
username: username:
description: description:
@ -118,235 +119,184 @@ EXAMPLES = '''
''' '''
import time, json, xmltodict
HAS_PYVCLOUD = False
try: try:
from pyvcloud.vcloudair import VCA from pyvcloud.schema.vcd.v1_5.schemas.vcloud.networkType import FirewallRuleType
from pyvcloud.schema.vcd.v1_5.schemas.vcloud.networkType import ProtocolsType from pyvcloud.schema.vcd.v1_5.schemas.vcloud.networkType import ProtocolsType
HAS_PYVCLOUD = True
except ImportError: except ImportError:
# normally set a flag here but it will be caught when testing for
# the existence of pyvcloud (see module_utils/vca.py). This just
# protects against generating an exception at runtime
pass pass
SERVICE_MAP = {'vca': 'ondemand', 'vchs': 'subscription', 'vcd': 'vcd'} VALID_PROTO = ['Tcp', 'Udp', 'Icmp', 'Other', 'Any']
LOGIN_HOST = {} VALID_RULE_KEYS = ['policy', 'is_enable', 'enable_logging', 'description',
LOGIN_HOST['vca'] = 'vca.vmware.com' 'dest_ip', 'dest_port', 'source_ip', 'source_port',
LOGIN_HOST['vchs'] = 'vchs.vmware.com' 'protocol']
VALID_RULE_KEYS = ['policy', 'is_enable', 'enable_logging', 'description', 'dest_ip', 'dest_port', 'source_ip', 'source_port', 'protocol']
def protocol_to_tuple(protocol):
def vca_login(module=None): return (protocol.get_Tcp(),
service_type = module.params.get('service_type') protocol.get_Udp(),
username = module.params.get('username') protocol.get_Icmp(),
password = module.params.get('password') protocol.get_Other(),
instance = module.params.get('instance_id') protocol.get_Any())
org = module.params.get('org')
service = module.params.get('service_id') def protocol_to_string(protocol):
vdc_name = module.params.get('vdc_name') protocol = protocol_to_tuple(protocol)
version = module.params.get('api_version') if protocol[0] is True:
verify = module.params.get('verify_certs') return 'Tcp'
if not vdc_name: elif protocol[1] is True:
if service_type == 'vchs': return 'Udp'
vdc_name = module.params.get('service_id') elif protocol[2] is True:
if not org: return 'Icmp'
if service_type == 'vchs': elif protocol[3] is True:
if vdc_name: return 'Other'
org = vdc_name elif protocol[4] is True:
else: return 'Any'
org = service
if service_type == 'vcd': def protocol_to_type(protocol):
host = module.params.get('host') try:
else: protocols = ProtocolsType()
host = LOGIN_HOST[service_type] setattr(protocols, protocol, True)
return protocols
if not username: except AttributeError:
if 'VCA_USER' in os.environ: raise VcaError("The value in protocol is not valid")
username = os.environ['VCA_USER']
if not password: def validate_fw_rules(fw_rules):
if 'VCA_PASS' in os.environ:
password = os.environ['VCA_PASS']
if not username or not password:
module.fail_json(msg = "Either the username or password is not set, please check")
if service_type == 'vchs':
version = '5.6'
if service_type == 'vcd':
if not version:
version == '5.6'
vca = VCA(host=host, username=username, service_type=SERVICE_MAP[service_type], version=version, verify=verify)
if service_type == 'vca':
if not vca.login(password=password):
module.fail_json(msg = "Login Failed: Please check username or password", error=vca.response.content)
if not vca.login_to_instance(password=password, instance=instance, token=None, org_url=None):
s_json = serialize_instances(vca.instances)
module.fail_json(msg = "Login to Instance failed: Seems like instance_id provided is wrong .. Please check",\
valid_instances=s_json)
if not vca.login_to_instance(instance=instance, password=None, token=vca.vcloud_session.token,
org_url=vca.vcloud_session.org_url):
module.fail_json(msg = "Error logging into org for the instance", error=vca.response.content)
return vca
if service_type == 'vchs':
if not vca.login(password=password):
module.fail_json(msg = "Login Failed: Please check username or password", error=vca.response.content)
if not vca.login(token=vca.token):
module.fail_json(msg = "Failed to get the token", error=vca.response.content)
if not vca.login_to_org(service, org):
module.fail_json(msg = "Failed to login to org, Please check the orgname", error=vca.response.content)
return vca
if service_type == 'vcd':
if not vca.login(password=password, org=org):
module.fail_json(msg = "Login Failed: Please check username or password or host parameters")
if not vca.login(password=password, org=org):
module.fail_json(msg = "Failed to get the token", error=vca.response.content)
if not vca.login(token=vca.token, org=org, org_url=vca.vcloud_session.org_url):
module.fail_json(msg = "Failed to login to org", error=vca.response.content)
return vca
def validate_fw_rules(module=None, fw_rules=None):
VALID_PROTO = ['Tcp', 'Udp', 'Icmp', 'Any']
for rule in fw_rules: for rule in fw_rules:
if not isinstance(rule, dict):
module.fail_json(msg="Firewall rules must be a list of dictionaries, Please check", valid_keys=VALID_RULE_KEYS)
for k in rule.keys(): for k in rule.keys():
if k not in VALID_RULE_KEYS: if k not in VALID_RULE_KEYS:
module.fail_json(msg="%s is not a valid key in fw rules, Please check above.." %k, valid_keys=VALID_RULE_KEYS) raise VcaError("%s is not a valid key in fw rules, please "
rule['dest_port'] = rule.get('dest_port', 'Any') "check above.." % k, valid_keys=VALID_RULE_KEYS)
rule['dest_ip'] = rule.get('dest_ip', 'Any')
rule['source_port'] = rule.get('source_port', 'Any') rule['dest_port'] = str(rule.get('dest_port', 'Any')).lower()
rule['source_ip'] = rule.get('source_ip', 'Any') rule['dest_ip'] = rule.get('dest_ip', 'Any').lower()
rule['protocol'] = rule.get('protocol', 'Any') rule['source_port'] = str(rule.get('source_port', 'Any')).lower()
rule['policy'] = rule.get('policy', 'allow') rule['source_ip'] = rule.get('source_ip', 'Any').lower()
rule['is_enable'] = rule.get('is_enable', 'true') rule['protocol'] = rule.get('protocol', 'Any').lower()
rule['enable_logging'] = rule.get('enable_logging', 'false') rule['policy'] = rule.get('policy', 'allow').lower()
rule['is_enable'] = rule.get('is_enable', True)
rule['enable_logging'] = rule.get('enable_logging', False)
rule['description'] = rule.get('description', 'rule added by Ansible') rule['description'] = rule.get('description', 'rule added by Ansible')
if not rule['protocol'] in VALID_PROTO:
module.fail_json(msg="the value in protocol is not valid, valid values are as above", valid_proto=VALID_PROTO)
return fw_rules return fw_rules
def create_protocol_list(protocol): def fw_rules_to_dict(rules):
plist = [] fw_rules = list()
plist.append(protocol.get_Tcp()) for rule in rules:
plist.append(protocol.get_Any()) fw_rules.append(
plist.append(protocol.get_Tcp()) dict(
plist.append(protocol.get_Udp()) dest_port=rule.get_DestinationPortRange().lower(),
plist.append(protocol.get_Icmp()) dest_ip=rule.get_DestinationIp().lower().lower(),
plist.append(protocol.get_Other()) source_port=rule.get_SourcePortRange().lower(),
return plist source_ip=rule.get_SourceIp().lower(),
protocol=protocol_to_string(rule.get_Protocols()).lower(),
policy=rule.get_Policy().lower(),
is_enable=rule.get_IsEnabled(),
enable_logging=rule.get_EnableLogging(),
description=rule.get_Description()
)
)
return fw_rules
def create_fw_rule(is_enable, description, policy, protocol, dest_port,
dest_ip, source_port, source_ip, enable_logging):
def create_protocols_type(protocol): return FirewallRuleType(IsEnabled=is_enable,
all_protocols = {"Tcp": None, "Udp": None, "Icmp": None, "Any": None} Description=description,
all_protocols[protocol] = True Policy=policy,
return ProtocolsType(**all_protocols) Protocols=protocol_to_type(protocol),
DestinationPortRange=dest_port,
DestinationIp=dest_ip,
SourcePortRange=source_port,
SourceIp=source_ip,
EnableLogging=enable_logging)
def main(): def main():
module = AnsibleModule( argument_spec = vca_argument_spec()
argument_spec=dict( argument_spec.update(
username = dict(default=None), dict(
password = dict(default=None), fw_rules = dict(required=True, type='list'),
org = dict(default=None),
service_id = dict(default=None),
instance_id = dict(default=None),
host = dict(default=None),
api_version = dict(default='5.7'),
service_type = dict(default='vca', choices=['vchs', 'vca', 'vcd']),
state = dict(default='present', choices = ['present', 'absent']),
vdc_name = dict(default=None),
gateway_name = dict(default='gateway'), gateway_name = dict(default='gateway'),
fw_rules = dict(required=True, default=None, type='list'), state = dict(default='present', choices=['present', 'absent'])
) )
) )
module = AnsibleModule(argument_spec, supports_check_mode=True)
vdc_name = module.params.get('vdc_name')
org = module.params.get('org')
service = module.params.get('service_id')
state = module.params.get('state')
service_type = module.params.get('service_type')
host = module.params.get('host')
instance_id = module.params.get('instance_id')
fw_rules = module.params.get('fw_rules') fw_rules = module.params.get('fw_rules')
gateway_name = module.params.get('gateway_name') gateway_name = module.params.get('gateway_name')
verify_certs = dict(default=True, type='bool'), vdc_name = module.params['vdc_name']
if not HAS_PYVCLOUD:
module.fail_json(msg="python module pyvcloud is needed for this module")
if service_type == 'vca':
if not instance_id:
module.fail_json(msg="When service type is vca the instance_id parameter is mandatory")
if not vdc_name:
module.fail_json(msg="When service type is vca the vdc_name parameter is mandatory")
if service_type == 'vchs':
if not service:
module.fail_json(msg="When service type vchs the service_id parameter is mandatory")
if not org:
org = service
if not vdc_name:
vdc_name = service
if service_type == 'vcd':
if not host:
module.fail_json(msg="When service type is vcd host parameter is mandatory")
vca = vca_login(module) vca = vca_login(module)
vdc = vca.get_vdc(vdc_name)
if not vdc:
module.fail_json(msg = "Error getting the vdc, Please check the vdc name")
mod_rules = validate_fw_rules(module, fw_rules)
gateway = vca.get_gateway(vdc_name, gateway_name) gateway = vca.get_gateway(vdc_name, gateway_name)
if not gateway: if not gateway:
module.fail_json(msg="Not able to find the gateway %s, please check the gateway_name param" %gateway_name) module.fail_json(msg="Not able to find the gateway %s, please check "
"the gateway_name param" % gateway_name)
fwservice = gateway._getFirewallService()
rules = gateway.get_fw_rules() rules = gateway.get_fw_rules()
existing_rules = [] current_rules = fw_rules_to_dict(rules)
del_rules = []
for rule in rules: try:
current_trait = (create_protocol_list(rule.get_Protocols()), desired_rules = validate_fw_rules(fw_rules)
rule.get_DestinationPortRange(), except VcaError, e:
rule.get_DestinationIp(), module.fail_json(e.message)
rule.get_SourcePortRange(),
rule.get_SourceIp()) result = dict(changed=False)
for idx, val in enumerate(mod_rules): result['current_rules'] = current_rules
trait = (create_protocol_list(create_protocols_type(val['protocol'])), result['desired_rules'] = desired_rules
val['dest_port'], val['dest_ip'], val['source_port'], val['source_ip'])
if current_trait == trait: updates = list()
del_rules.append(mod_rules[idx]) additions = list()
mod_rules.pop(idx) deletions = list()
existing_rules.append(current_trait)
for (index, rule) in enumerate(desired_rules):
if state == 'absent': try:
if len(del_rules) < 1: if rule != current_rules[index]:
module.exit_json(changed=False, msg="Nothing to delete", delete_rules=mod_rules) updates.append((index, rule))
else: except IndexError:
for i in del_rules: additions.append(rule)
gateway.delete_fw_rule(i['protocol'], i['dest_port'], i['dest_ip'], i['source_port'], i['source_ip'])
task = gateway.save_services_configuration() eol = len(current_rules) > len(desired_rules)
if not task: if eol > 0:
module.fail_json(msg="Unable to Delete Rule, please check above error", error=gateway.response.content) for rule in current_rules[eos:]:
if not vca.block_until_completed(task): deletions.append(rule)
module.fail_json(msg="Error while waiting to remove Rule, please check above error", error=gateway.response.content)
module.exit_json(changed=True, msg="Rules Deleted", deleted_rules=del_rules) for rule in additions:
if not module.check_mode:
if len(mod_rules) < 1: rule['protocol'] = rule['protocol'].capitalize()
module.exit_json(changed=False, rules=existing_rules) gateway.add_fw_rule(**rule)
if len(mod_rules) >= 1: result['changed'] = True
for i in mod_rules:
gateway.add_fw_rule(i['is_enable'], i['description'], i['policy'], i['protocol'], i['dest_port'], i['dest_ip'], for index, rule in updates:
i['source_port'], i['source_ip'], i['enable_logging']) if not module.check_mode:
rule = create_fw_rule(**rule)
fwservice.replace_FirewallRule_at(index, rule)
result['changed'] = True
keys = ['protocol', 'dest_port', 'dest_ip', 'source_port', 'source_ip']
for rule in deletions:
if not module.check_mode:
kwargs = dict([(k, v) for k, v in rule.items() if k in keys])
kwargs['protocol'] = protocol_to_string(kwargs['protocol'])
gateway.delete_fw_rule(**kwargs)
result['changed'] = True
if not module.check_mode and result['changed'] == True:
task = gateway.save_services_configuration() task = gateway.save_services_configuration()
if not task: if task:
module.fail_json(msg="Unable to Add Rule, please check above error", error=gateway.response.content) vca.block_until_completed(task)
if not vca.block_until_completed(task):
module.fail_json(msg="Failure in waiting for adding firewall rule", error=gateway.response.content) result['rules_updated'] = count=len(updates)
module.exit_json(changed=True, rules=mod_rules) result['rules_added'] = count=len(additions)
result['rules_deleted'] = count=len(deletions)
return module.exit_json(**result)
# import module snippets # import module snippets
from ansible.module_utils.basic import * from ansible.module_utils.basic import *
from ansible.module_utils.vca import *
if __name__ == '__main__': if __name__ == '__main__':
main() main()

Write Preview
Loading…
Cancel
Save