mirror of https://github.com/ansible/ansible.git
Add uid, and gid to volume clone (#57371)
* and new features * fix issues * fix issues * fix issues * add unit testspull/58642/merge
Chris Archibald
5 years ago
committed by
John L
parent
a7b14ec1be
commit
59feb63d19
@ -0,0 +1,179 @@
|
|||||||
|
# (c) 2018, NetApp, Inc
|
||||||
|
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||||
|
|
||||||
|
''' unit tests ONTAP Ansible module: na_ontap_volume_clone'''
|
||||||
|
|
||||||
|
from __future__ import print_function
|
||||||
|
import json
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
from units.compat import unittest
|
||||||
|
from units.compat.mock import patch
|
||||||
|
from ansible.module_utils import basic
|
||||||
|
from ansible.module_utils._text import to_bytes
|
||||||
|
import ansible.module_utils.netapp as netapp_utils
|
||||||
|
|
||||||
|
from ansible.modules.storage.netapp.na_ontap_volume_clone \
|
||||||
|
import NetAppONTAPVolumeClone as my_module
|
||||||
|
|
||||||
|
if not netapp_utils.has_netapp_lib():
|
||||||
|
pytestmark = pytest.mark.skip('skipping as missing required netapp_lib')
|
||||||
|
|
||||||
|
|
||||||
|
def set_module_args(args):
|
||||||
|
"""prepare arguments so that they will be picked up during module creation"""
|
||||||
|
args = json.dumps({'ANSIBLE_MODULE_ARGS': args})
|
||||||
|
basic._ANSIBLE_ARGS = to_bytes(args) # pylint: disable=protected-access
|
||||||
|
|
||||||
|
|
||||||
|
class AnsibleExitJson(Exception):
|
||||||
|
"""Exception class to be raised by module.exit_json and caught by the test case"""
|
||||||
|
pass
|
||||||
|
|
||||||
|
|
||||||
|
class AnsibleFailJson(Exception):
|
||||||
|
"""Exception class to be raised by module.fail_json and caught by the test case"""
|
||||||
|
pass
|
||||||
|
|
||||||
|
|
||||||
|
def exit_json(*args, **kwargs): # pylint: disable=unused-argument
|
||||||
|
"""function to patch over exit_json; package return data into an exception"""
|
||||||
|
if 'changed' not in kwargs:
|
||||||
|
kwargs['changed'] = False
|
||||||
|
raise AnsibleExitJson(kwargs)
|
||||||
|
|
||||||
|
|
||||||
|
def fail_json(*args, **kwargs): # pylint: disable=unused-argument
|
||||||
|
"""function to patch over fail_json; package return data into an exception"""
|
||||||
|
kwargs['failed'] = True
|
||||||
|
raise AnsibleFailJson(kwargs)
|
||||||
|
|
||||||
|
|
||||||
|
class MockONTAPConnection(object):
|
||||||
|
''' mock server connection to ONTAP host '''
|
||||||
|
|
||||||
|
def __init__(self, kind=None):
|
||||||
|
''' save arguments '''
|
||||||
|
self.type = kind
|
||||||
|
self.xml_in = None
|
||||||
|
self.xml_out = None
|
||||||
|
|
||||||
|
def invoke_successfully(self, xml, enable_tunneling): # pylint: disable=unused-argument
|
||||||
|
''' mock invoke_successfully returning xml data '''
|
||||||
|
self.xml_in = xml
|
||||||
|
if self.type == 'volume_clone':
|
||||||
|
xml = self.build_volume_clone_info()
|
||||||
|
elif self.type == 'volume_clone_fail':
|
||||||
|
raise netapp_utils.zapi.NaApiError(code='TEST', message="This exception is from the unit test")
|
||||||
|
self.xml_out = xml
|
||||||
|
return xml
|
||||||
|
|
||||||
|
@staticmethod
|
||||||
|
def build_volume_clone_info():
|
||||||
|
''' build xml data for volume-clone-info '''
|
||||||
|
xml = netapp_utils.zapi.NaElement('xml')
|
||||||
|
data = {'attributes': {'volume-clone-info': {'volume': 'ansible',
|
||||||
|
'parent-volume': 'ansible'}}}
|
||||||
|
xml.translate_struct(data)
|
||||||
|
return xml
|
||||||
|
|
||||||
|
|
||||||
|
class TestMyModule(unittest.TestCase):
|
||||||
|
''' a group of related Unit Tests '''
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
self.mock_module_helper = patch.multiple(basic.AnsibleModule,
|
||||||
|
exit_json=exit_json,
|
||||||
|
fail_json=fail_json)
|
||||||
|
self.mock_module_helper.start()
|
||||||
|
self.addCleanup(self.mock_module_helper.stop)
|
||||||
|
self.server = MockONTAPConnection()
|
||||||
|
self.onbox = False
|
||||||
|
|
||||||
|
def set_default_args(self):
|
||||||
|
if self.onbox:
|
||||||
|
hostname = '10.10.10.10'
|
||||||
|
username = 'username'
|
||||||
|
password = 'password'
|
||||||
|
vserver = 'ansible'
|
||||||
|
volume = 'ansible'
|
||||||
|
parent_volume = 'ansible'
|
||||||
|
else:
|
||||||
|
hostname = '10.10.10.10'
|
||||||
|
username = 'username'
|
||||||
|
password = 'password'
|
||||||
|
vserver = 'ansible'
|
||||||
|
volume = 'ansible'
|
||||||
|
parent_volume = 'ansible'
|
||||||
|
return dict({
|
||||||
|
'hostname': hostname,
|
||||||
|
'username': username,
|
||||||
|
'password': password,
|
||||||
|
'vserver': vserver,
|
||||||
|
'volume': volume,
|
||||||
|
'parent_volume': parent_volume
|
||||||
|
})
|
||||||
|
|
||||||
|
def test_module_fail_when_required_args_missing(self):
|
||||||
|
''' required arguments are reported as errors '''
|
||||||
|
with pytest.raises(AnsibleFailJson) as exc:
|
||||||
|
set_module_args({})
|
||||||
|
my_module()
|
||||||
|
print('Info: %s' % exc.value.args[0]['msg'])
|
||||||
|
|
||||||
|
def test_ensure_get_called(self):
|
||||||
|
''' test get_volume_clone() for non-existent volume clone'''
|
||||||
|
set_module_args(self.set_default_args())
|
||||||
|
my_obj = my_module()
|
||||||
|
my_obj.server = self.server
|
||||||
|
assert my_obj.get_volume_clone() is None
|
||||||
|
|
||||||
|
def test_ensure_get_called_existing(self):
|
||||||
|
''' test get_volume_clone() for existing volume clone'''
|
||||||
|
set_module_args(self.set_default_args())
|
||||||
|
my_obj = my_module()
|
||||||
|
my_obj.server = MockONTAPConnection(kind='volume_clone')
|
||||||
|
assert my_obj.get_volume_clone()
|
||||||
|
|
||||||
|
@patch('ansible.modules.storage.netapp.na_ontap_volume_clone.NetAppONTAPVolumeClone.create_volume_clone')
|
||||||
|
def test_successful_create(self, create_volume_clone):
|
||||||
|
''' creating volume_clone and testing idempotency '''
|
||||||
|
module_args = {
|
||||||
|
'parent_snapshot': 'abc',
|
||||||
|
'parent_vserver': 'abc',
|
||||||
|
'volume_type': 'dp',
|
||||||
|
'qos_policy_group_name': 'abc',
|
||||||
|
'junction_path': 'abc',
|
||||||
|
'uid': '1',
|
||||||
|
'gid': '1'
|
||||||
|
}
|
||||||
|
module_args.update(self.set_default_args())
|
||||||
|
set_module_args(module_args)
|
||||||
|
my_obj = my_module()
|
||||||
|
if not self.onbox:
|
||||||
|
my_obj.server = self.server
|
||||||
|
with pytest.raises(AnsibleExitJson) as exc:
|
||||||
|
my_obj.apply()
|
||||||
|
assert exc.value.args[0]['changed']
|
||||||
|
create_volume_clone.assert_called_with()
|
||||||
|
# to reset na_helper from remembering the previous 'changed' value
|
||||||
|
my_obj = my_module()
|
||||||
|
if not self.onbox:
|
||||||
|
my_obj.server = MockONTAPConnection('volume_clone')
|
||||||
|
with pytest.raises(AnsibleExitJson) as exc:
|
||||||
|
my_obj.apply()
|
||||||
|
assert not exc.value.args[0]['changed']
|
||||||
|
|
||||||
|
def test_if_all_methods_catch_exception(self):
|
||||||
|
module_args = {}
|
||||||
|
module_args.update(self.set_default_args())
|
||||||
|
set_module_args(module_args)
|
||||||
|
my_obj = my_module()
|
||||||
|
if not self.onbox:
|
||||||
|
my_obj.server = MockONTAPConnection('volume_clone_fail')
|
||||||
|
with pytest.raises(AnsibleFailJson) as exc:
|
||||||
|
my_obj.get_volume_clone()
|
||||||
|
assert 'Error fetching volume clone information ' in exc.value.args[0]['msg']
|
||||||
|
with pytest.raises(AnsibleFailJson) as exc:
|
||||||
|
my_obj.create_volume_clone()
|
||||||
|
assert 'Error creating volume clone: ' in exc.value.args[0]['msg']
|
||||||
Loading…
Reference in New Issue