archive
/
ansible
mirror of https://github.com/ansible/ansible.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[cloud][GCE] fix bug in persistent disk snapshot naming (#23218)

Browse Source 
snapshot_name keeps on prepending the device_name to the same string if more than one device.
result is: disk3-disk2-disk1-MySnapshot
pull/24795/head
Lars Larsson 7 years ago committed by Ryan Brown
parent c1397626fc
commit 53baa36a8b
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File

15
lib/ansible/modules/cloud/google/gce_snapshot.py
Unescape Escape View File

@ -199,31 +199,32 @@ def main():
instance_disks = instance.extra['disks'] instance_disks = instance.extra['disks']
for instance_disk in instance_disks: for instance_disk in instance_disks:
disk_snapshot_name = snapshot_name
device_name = instance_disk['deviceName'] device_name = instance_disk['deviceName']
if disks is None or device_name in disks: if disks is None or device_name in disks:
volume_obj = gce.ex_get_volume(device_name) volume_obj = gce.ex_get_volume(device_name)
# If we have more than one disk to snapshot, prepend the disk name # If we have more than one disk to snapshot, prepend the disk name
if len(instance_disks) > 1: if len(instance_disks) > 1:
snapshot_name = device_name + "-" + snapshot_name disk_snapshot_name = device_name + "-" + disk_snapshot_name
snapshot = find_snapshot(volume_obj, snapshot_name) snapshot = find_snapshot(volume_obj, disk_snapshot_name)
if snapshot and state == 'present': if snapshot and state == 'present':
json_output['snapshots_existing'].append(snapshot_name) json_output['snapshots_existing'].append(disk_snapshot_name)
elif snapshot and state == 'absent': elif snapshot and state == 'absent':
snapshot.destroy() snapshot.destroy()
json_output['changed'] = True json_output['changed'] = True
json_output['snapshots_deleted'].append(snapshot_name) json_output['snapshots_deleted'].append(disk_snapshot_name)
elif not snapshot and state == 'present': elif not snapshot and state == 'present':
volume_obj.snapshot(snapshot_name) volume_obj.snapshot(disk_snapshot_name)
json_output['changed'] = True json_output['changed'] = True
json_output['snapshots_created'].append(snapshot_name) json_output['snapshots_created'].append(disk_snapshot_name)
elif not snapshot and state == 'absent': elif not snapshot and state == 'absent':
json_output['snapshots_absent'].append(snapshot_name) json_output['snapshots_absent'].append(disk_snapshot_name)
module.exit_json(**json_output) module.exit_json(**json_output)

Write Preview
Loading…
Cancel
Save