Minor fix to user module to further streamline setting 'changed' flag

reviewable/pr18780/r1
Stephen Fromm 13 years ago
parent a1f93baa68
commit 50039260e2

16
user

@ -310,20 +310,16 @@ if append not in [ 'yes', 'no' ]:
if name is None: if name is None:
fail_json(msg='name is required') fail_json(msg='name is required')
result = {} rc = None
rc = 0
out = '' out = ''
err = '' err = ''
result = {}
result['name'] = name result['name'] = name
if state == 'absent': if state == 'absent':
if not user_exists(name): if user_exists(name):
result['changed'] = False
else:
(rc, out, err) = user_del(name, force=force, remove=remove) (rc, out, err) = user_del(name, force=force, remove=remove)
if rc != 0: if rc != 0:
fail_json(name=name, msg=err) fail_json(name=name, msg=err)
else:
result['changed'] = True
result['force'] = force result['force'] = force
result['remove'] = remove result['remove'] = remove
elif state == 'present': elif state == 'present':
@ -338,13 +334,13 @@ elif state == 'present':
password=password, append=append) password=password, append=append)
if rc is not None and rc != 0: if rc is not None and rc != 0:
fail_json(name=name, msg=err) fail_json(name=name, msg=err)
if password is not None:
result['password'] = 'NOTLOGGINGPASSWORD'
if rc is None: if rc is None:
result['changed'] = False result['changed'] = False
else: else:
result['changed'] = True result['changed'] = True
if password is not None:
result['password'] = 'NOTLOGGINGPASSWORD'
if out: if out:
result['stdout'] = out result['stdout'] = out
if err: if err:

Loading…
Cancel
Save