ansible-test - Update PSScriptAnalyzer to 1.21.0

changelogs/fragments/psscriptanalyzer-1.21.0.yml

@@ -0,0 +1,4 @@
+minor_changes:
+- >- 
+  ansible-test pslint - Upgrade PSScriptAnalyzer to ``1.21.0`` which enables the ``AvoidMultipleTypeAttributes``,
+  ``AvoidSemicolonsAsLineTerminators``, and ``AvoidUsingBrokenHashAlgorithms`` rules

test/lib/ansible_test/_data/requirements/sanity.pslint.ps1

@@ -28,8 +28,10 @@ Function Install-PSModule {
     }
 }
 
+# Versions changes should be made first in ansible-test which is then synced to
+# the default-test-container over time
 Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
-Install-PSModule -Name PSScriptAnalyzer -RequiredVersion 1.20.0
+Install-PSModule -Name PSScriptAnalyzer -RequiredVersion 1.21.0
 
 if ($IsContainer) {
     # PSScriptAnalyzer contain lots of json files for the UseCompatibleCommands check. We don't use this rule so by

test/lib/ansible_test/_util/controller/sanity/pslint/settings.psd1

@@ -4,6 +4,9 @@
             Enable            = $true
             MaximumLineLength = 160
         }
+        PSAvoidSemicolonsAsLineTerminators = @{
+            Enable = $true
+        }
         PSPlaceOpenBrace                   = @{
             Enable             = $true
             OnSameLine         = $true