Allow cowsay to be removed mid playbook run.

lib/ansible/callbacks.py

@@ -204,27 +204,37 @@ def regular_generic_msg(hostname, result, oneline, caption):
         return "%s | %s >> %s\n" % (hostname, caption, utils.jsonify(result))
 
 
-def banner(msg):
+def banner_cowsay(msg):
+
+    if msg.find(": [") != -1:
+        msg = msg.replace("[","")
+        if msg.endswith("]"):
+            msg = msg[:-1]
+    runcmd = [cowsay,"-W", "60"]
+    if noncow:
+        runcmd.append('-f')
+        runcmd.append(noncow)
+    runcmd.append(msg)
+    cmd = subprocess.Popen(runcmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+    (out, err) = cmd.communicate()
+    return "%s\n" % out
+
+def banner_normal(msg):
+
+    width = 78 - len(msg)
+    if width < 3:
+        width = 3
+    filler = "*" * width
+    return "\n%s %s " % (msg, filler)
 
+def banner(msg):
     if cowsay:
-        if msg.find(": [") != -1:
+        try:
-            msg = msg.replace("[","")
+            return banner_cowsay(msg)
-            if msg.endswith("]"):
+        except OSError:
-                msg = msg[:-1]
+            # somebody cleverly deleted cowsay or something during the PB run.  heh.
-        runcmd = [cowsay,"-W", "60"]
+            return banner_normal(msg)
-        if noncow:
+    return banner_normal(msg)
-            runcmd.append('-f')
-            runcmd.append(noncow)
-        runcmd.append(msg)
-        cmd = subprocess.Popen(runcmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-        (out, err) = cmd.communicate()
-        return "%s\n" % out
-    else:
-        width = 78 - len(msg)
-        if width < 3:
-            width = 3
-        filler = "*" * width
-        return "\n%s %s " % (msg, filler)
 
 def command_generic_msg(hostname, result, oneline, caption):
     ''' output the result of a command run '''