Improved handling of role_version in repo_url_to_role_name

pull/6637/merge
Will Thames 10 years ago committed by Michael DeHaan
parent 1803976a40
commit 4803e923ff

@ -356,6 +356,8 @@ def repo_url_to_role_name(repo_url):
trailing_path = repo_url.split('/')[-1] trailing_path = repo_url.split('/')[-1]
if trailing_path.endswith('.git'): if trailing_path.endswith('.git'):
trailing_path = trailing_path[:-4] trailing_path = trailing_path[:-4]
if ',' in trailing_path:
trailing_path = trailing_path.split(',')[0]
return trailing_path return trailing_path
def json_loads(data): def json_loads(data):

@ -780,6 +780,7 @@ class TestUtils(unittest.TestCase):
def test_repo_url_to_role_name(self): def test_repo_url_to_role_name(self):
tests = [("http://git.example.com/repos/repo.git", "repo"), tests = [("http://git.example.com/repos/repo.git", "repo"),
("ssh://git@git.example.com:repos/role-name", "role-name")] ("ssh://git@git.example.com:repos/role-name", "role-name"),
("ssh://git@git.example.com:repos/role-name,v0.1", "role-name")]
for (url, result) in tests: for (url, result) in tests:
self.assertEqual(ansible.utils.repo_url_to_role_name(url), result) self.assertEqual(ansible.utils.repo_url_to_role_name(url), result)

Loading…
Cancel
Save